All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Giedrius Statkevicius <giedriuswork@gmail.com>
Cc: martink@posteo.de, linux-kernel@vger.kernel.org
Subject: Re: [Bisected] Regression: cpu stuck in gvfsd-fuse, can't shutdown
Date: Wed, 12 Nov 2014 06:05:06 +0900	[thread overview]
Message-ID: <20141111210506.GA26119@kroah.com> (raw)
In-Reply-To: <5462713F.4080406@gmail.com>

On Tue, Nov 11, 2014 at 10:27:43PM +0200, Giedrius Statkevicius wrote:
> Hello,
> Since this commit:
> 
> commit 32eca22180804f71b06b63fd29b72f58be8b3c47
> Author: Martin Kepplinger <martink@posteo.de>
> Date:   Wed Oct 29 20:22:56 2014 +0100
> 
>     misc: always assign miscdevice to file->private_data in open()
>     
>     As of now, a miscdevice driver has to provide an implementation of
>     the open() file operation if it wants to have misc_open() assign a
>     pointer to struct miscdevice to file->private_data for other file
>     operations to use (given the user calls open()).
>     
>     This leads to situations where a miscdevice driver that doesn't need
>     internal operations during open() has to implement open() that only
>     returns immediately, in order to use the data in private_data in other
>     fops.
>     
>     This provides consistent behaviour for miscdevice developers and will
>     always provide the pointer in private_data. A driver's open() fop would,
>     of course, just overwrite it, when using private_data itself.
>     
>     Signed-off-by: Martin Kepplinger <martink@posteo.de>
>     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> I've noticed that my computer freezes a lot and I'm not able to shutdown
> (it just freezes while shutdowning and I have to use SysRq+reisub) and I
> get these messages in my journal:

If you revert this patch, does things go back to "normal" for you?

thanks,

greg k-h

  reply	other threads:[~2014-11-11 21:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-11 20:27 [Bisected] Regression: cpu stuck in gvfsd-fuse, can't shutdown Giedrius Statkevicius
2014-11-11 21:05 ` Greg KH [this message]
2014-11-11 21:44   ` Giedrius Statkevicius
2014-11-12 11:26     ` Thierry Reding
2014-11-12 16:31       ` [PATCH] fuse: don't check for file->private_data on open() Martin Kepplinger
2014-11-12 16:41         ` Martin Kepplinger
2014-11-12 17:23         ` Giedrius Statkevicius
2014-11-12 18:56           ` [PATCH] fuse: Don't check for file->private_data on open(). It is set by the core Martin Kepplinger
2014-11-13  9:40         ` [PATCH] fuse: don't check for file->private_data on open() Miklos Szeredi
2014-11-13 10:05           ` Martin Kepplinger
2014-11-13 10:53             ` Miklos Szeredi
2014-11-13 11:13               ` Martin Kepplinger
2014-11-13 15:34                 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141111210506.GA26119@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=giedriuswork@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martink@posteo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.