All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Kepplinger <martink@posteo.de>
To: miklos@szeredi.hu
Cc: fuse-devel@lists.sourceforge.net, thierry.reding@gmail.com,
	gregkh@linuxfoundation.org, giedriuswork@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fuse: don't check for file->private_data on open().
Date: Wed, 12 Nov 2014 17:41:58 +0100	[thread overview]
Message-ID: <54638DD6.60009@posteo.de> (raw)
In-Reply-To: <1415809894-24084-1-git-send-email-martink@posteo.de>

Am 2014-11-12 um 17:31 schrieb Martin Kepplinger:
> The miscdevice core now sets file->private_data to the struct miscdevice
> so don't fail when this is not NULL.
> 
> Reported-by: Thierry Reding <thierry.reding@gmail.com>
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
> ---
> This is a question: what does this check provide and does overwriting
> file->private_data make any difference?
> 
> Is open() by the user not allowed here, if file->private_data is set?
> 
> thanks!!
> 

if ok, please add

Reported-by: Giedrius Statkevicius <giedriuswork@gmail.com>

thanks

  reply	other threads:[~2014-11-12 16:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-11 20:27 [Bisected] Regression: cpu stuck in gvfsd-fuse, can't shutdown Giedrius Statkevicius
2014-11-11 21:05 ` Greg KH
2014-11-11 21:44   ` Giedrius Statkevicius
2014-11-12 11:26     ` Thierry Reding
2014-11-12 16:31       ` [PATCH] fuse: don't check for file->private_data on open() Martin Kepplinger
2014-11-12 16:41         ` Martin Kepplinger [this message]
2014-11-12 17:23         ` Giedrius Statkevicius
2014-11-12 18:56           ` [PATCH] fuse: Don't check for file->private_data on open(). It is set by the core Martin Kepplinger
2014-11-13  9:40         ` [PATCH] fuse: don't check for file->private_data on open() Miklos Szeredi
2014-11-13 10:05           ` Martin Kepplinger
2014-11-13 10:53             ` Miklos Szeredi
2014-11-13 11:13               ` Martin Kepplinger
2014-11-13 15:34                 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54638DD6.60009@posteo.de \
    --to=martink@posteo.de \
    --cc=fuse-devel@lists.sourceforge.net \
    --cc=giedriuswork@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.