From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: M A Young <m.a.young@durham.ac.uk>
Cc: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>,
Julien Grall <julien.grall@linaro.org>,
Daniel De Graaf <dgdegra@tycho.nsa.gov>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] fix commit xen/arm: Add support for GICv3 for domU
Date: Tue, 11 Nov 2014 21:24:21 -0500 [thread overview]
Message-ID: <20141112022421.GA11959@laptop.dumpdata.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1411111905050.25402@procyon.dur.ac.uk>
On Tue, Nov 11, 2014 at 08:28:38PM +0000, M A Young wrote:
> The build of xen-4.5.0-rc2 fails if XSM_ENABLE=y due to an inconsistency in
> commit fda1614 "xen/arm: Add support for GICv3 for domU" which uses
> XEN_DOMCTL_configure_domain in xen/xsm/flask/hooks.c and
> xen/xsm/flask/policy/access_vectors but XEN_DOMCTL_arm_configure_domain
> elsewhere.
Ouch! Thank you for catching that.
Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
> Michael Young
> In fda1614 ("xen/arm: Add support for GICv3 for domU")
> XEN_DOMCTL_configure_domain is used in xen/xsm/flask/hooks.c and
> xen/xsm/flask/policy/access_vectors but XEN_DOMCTL_arm_configure_domain
> is used elsewhere.
>
> Signed-off-by: Michael Young <m.a.young@durham.ac.uk>
>
> --- xen-4.5.0-rc2/xen/xsm/flask/hooks.c.orig 2014-11-11 14:40:20.000000000 +0000
> +++ xen-4.5.0-rc2/xen/xsm/flask/hooks.c 2014-11-11 18:46:52.926202919 +0000
> @@ -727,7 +727,7 @@
> case XEN_DOMCTL_psr_cmt_op:
> return current_has_perm(d, SECCLASS_DOMAIN2, DOMAIN2__PSR_CMT_OP);
>
> - case XEN_DOMCTL_configure_domain:
> + case XEN_DOMCTL_arm_configure_domain:
> return current_has_perm(d, SECCLASS_DOMAIN2, DOMAIN2__CONFIGURE_DOMAIN);
>
> default:
> --- xen-4.5.0-rc2/xen/xsm/flask/policy/access_vectors.orig 2014-11-11 14:40:20.000000000 +0000
> +++ xen-4.5.0-rc2/xen/xsm/flask/policy/access_vectors 2014-11-11 19:20:41.058175302 +0000
> @@ -102,7 +102,7 @@
> unpause
> # XEN_DOMCTL_resumedomain
> resume
> -# XEN_DOMCTL_createdomain
> +# XEN_DOMCTL_arm_createdomain
> create
> # checked in FLASK_RELABEL_DOMAIN for any relabel operation:
> # source = the old label of the domain
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-11-12 2:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 20:28 [PATCH] fix commit xen/arm: Add support for GICv3 for domU M A Young
2014-11-12 2:24 ` Konrad Rzeszutek Wilk [this message]
2014-11-12 10:59 ` Ian Campbell
2014-11-12 12:38 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141112022421.GA11959@laptop.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Vijaya.Kumar@caviumnetworks.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=julien.grall@linaro.org \
--cc=m.a.young@durham.ac.uk \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.