* [PATCH] fix commit xen/arm: Add support for GICv3 for domU
@ 2014-11-11 20:28 M A Young
2014-11-12 2:24 ` Konrad Rzeszutek Wilk
2014-11-12 12:38 ` Julien Grall
0 siblings, 2 replies; 4+ messages in thread
From: M A Young @ 2014-11-11 20:28 UTC (permalink / raw)
To: xen-devel; +Cc: Vijaya Kumar K, Julien Grall, Daniel De Graaf
[-- Attachment #1: Type: TEXT/PLAIN, Size: 304 bytes --]
The build of xen-4.5.0-rc2 fails if XSM_ENABLE=y due to an inconsistency
in commit fda1614 "xen/arm: Add support for GICv3 for domU" which uses
XEN_DOMCTL_configure_domain in xen/xsm/flask/hooks.c and
xen/xsm/flask/policy/access_vectors but XEN_DOMCTL_arm_configure_domain
elsewhere.
Michael Young
[-- Attachment #2: Type: TEXT/PLAIN, Size: 1194 bytes --]
In fda1614 ("xen/arm: Add support for GICv3 for domU")
XEN_DOMCTL_configure_domain is used in xen/xsm/flask/hooks.c and
xen/xsm/flask/policy/access_vectors but XEN_DOMCTL_arm_configure_domain
is used elsewhere.
Signed-off-by: Michael Young <m.a.young@durham.ac.uk>
--- xen-4.5.0-rc2/xen/xsm/flask/hooks.c.orig 2014-11-11 14:40:20.000000000 +0000
+++ xen-4.5.0-rc2/xen/xsm/flask/hooks.c 2014-11-11 18:46:52.926202919 +0000
@@ -727,7 +727,7 @@
case XEN_DOMCTL_psr_cmt_op:
return current_has_perm(d, SECCLASS_DOMAIN2, DOMAIN2__PSR_CMT_OP);
- case XEN_DOMCTL_configure_domain:
+ case XEN_DOMCTL_arm_configure_domain:
return current_has_perm(d, SECCLASS_DOMAIN2, DOMAIN2__CONFIGURE_DOMAIN);
default:
--- xen-4.5.0-rc2/xen/xsm/flask/policy/access_vectors.orig 2014-11-11 14:40:20.000000000 +0000
+++ xen-4.5.0-rc2/xen/xsm/flask/policy/access_vectors 2014-11-11 19:20:41.058175302 +0000
@@ -102,7 +102,7 @@
unpause
# XEN_DOMCTL_resumedomain
resume
-# XEN_DOMCTL_createdomain
+# XEN_DOMCTL_arm_createdomain
create
# checked in FLASK_RELABEL_DOMAIN for any relabel operation:
# source = the old label of the domain
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fix commit xen/arm: Add support for GICv3 for domU
2014-11-11 20:28 [PATCH] fix commit xen/arm: Add support for GICv3 for domU M A Young
@ 2014-11-12 2:24 ` Konrad Rzeszutek Wilk
2014-11-12 10:59 ` Ian Campbell
2014-11-12 12:38 ` Julien Grall
1 sibling, 1 reply; 4+ messages in thread
From: Konrad Rzeszutek Wilk @ 2014-11-12 2:24 UTC (permalink / raw)
To: M A Young; +Cc: Vijaya Kumar K, Julien Grall, Daniel De Graaf, xen-devel
On Tue, Nov 11, 2014 at 08:28:38PM +0000, M A Young wrote:
> The build of xen-4.5.0-rc2 fails if XSM_ENABLE=y due to an inconsistency in
> commit fda1614 "xen/arm: Add support for GICv3 for domU" which uses
> XEN_DOMCTL_configure_domain in xen/xsm/flask/hooks.c and
> xen/xsm/flask/policy/access_vectors but XEN_DOMCTL_arm_configure_domain
> elsewhere.
Ouch! Thank you for catching that.
Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
> Michael Young
> In fda1614 ("xen/arm: Add support for GICv3 for domU")
> XEN_DOMCTL_configure_domain is used in xen/xsm/flask/hooks.c and
> xen/xsm/flask/policy/access_vectors but XEN_DOMCTL_arm_configure_domain
> is used elsewhere.
>
> Signed-off-by: Michael Young <m.a.young@durham.ac.uk>
>
> --- xen-4.5.0-rc2/xen/xsm/flask/hooks.c.orig 2014-11-11 14:40:20.000000000 +0000
> +++ xen-4.5.0-rc2/xen/xsm/flask/hooks.c 2014-11-11 18:46:52.926202919 +0000
> @@ -727,7 +727,7 @@
> case XEN_DOMCTL_psr_cmt_op:
> return current_has_perm(d, SECCLASS_DOMAIN2, DOMAIN2__PSR_CMT_OP);
>
> - case XEN_DOMCTL_configure_domain:
> + case XEN_DOMCTL_arm_configure_domain:
> return current_has_perm(d, SECCLASS_DOMAIN2, DOMAIN2__CONFIGURE_DOMAIN);
>
> default:
> --- xen-4.5.0-rc2/xen/xsm/flask/policy/access_vectors.orig 2014-11-11 14:40:20.000000000 +0000
> +++ xen-4.5.0-rc2/xen/xsm/flask/policy/access_vectors 2014-11-11 19:20:41.058175302 +0000
> @@ -102,7 +102,7 @@
> unpause
> # XEN_DOMCTL_resumedomain
> resume
> -# XEN_DOMCTL_createdomain
> +# XEN_DOMCTL_arm_createdomain
> create
> # checked in FLASK_RELABEL_DOMAIN for any relabel operation:
> # source = the old label of the domain
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fix commit xen/arm: Add support for GICv3 for domU
2014-11-12 2:24 ` Konrad Rzeszutek Wilk
@ 2014-11-12 10:59 ` Ian Campbell
0 siblings, 0 replies; 4+ messages in thread
From: Ian Campbell @ 2014-11-12 10:59 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: Vijaya Kumar K, Julien Grall, xen-devel, Daniel De Graaf,
M A Young
On Tue, 2014-11-11 at 21:24 -0500, Konrad Rzeszutek Wilk wrote:
> On Tue, Nov 11, 2014 at 08:28:38PM +0000, M A Young wrote:
> > The build of xen-4.5.0-rc2 fails if XSM_ENABLE=y due to an inconsistency in
> > commit fda1614 "xen/arm: Add support for GICv3 for domU" which uses
> > XEN_DOMCTL_configure_domain in xen/xsm/flask/hooks.c and
> > xen/xsm/flask/policy/access_vectors but XEN_DOMCTL_arm_configure_domain
> > elsewhere.
>
> Ouch! Thank you for catching that.
>
> Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Acked + applied, good catch, thanks.
Ian.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fix commit xen/arm: Add support for GICv3 for domU
2014-11-11 20:28 [PATCH] fix commit xen/arm: Add support for GICv3 for domU M A Young
2014-11-12 2:24 ` Konrad Rzeszutek Wilk
@ 2014-11-12 12:38 ` Julien Grall
1 sibling, 0 replies; 4+ messages in thread
From: Julien Grall @ 2014-11-12 12:38 UTC (permalink / raw)
To: M A Young, xen-devel; +Cc: Vijaya Kumar K, Daniel De Graaf
On 11/11/2014 08:28 PM, M A Young wrote:
> The build of xen-4.5.0-rc2 fails if XSM_ENABLE=y due to an inconsistency
> in commit fda1614 "xen/arm: Add support for GICv3 for domU" which uses
> XEN_DOMCTL_configure_domain in xen/xsm/flask/hooks.c and
> xen/xsm/flask/policy/access_vectors but XEN_DOMCTL_arm_configure_domain
> elsewhere.
Sorry, I renamed the hypercall on the later version and didn't check the
XSM build.
Regards,
--
Julien Grall
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-11-12 12:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-11 20:28 [PATCH] fix commit xen/arm: Add support for GICv3 for domU M A Young
2014-11-12 2:24 ` Konrad Rzeszutek Wilk
2014-11-12 10:59 ` Ian Campbell
2014-11-12 12:38 ` Julien Grall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.