All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH/RFC] ARM: shmobile: lager: Fix node name of GPIO keys
Date: Wed, 12 Nov 2014 08:31:11 +0000	[thread overview]
Message-ID: <20141112083111.GV9007@verge.net.au> (raw)
In-Reply-To: <CAMuHMdXaq+VGBvMzxxaLxwv6x+97o3ZxKHops8pZ8hS1jkG6cg@mail.gmail.com>

On Thu, Oct 30, 2014 at 10:48:33AM +0100, Geert Uytterhoeven wrote:
> On Thu, Oct 30, 2014 at 6:56 AM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > From: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> >
> > gpio_keys appears to be consistent with more dts files than gpio-keys
> 
> The closest match on page 17 of ePAPR is "keyboard".
> Should we use that?
> 
> https://www.power.org/wp-content/uploads/2012/06/Power_ePAPR_APPROVED_v1.1.pdf

Sure. I will do a sweep to update that for all our boards.

> > [simon: reworded changelog]
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> > Based on the renesas-devel-20141030-v3.18-rc2 branch of my renesas tree
> >
> >  arch/arm/boot/dts/r8a7790-lager.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> > index 830f2e8..6c05644 100644
> > --- a/arch/arm/boot/dts/r8a7790-lager.dts
> > +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> > @@ -43,7 +43,7 @@
> >                 #size-cells = <1>;
> >         };
> >
> > -       gpio_keys {
> > +       gpio-keys {
> >                 compatible = "gpio-keys";
> >
> >                 button@1 {
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 

WARNING: multiple messages have this Message-ID (diff)
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH/RFC] ARM: shmobile: lager: Fix node name of GPIO keys
Date: Wed, 12 Nov 2014 17:31:11 +0900	[thread overview]
Message-ID: <20141112083111.GV9007@verge.net.au> (raw)
In-Reply-To: <CAMuHMdXaq+VGBvMzxxaLxwv6x+97o3ZxKHops8pZ8hS1jkG6cg@mail.gmail.com>

On Thu, Oct 30, 2014 at 10:48:33AM +0100, Geert Uytterhoeven wrote:
> On Thu, Oct 30, 2014 at 6:56 AM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > From: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> >
> > gpio_keys appears to be consistent with more dts files than gpio-keys
> 
> The closest match on page 17 of ePAPR is "keyboard".
> Should we use that?
> 
> https://www.power.org/wp-content/uploads/2012/06/Power_ePAPR_APPROVED_v1.1.pdf

Sure. I will do a sweep to update that for all our boards.

> > [simon: reworded changelog]
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> > Based on the renesas-devel-20141030-v3.18-rc2 branch of my renesas tree
> >
> >  arch/arm/boot/dts/r8a7790-lager.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> > index 830f2e8..6c05644 100644
> > --- a/arch/arm/boot/dts/r8a7790-lager.dts
> > +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> > @@ -43,7 +43,7 @@
> >                 #size-cells = <1>;
> >         };
> >
> > -       gpio_keys {
> > +       gpio-keys {
> >                 compatible = "gpio-keys";
> >
> >                 button at 1 {
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 

WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux-sh list <linux-sh@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH/RFC] ARM: shmobile: lager: Fix node name of GPIO keys
Date: Wed, 12 Nov 2014 17:31:11 +0900	[thread overview]
Message-ID: <20141112083111.GV9007@verge.net.au> (raw)
In-Reply-To: <CAMuHMdXaq+VGBvMzxxaLxwv6x+97o3ZxKHops8pZ8hS1jkG6cg@mail.gmail.com>

On Thu, Oct 30, 2014 at 10:48:33AM +0100, Geert Uytterhoeven wrote:
> On Thu, Oct 30, 2014 at 6:56 AM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > From: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> >
> > gpio_keys appears to be consistent with more dts files than gpio-keys
> 
> The closest match on page 17 of ePAPR is "keyboard".
> Should we use that?
> 
> https://www.power.org/wp-content/uploads/2012/06/Power_ePAPR_APPROVED_v1.1.pdf

Sure. I will do a sweep to update that for all our boards.

> > [simon: reworded changelog]
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> > Based on the renesas-devel-20141030-v3.18-rc2 branch of my renesas tree
> >
> >  arch/arm/boot/dts/r8a7790-lager.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> > index 830f2e8..6c05644 100644
> > --- a/arch/arm/boot/dts/r8a7790-lager.dts
> > +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> > @@ -43,7 +43,7 @@
> >                 #size-cells = <1>;
> >         };
> >
> > -       gpio_keys {
> > +       gpio-keys {
> >                 compatible = "gpio-keys";
> >
> >                 button@1 {
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 

  reply	other threads:[~2014-11-12  8:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-30  5:56 [PATCH/RFC] ARM: shmobile: lager: Fix node name of GPIO keys Simon Horman
2014-10-30  5:56 ` Simon Horman
2014-10-30  9:48 ` Geert Uytterhoeven
2014-10-30  9:48   ` Geert Uytterhoeven
2014-10-30  9:48   ` Geert Uytterhoeven
2014-11-12  8:31   ` Simon Horman [this message]
2014-11-12  8:31     ` Simon Horman
2014-11-12  8:31     ` Simon Horman
2014-10-30 11:33 ` Sergei Shtylyov
2014-10-30 11:33   ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141112083111.GV9007@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.