From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: bpqw <bpqw-AL4WhLSQfzjQT0dZR+AlfA@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
Florian Vaussard <florian.vaussard-p8DiymsW2f8@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Silvio F <silvio.fricke-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Hayato Suzuki <hytszk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/1 V2] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.
Date: Wed, 12 Nov 2014 10:02:17 +0100 [thread overview]
Message-ID: <20141112090215.GA29664@ulmo.nvidia.com> (raw)
In-Reply-To: <A765B125120D1346A63912DDE6D8B6315EB0ED-xjs9rfTec9KBtk7LW/CC8tTcztV8WXajQQ4Iyu8u01E@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 632 bytes --]
On Wed, Nov 12, 2014 at 01:26:58AM +0000, bpqw wrote:
> >Signed-off-by: bean huo <beanhuo-AL4WhLSQfzjQT0dZR+AlfA@public.gmane.org>
> >Signed-off-by: bpqw <bpqw-AL4WhLSQfzjQT0dZR+AlfA@public.gmane.org>
> >---
> >V2:
> > - Add signed-off-by
> > - Modify commit logs that wrapped to less than 80 columns
>
> Dear maintainers:
>
> Please give some tips,if this patch is OK?thanks!
Patch looks okay to me content-wise, but you might want to use proper
names and capitalization for the From: and Signed-off-by: lines. bpqw
doesn't look like a real name to me, and "bean huo" should probably
be "Bean Huo".
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <treding@nvidia.com>
To: bpqw <bpqw@micron.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Jason Cooper <jason@lakedaemon.net>,
"Mark Brown" <broonie@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
"Florian Vaussard" <florian.vaussard@epfl.ch>,
Andrew Lunn <andrew@lunn.ch>, Silvio F <silvio.fricke@gmail.com>,
Hayato Suzuki <hytszk@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1 V2] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.
Date: Wed, 12 Nov 2014 10:02:17 +0100 [thread overview]
Message-ID: <20141112090215.GA29664@ulmo.nvidia.com> (raw)
In-Reply-To: <A765B125120D1346A63912DDE6D8B6315EB0ED@NTXXIAMBX02.xacn.micron.com>
[-- Attachment #1: Type: text/plain, Size: 574 bytes --]
On Wed, Nov 12, 2014 at 01:26:58AM +0000, bpqw wrote:
> >Signed-off-by: bean huo <beanhuo@micron.com>
> >Signed-off-by: bpqw <bpqw@micron.com>
> >---
> >V2:
> > - Add signed-off-by
> > - Modify commit logs that wrapped to less than 80 columns
>
> Dear maintainers:
>
> Please give some tips,if this patch is OK?thanks!
Patch looks okay to me content-wise, but you might want to use proper
names and capitalization for the From: and Signed-off-by: lines. bpqw
doesn't look like a real name to me, and "bean huo" should probably
be "Bean Huo".
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-11-12 9:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 1:26 [PATCH 1/1 V2] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd bpqw
[not found] ` <A765B125120D1346A63912DDE6D8B6315EB0ED-xjs9rfTec9KBtk7LW/CC8tTcztV8WXajQQ4Iyu8u01E@public.gmane.org>
2014-11-12 9:02 ` Thierry Reding [this message]
2014-11-12 9:02 ` Thierry Reding
[not found] ` <20141112090215.GA29664-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2014-11-12 14:16 ` bpqw
2014-11-12 14:16 ` bpqw
-- strict thread matches above, loose matches on Subject: below --
2014-11-04 13:17 bpqw
2014-11-04 13:17 ` bpqw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141112090215.GA29664@ulmo.nvidia.com \
--to=treding-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=andrew-g2DYL2Zd6BY@public.gmane.org \
--cc=bpqw-AL4WhLSQfzjQT0dZR+AlfA@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=florian.vaussard-p8DiymsW2f8@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=hytszk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=silvio.fricke-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.