From: Christoph Hellwig <hch@lst.de>
To: Dave Chinner <david@fromorbit.com>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 2/2] nfsd: implement chage_attr_type attribute
Date: Wed, 12 Nov 2014 11:24:40 +0100 [thread overview]
Message-ID: <20141112102440.GA31344@lst.de> (raw)
In-Reply-To: <20141111222710.GY23575@dastard>
On Wed, Nov 12, 2014 at 09:27:10AM +1100, Dave Chinner wrote:
> To clarify what Christoph wrote, XFS updates i_version is updated
> once per transaction that modifies the inode. So if a VFS level
> operation results in multiple transactions then each transaction
> will but the version.
>
> It was implemented that way because nobody could tell me what the
> actual granularity requirement for change detection was. Hence what
> I implemented was "be able to detect any persistent change that is
> made" to cover all bases.
Honestly the XFS implementation seems most sensible, and easiest to
verify for me. I don't really understand the rationale behind the
fairly convoluted NFS4_CHANGE_TYPE_IS_VERSION_COUNTER semantics, and
I doubt you could actually implemet them on any Unix-like semantics.
Trond, given that the language in the standard is from you:
1) how do you expect to use NFS4_CHANGE_TYPE_IS_VERSION_COUNTER
semantics in the client
2) what server do you have in mind that could actually implement them?
next prev parent reply other threads:[~2014-11-12 10:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-08 12:11 nfsd: add support for the chage_attr_type attribute Christoph Hellwig
2014-11-08 12:11 ` [PATCH 1/2] nfsd: correctly define v4.2 support attributes Christoph Hellwig
2014-11-10 22:21 ` J. Bruce Fields
2014-11-11 10:22 ` Christoph Hellwig
2014-11-08 12:11 ` [PATCH 2/2] nfsd: implement chage_attr_type attribute Christoph Hellwig
2014-11-10 17:54 ` J. Bruce Fields
2014-11-11 10:27 ` Christoph Hellwig
2014-11-11 12:36 ` Trond Myklebust
2014-11-11 16:27 ` Christoph Hellwig
2014-11-11 22:27 ` Dave Chinner
2014-11-12 10:24 ` Christoph Hellwig [this message]
2014-11-12 14:26 ` Trond Myklebust
2014-11-13 0:28 ` Dave Chinner
2014-11-13 13:02 ` Trond Myklebust
2014-11-13 21:47 ` Dave Chinner
2014-11-13 23:54 ` Dave Chinner
2014-11-14 0:43 ` Trond Myklebust
2014-11-14 4:35 ` Dave Chinner
2014-11-14 14:22 ` Trond Myklebust
2014-11-15 1:24 ` Dave Chinner
2014-11-11 21:42 ` J. Bruce Fields
2014-12-01 19:50 ` J. Bruce Fields
2014-12-02 17:23 ` Christoph Hellwig
2014-11-10 21:42 ` nfsd: add support for the " J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141112102440.GA31344@lst.de \
--to=hch@lst.de \
--cc=bfields@fieldses.org \
--cc=david@fromorbit.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.