All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx: temporarily remove CONFIG_SOC_FSL from LS1021A
Date: Wed, 12 Nov 2014 18:42:41 +0800	[thread overview]
Message-ID: <20141112104239.GJ2704@dragon> (raw)
In-Reply-To: <1727581.y25NQPsRIm@wuerfel>

On Tue, Nov 11, 2014 at 05:03:25PM +0100, Arnd Bergmann wrote:
> The newly introduced LS1021A SoC selects CONFIG_SOC_FSL, which
> is originally symbol used for the PowerPC based platforms
> and guards lots of code that does not build on ARM.
> 
> This breaks allmodconfig, so let's remove it for now, until
> either all those drivers are fixed or they use a dependency
> on IMX instead.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> ---
> On Friday 31 October 2014 17:01:12 Jingchang Lu wrote:
> > From: Jingchang Lu <b35083@freescale.com>
> > 
> > The LS1021A SoC is a dual-core Cortex-A7 based processor,
> > this adds the initial support for it.
> > 
> > Signed-off-by: Jingchang Lu <b35083@freescale.com>
> 
> >  
> > +config FSL_SOC
> > +       bool
> > +
> > +config SOC_LS1021A
> > +       bool "Freescale LS1021A support"
> > +       select ARM_GIC
> > +       select HAVE_ARM_ARCH_TIMER
> > +       select FSL_SOC
> >
> 
> 
> This broke allmodconfig builds in linux-next, please apply this
> partial revert for the moment.

I noticed the issue from 0-DAY testing and was trying to drop the patch.
Jingchang said someone is trying to fixing the issues from driver code.
But it seems to take some time.  So I agree with this partial reverting.

Patch applied.  Thanks Arnd.

Shawn

> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index ef549ef1cd6d..e8627e04e1e6 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -658,14 +658,10 @@ choice
>  
>  endchoice
>  
> -config FSL_SOC
> -	bool
> -
>  config SOC_LS1021A
>  	bool "Freescale LS1021A support"
>  	select ARM_GIC
>  	select HAVE_ARM_ARCH_TIMER
> -	select FSL_SOC
>  	select PCI_DOMAINS if PCI
>  	select ZONE_DMA if ARM_LPAE
>  
> 

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Jingchang Lu
	<jingchang.lu-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ARM: imx: temporarily remove CONFIG_SOC_FSL from LS1021A
Date: Wed, 12 Nov 2014 18:42:41 +0800	[thread overview]
Message-ID: <20141112104239.GJ2704@dragon> (raw)
In-Reply-To: <1727581.y25NQPsRIm@wuerfel>

On Tue, Nov 11, 2014 at 05:03:25PM +0100, Arnd Bergmann wrote:
> The newly introduced LS1021A SoC selects CONFIG_SOC_FSL, which
> is originally symbol used for the PowerPC based platforms
> and guards lots of code that does not build on ARM.
> 
> This breaks allmodconfig, so let's remove it for now, until
> either all those drivers are fixed or they use a dependency
> on IMX instead.
> 
> Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
> 
> ---
> On Friday 31 October 2014 17:01:12 Jingchang Lu wrote:
> > From: Jingchang Lu <b35083-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > 
> > The LS1021A SoC is a dual-core Cortex-A7 based processor,
> > this adds the initial support for it.
> > 
> > Signed-off-by: Jingchang Lu <b35083-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> 
> >  
> > +config FSL_SOC
> > +       bool
> > +
> > +config SOC_LS1021A
> > +       bool "Freescale LS1021A support"
> > +       select ARM_GIC
> > +       select HAVE_ARM_ARCH_TIMER
> > +       select FSL_SOC
> >
> 
> 
> This broke allmodconfig builds in linux-next, please apply this
> partial revert for the moment.

I noticed the issue from 0-DAY testing and was trying to drop the patch.
Jingchang said someone is trying to fixing the issues from driver code.
But it seems to take some time.  So I agree with this partial reverting.

Patch applied.  Thanks Arnd.

Shawn

> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index ef549ef1cd6d..e8627e04e1e6 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -658,14 +658,10 @@ choice
>  
>  endchoice
>  
> -config FSL_SOC
> -	bool
> -
>  config SOC_LS1021A
>  	bool "Freescale LS1021A support"
>  	select ARM_GIC
>  	select HAVE_ARM_ARCH_TIMER
> -	select FSL_SOC
>  	select PCI_DOMAINS if PCI
>  	select ZONE_DMA if ARM_LPAE
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2014-11-12 10:42 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-31  9:01 [PATCHv7 0/6] ARM: imx: Add Freescale LS1021A SoC and board support Jingchang Lu
2014-10-31  9:01 ` Jingchang Lu
2014-10-31  9:01 ` [RESENDv6 1/6] ARM: dts: Add SoC level device tree support for LS1021A Jingchang Lu
2014-10-31  9:01   ` Jingchang Lu
2014-10-31  9:01 ` [PATCHv7 2/6] ARM: dts: Add initial LS1021A QDS board dts support Jingchang Lu
2014-10-31  9:01   ` Jingchang Lu
2014-10-31  9:01 ` [PATCHv7 3/6] ARM: dts: Add initial LS1021A TWR " Jingchang Lu
2014-10-31  9:01   ` Jingchang Lu
2014-10-31  9:01 ` [RESENDv5 4/6] dt-bindings: arm: add Freescale LS1021A SoC device tree binding Jingchang Lu
2014-10-31  9:01   ` Jingchang Lu
2014-10-31  9:01 ` [RESENDv5 5/6] ARM: imx: Add initial support for Freescale LS1021A Jingchang Lu
2014-10-31  9:01   ` Jingchang Lu
2014-11-11 16:03   ` [PATCH] ARM: imx: temporarily remove CONFIG_SOC_FSL from LS1021A Arnd Bergmann
2014-11-11 16:03     ` Arnd Bergmann
2014-11-12 10:42     ` Shawn Guo [this message]
2014-11-12 10:42       ` Shawn Guo
2014-11-12 11:04       ` Arnd Bergmann
2014-11-12 11:04         ` Arnd Bergmann
2014-11-14  9:31         ` Jingchang Lu
2014-11-14  9:31           ` Jingchang Lu
2014-11-14 10:56           ` Arnd Bergmann
2014-11-14 10:56             ` Arnd Bergmann
2014-10-31  9:01 ` [RESENDv6 6/6] ARM: imx: Add Freescale LS1021A SMP support Jingchang Lu
2014-10-31  9:01   ` Jingchang Lu
2014-11-04  5:28 ` [PATCHv7 0/6] ARM: imx: Add Freescale LS1021A SoC and board support Shawn Guo
2014-11-04  5:28   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141112104239.GJ2704@dragon \
    --to=shawn.guo@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.