From: antoine.tenart@free-electrons.com (Antoine Tenart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] net: pxa168_eth: move SET_NETDEV_DEV a bit earlier
Date: Wed, 12 Nov 2014 14:34:45 +0100 [thread overview]
Message-ID: <20141112133445.GC18559@kwain> (raw)
In-Reply-To: <1415790527-6494-1-git-send-email-jszhang@marvell.com>
Hi Jisheng,
On Wed, Nov 12, 2014 at 07:08:47PM +0800, Jisheng Zhang wrote:
> This is to ensure the net_device's dev.parent is set before we used it
> in dma_zalloc_coherent() from init_hash_table().
Applies on top of net-next.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
FWIW,
Acked-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
> drivers/net/ethernet/marvell/pxa168_eth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c b/drivers/net/ethernet/marvell/pxa168_eth.c
> index 21ddece..38f7cee 100644
> --- a/drivers/net/ethernet/marvell/pxa168_eth.c
> +++ b/drivers/net/ethernet/marvell/pxa168_eth.c
> @@ -1540,8 +1540,8 @@ static int pxa168_eth_probe(struct platform_device *pdev)
> if (err)
> goto err_free_mdio;
>
> - pxa168_init_hw(pep);
> SET_NETDEV_DEV(dev, &pdev->dev);
> + pxa168_init_hw(pep);
> err = register_netdev(dev);
> if (err)
> goto err_mdiobus;
> --
> 2.1.3
>
--
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Antoine Tenart <antoine.tenart@free-electrons.com>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: davem@davemloft.net, antoine.tenart@free-electrons.com,
arnd@arndb.de, sebastian.hesselbarth@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] net: pxa168_eth: move SET_NETDEV_DEV a bit earlier
Date: Wed, 12 Nov 2014 14:34:45 +0100 [thread overview]
Message-ID: <20141112133445.GC18559@kwain> (raw)
In-Reply-To: <1415790527-6494-1-git-send-email-jszhang@marvell.com>
Hi Jisheng,
On Wed, Nov 12, 2014 at 07:08:47PM +0800, Jisheng Zhang wrote:
> This is to ensure the net_device's dev.parent is set before we used it
> in dma_zalloc_coherent() from init_hash_table().
Applies on top of net-next.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
FWIW,
Acked-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
> drivers/net/ethernet/marvell/pxa168_eth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c b/drivers/net/ethernet/marvell/pxa168_eth.c
> index 21ddece..38f7cee 100644
> --- a/drivers/net/ethernet/marvell/pxa168_eth.c
> +++ b/drivers/net/ethernet/marvell/pxa168_eth.c
> @@ -1540,8 +1540,8 @@ static int pxa168_eth_probe(struct platform_device *pdev)
> if (err)
> goto err_free_mdio;
>
> - pxa168_init_hw(pep);
> SET_NETDEV_DEV(dev, &pdev->dev);
> + pxa168_init_hw(pep);
> err = register_netdev(dev);
> if (err)
> goto err_mdiobus;
> --
> 2.1.3
>
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-11-12 13:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 11:08 [PATCH] net: pxa168_eth: move SET_NETDEV_DEV a bit earlier Jisheng Zhang
2014-11-12 11:08 ` Jisheng Zhang
2014-11-12 13:34 ` Antoine Tenart [this message]
2014-11-12 13:34 ` Antoine Tenart
2014-11-12 20:08 ` David Miller
2014-11-12 20:08 ` David Miller
2014-11-13 1:04 ` Jisheng Zhang
2014-11-13 1:04 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141112133445.GC18559@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.