From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Tomeu Vizoso <tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Javier Martinez Canillas
<javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>,
mikko.perttunen-/1wQRMveznE@public.gmane.org,
acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Peter De Schrijver
<pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v4 04/13] of: document new emc-timings subnode in nvidia,tegra124-car
Date: Wed, 12 Nov 2014 15:18:57 +0100 [thread overview]
Message-ID: <20141112141856.GA26488@ulmo> (raw)
In-Reply-To: <1415779051-26410-5-git-send-email-tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 600 bytes --]
On Wed, Nov 12, 2014 at 08:56:27AM +0100, Tomeu Vizoso wrote:
[...]
> Example SoC include file:
>
> / {
> - tegra_car: clock {
> + tegra_car: clock@60006000 {
> compatible = "nvidia,tegra124-car";
> reg = <0x60006000 0x1000>;
> #clock-cells = <1>;
> @@ -60,4 +83,23 @@ Example board file:
> &tegra_car {
> clocks = <&clk_32k> <&osc>;
> };
> +
> + clock@60006000 {
> + emc-timings@3 {
Shouldn't this be following the same naming scheme as the memory
controller's subnodes?
> + nvidia,ram-code = <3>;
> +
> + timing@12750000 {
And this?
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: linux-tegra@vger.kernel.org,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
mikko.perttunen@kapsi.fi, acourbot@nvidia.com,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Alexandre Courbot <gnurou@gmail.com>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 04/13] of: document new emc-timings subnode in nvidia,tegra124-car
Date: Wed, 12 Nov 2014 15:18:57 +0100 [thread overview]
Message-ID: <20141112141856.GA26488@ulmo> (raw)
In-Reply-To: <1415779051-26410-5-git-send-email-tomeu.vizoso@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 600 bytes --]
On Wed, Nov 12, 2014 at 08:56:27AM +0100, Tomeu Vizoso wrote:
[...]
> Example SoC include file:
>
> / {
> - tegra_car: clock {
> + tegra_car: clock@60006000 {
> compatible = "nvidia,tegra124-car";
> reg = <0x60006000 0x1000>;
> #clock-cells = <1>;
> @@ -60,4 +83,23 @@ Example board file:
> &tegra_car {
> clocks = <&clk_32k> <&osc>;
> };
> +
> + clock@60006000 {
> + emc-timings@3 {
Shouldn't this be following the same naming scheme as the memory
controller's subnodes?
> + nvidia,ram-code = <3>;
> +
> + timing@12750000 {
And this?
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-11-12 14:18 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 7:56 [PATCH v4 00/13] Tegra124 EMC (external memory controller) support Tomeu Vizoso
2014-11-12 7:56 ` Tomeu Vizoso
2014-11-12 7:56 ` Tomeu Vizoso
2014-11-12 7:56 ` [PATCH v4 01/13] clk: tegra124: Remove old emc clock Tomeu Vizoso
2014-11-12 7:56 ` [PATCH v4 02/13] of: Document long-ram-code property in nvidia,tegra20-apbmisc Tomeu Vizoso
[not found] ` <1415779051-26410-1-git-send-email-tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2014-11-12 7:56 ` [PATCH v4 03/13] soc/tegra: Add ram code reader helper Tomeu Vizoso
2014-11-12 7:56 ` Tomeu Vizoso
2014-11-12 7:56 ` [PATCH v4 04/13] of: document new emc-timings subnode in nvidia,tegra124-car Tomeu Vizoso
2014-11-12 7:56 ` Tomeu Vizoso
[not found] ` <1415779051-26410-5-git-send-email-tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2014-11-12 14:18 ` Thierry Reding [this message]
2014-11-12 14:18 ` Thierry Reding
2014-11-13 9:36 ` Tomeu Vizoso
2014-11-13 9:36 ` Tomeu Vizoso
2014-11-12 7:56 ` [PATCH v4 13/13] clk: tegra: Set the EMC clock as the parent of the MC clock Tomeu Vizoso
2014-11-12 7:56 ` Tomeu Vizoso
2014-11-12 7:56 ` [PATCH v4 05/13] of: Document timings subnode of nvidia,tegra-mc Tomeu Vizoso
[not found] ` <1415779051-26410-6-git-send-email-tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2014-11-12 14:22 ` Thierry Reding
2014-11-12 14:22 ` Thierry Reding
2014-11-13 9:33 ` Tomeu Vizoso
2014-11-12 7:56 ` [PATCH v4 06/13] of: Add Tegra124 EMC bindings Tomeu Vizoso
2014-11-12 7:56 ` [PATCH v4 07/13] ARM: tegra: Add EMC to Tegra124 device tree Tomeu Vizoso
2014-11-12 7:56 ` Tomeu Vizoso
2014-11-12 7:56 ` Tomeu Vizoso
2014-11-12 7:56 ` [PATCH v4 08/13] ARM: tegra: Add EMC timings to Jetson TK1 " Tomeu Vizoso
2014-11-12 7:56 ` Tomeu Vizoso
2014-11-12 7:56 ` [PATCH v4 09/13] memory: tegra: Add API needed by the EMC driver Tomeu Vizoso
2014-11-12 14:44 ` Thierry Reding
2014-11-12 7:56 ` [PATCH v4 10/13] memory: tegra: Add EMC (external memory controller) driver Tomeu Vizoso
[not found] ` <1415779051-26410-11-git-send-email-tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2014-11-12 15:45 ` Thierry Reding
2014-11-12 15:45 ` Thierry Reding
2014-11-12 16:25 ` Mikko Perttunen
2014-11-12 16:25 ` Mikko Perttunen
2014-11-14 16:18 ` Tomeu Vizoso
2014-11-14 16:18 ` Tomeu Vizoso
2014-11-12 7:56 ` [PATCH v4 11/13] clk: tegra: Add EMC clock driver Tomeu Vizoso
[not found] ` <1415779051-26410-12-git-send-email-tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2014-11-12 16:18 ` Thierry Reding
2014-11-12 16:18 ` Thierry Reding
2014-11-13 10:51 ` Nikolaus Schulz
2014-11-13 10:51 ` Nikolaus Schulz
2014-11-12 7:56 ` [PATCH v4 12/13] memory: tegra: Add debugfs entry for getting and setting the EMC rate Tomeu Vizoso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141112141856.GA26488@ulmo \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=mikko.perttunen-/1wQRMveznE@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.