From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Sebastian Reichel <sre@kernel.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
Kevin Hilman <khilman@deeprootsystems.com>
Subject: Re: [PATCH] ARM: at91: move sdramc/ddrsdr header to include/soc/at91
Date: Thu, 13 Nov 2014 15:53:43 +0100 [thread overview]
Message-ID: <20141113155343.5c92c2d6@bbrezillon> (raw)
In-Reply-To: <54649221.9060307@atmel.com>
On Thu, 13 Nov 2014 12:12:33 +0100
Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
> On 07/11/2014 21:58, Alexandre Belloni :
> > Move the (DDR) SDRAM controller headers to include/soc/at91 to remove the
> > dependency on mach/ headers from the at91-reset driver.
> >
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > ---
> > As my previous attempts were not popular, solve the mach/ headers issue by
> > simply moving them. I'll get back to better driver separation when it will be
> > possible to map the SRAM as executable memory.
> >
> > MAINTAINERS | 1 +
> > arch/arm/mach-at91/include/mach/at91_ramc.h | 6 +-
> > .../arm/mach-at91/include/mach/at91rm9200_sdramc.h | 63 -----------
> > arch/arm/mach-at91/include/mach/at91sam9_ddrsdr.h | 124 ---------------------
> > arch/arm/mach-at91/include/mach/at91sam9_sdramc.h | 85 --------------
> > arch/arm/mach-at91/pm.h | 1 -
> > drivers/power/reset/at91-reset.c | 4 +-
> > include/soc/at91/at91rm9200_sdramc.h | 63 +++++++++++
> > include/soc/at91/at91sam9_ddrsdr.h | 124 +++++++++++++++++++++
> > include/soc/at91/at91sam9_sdramc.h | 85 ++++++++++++++
> > 10 files changed, 278 insertions(+), 278 deletions(-)
> > delete mode 100644 arch/arm/mach-at91/include/mach/at91rm9200_sdramc.h
> > delete mode 100644 arch/arm/mach-at91/include/mach/at91sam9_ddrsdr.h
> > delete mode 100644 arch/arm/mach-at91/include/mach/at91sam9_sdramc.h
> > create mode 100644 include/soc/at91/at91rm9200_sdramc.h
> > create mode 100644 include/soc/at91/at91sam9_ddrsdr.h
> > create mode 100644 include/soc/at91/at91sam9_sdramc.h
>
> This would have been cleaner and easier to understand with
> git format-patch -M
>
> --8<--------------------------------
> MAINTAINERS | 1 +
> arch/arm/mach-at91/include/mach/at91_ramc.h | 6 +++---
> arch/arm/mach-at91/pm.h | 1 -
> drivers/power/reset/at91-reset.c | 4 ++--
> .../mach-at91/include/mach => include/soc/at91}/at91rm9200_sdramc.h | 0
> .../mach-at91/include/mach => include/soc/at91}/at91sam9_ddrsdr.h | 0
> .../mach-at91/include/mach => include/soc/at91}/at91sam9_sdramc.h | 0
> 7 files changed, 6 insertions(+), 6 deletions(-)
> rename {arch/arm/mach-at91/include/mach => include/soc/at91}/at91rm9200_sdramc.h (100%)
> rename {arch/arm/mach-at91/include/mach => include/soc/at91}/at91sam9_ddrsdr.h (100%)
> rename {arch/arm/mach-at91/include/mach => include/soc/at91}/at91sam9_sdramc.h (100%)
> --8<--------------------------------
>
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>
> and queued for at91-3.19-cleanup
I'm getting back to this patch because I'd like understand what exactly
should be put in include/soc/<soc-name> and what should be put in the
subsystem directory (include/linux/<subsystem>) ?
Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: at91: move sdramc/ddrsdr header to include/soc/at91
Date: Thu, 13 Nov 2014 15:53:43 +0100 [thread overview]
Message-ID: <20141113155343.5c92c2d6@bbrezillon> (raw)
In-Reply-To: <54649221.9060307@atmel.com>
On Thu, 13 Nov 2014 12:12:33 +0100
Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
> On 07/11/2014 21:58, Alexandre Belloni :
> > Move the (DDR) SDRAM controller headers to include/soc/at91 to remove the
> > dependency on mach/ headers from the at91-reset driver.
> >
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > ---
> > As my previous attempts were not popular, solve the mach/ headers issue by
> > simply moving them. I'll get back to better driver separation when it will be
> > possible to map the SRAM as executable memory.
> >
> > MAINTAINERS | 1 +
> > arch/arm/mach-at91/include/mach/at91_ramc.h | 6 +-
> > .../arm/mach-at91/include/mach/at91rm9200_sdramc.h | 63 -----------
> > arch/arm/mach-at91/include/mach/at91sam9_ddrsdr.h | 124 ---------------------
> > arch/arm/mach-at91/include/mach/at91sam9_sdramc.h | 85 --------------
> > arch/arm/mach-at91/pm.h | 1 -
> > drivers/power/reset/at91-reset.c | 4 +-
> > include/soc/at91/at91rm9200_sdramc.h | 63 +++++++++++
> > include/soc/at91/at91sam9_ddrsdr.h | 124 +++++++++++++++++++++
> > include/soc/at91/at91sam9_sdramc.h | 85 ++++++++++++++
> > 10 files changed, 278 insertions(+), 278 deletions(-)
> > delete mode 100644 arch/arm/mach-at91/include/mach/at91rm9200_sdramc.h
> > delete mode 100644 arch/arm/mach-at91/include/mach/at91sam9_ddrsdr.h
> > delete mode 100644 arch/arm/mach-at91/include/mach/at91sam9_sdramc.h
> > create mode 100644 include/soc/at91/at91rm9200_sdramc.h
> > create mode 100644 include/soc/at91/at91sam9_ddrsdr.h
> > create mode 100644 include/soc/at91/at91sam9_sdramc.h
>
> This would have been cleaner and easier to understand with
> git format-patch -M
>
> --8<--------------------------------
> MAINTAINERS | 1 +
> arch/arm/mach-at91/include/mach/at91_ramc.h | 6 +++---
> arch/arm/mach-at91/pm.h | 1 -
> drivers/power/reset/at91-reset.c | 4 ++--
> .../mach-at91/include/mach => include/soc/at91}/at91rm9200_sdramc.h | 0
> .../mach-at91/include/mach => include/soc/at91}/at91sam9_ddrsdr.h | 0
> .../mach-at91/include/mach => include/soc/at91}/at91sam9_sdramc.h | 0
> 7 files changed, 6 insertions(+), 6 deletions(-)
> rename {arch/arm/mach-at91/include/mach => include/soc/at91}/at91rm9200_sdramc.h (100%)
> rename {arch/arm/mach-at91/include/mach => include/soc/at91}/at91sam9_ddrsdr.h (100%)
> rename {arch/arm/mach-at91/include/mach => include/soc/at91}/at91sam9_sdramc.h (100%)
> --8<--------------------------------
>
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>
> and queued for at91-3.19-cleanup
I'm getting back to this patch because I'd like understand what exactly
should be put in include/soc/<soc-name> and what should be put in the
subsystem directory (include/linux/<subsystem>) ?
Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
"Sebastian Reichel" <sre@kernel.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
Kevin Hilman <khilman@deeprootsystems.com>
Subject: Re: [PATCH] ARM: at91: move sdramc/ddrsdr header to include/soc/at91
Date: Thu, 13 Nov 2014 15:53:43 +0100 [thread overview]
Message-ID: <20141113155343.5c92c2d6@bbrezillon> (raw)
In-Reply-To: <54649221.9060307@atmel.com>
On Thu, 13 Nov 2014 12:12:33 +0100
Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
> On 07/11/2014 21:58, Alexandre Belloni :
> > Move the (DDR) SDRAM controller headers to include/soc/at91 to remove the
> > dependency on mach/ headers from the at91-reset driver.
> >
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > ---
> > As my previous attempts were not popular, solve the mach/ headers issue by
> > simply moving them. I'll get back to better driver separation when it will be
> > possible to map the SRAM as executable memory.
> >
> > MAINTAINERS | 1 +
> > arch/arm/mach-at91/include/mach/at91_ramc.h | 6 +-
> > .../arm/mach-at91/include/mach/at91rm9200_sdramc.h | 63 -----------
> > arch/arm/mach-at91/include/mach/at91sam9_ddrsdr.h | 124 ---------------------
> > arch/arm/mach-at91/include/mach/at91sam9_sdramc.h | 85 --------------
> > arch/arm/mach-at91/pm.h | 1 -
> > drivers/power/reset/at91-reset.c | 4 +-
> > include/soc/at91/at91rm9200_sdramc.h | 63 +++++++++++
> > include/soc/at91/at91sam9_ddrsdr.h | 124 +++++++++++++++++++++
> > include/soc/at91/at91sam9_sdramc.h | 85 ++++++++++++++
> > 10 files changed, 278 insertions(+), 278 deletions(-)
> > delete mode 100644 arch/arm/mach-at91/include/mach/at91rm9200_sdramc.h
> > delete mode 100644 arch/arm/mach-at91/include/mach/at91sam9_ddrsdr.h
> > delete mode 100644 arch/arm/mach-at91/include/mach/at91sam9_sdramc.h
> > create mode 100644 include/soc/at91/at91rm9200_sdramc.h
> > create mode 100644 include/soc/at91/at91sam9_ddrsdr.h
> > create mode 100644 include/soc/at91/at91sam9_sdramc.h
>
> This would have been cleaner and easier to understand with
> git format-patch -M
>
> --8<--------------------------------
> MAINTAINERS | 1 +
> arch/arm/mach-at91/include/mach/at91_ramc.h | 6 +++---
> arch/arm/mach-at91/pm.h | 1 -
> drivers/power/reset/at91-reset.c | 4 ++--
> .../mach-at91/include/mach => include/soc/at91}/at91rm9200_sdramc.h | 0
> .../mach-at91/include/mach => include/soc/at91}/at91sam9_ddrsdr.h | 0
> .../mach-at91/include/mach => include/soc/at91}/at91sam9_sdramc.h | 0
> 7 files changed, 6 insertions(+), 6 deletions(-)
> rename {arch/arm/mach-at91/include/mach => include/soc/at91}/at91rm9200_sdramc.h (100%)
> rename {arch/arm/mach-at91/include/mach => include/soc/at91}/at91sam9_ddrsdr.h (100%)
> rename {arch/arm/mach-at91/include/mach => include/soc/at91}/at91sam9_sdramc.h (100%)
> --8<--------------------------------
>
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>
> and queued for at91-3.19-cleanup
I'm getting back to this patch because I'd like understand what exactly
should be put in include/soc/<soc-name> and what should be put in the
subsystem directory (include/linux/<subsystem>) ?
Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-11-13 14:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 20:58 [PATCH] ARM: at91: move sdramc/ddrsdr header to include/soc/at91 Alexandre Belloni
2014-11-07 20:58 ` Alexandre Belloni
2014-11-13 11:12 ` Nicolas Ferre
2014-11-13 11:12 ` Nicolas Ferre
2014-11-13 11:12 ` Nicolas Ferre
2014-11-13 14:53 ` Boris Brezillon [this message]
2014-11-13 14:53 ` Boris Brezillon
2014-11-13 14:53 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141113155343.5c92c2d6@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=arnd@arndb.de \
--cc=dbaryshkov@gmail.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=nicolas.ferre@atmel.com \
--cc=olof@lixom.net \
--cc=plagnioj@jcrosoft.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.