From: Bjorn Helgaas <bhelgaas@google.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: linux-pci@vger.kernel.org, 'Mohit Kumar' <mohit.kumar@st.com>,
'Viresh Kumar' <viresh.kumar@linaro.org>,
'Pratyush Anand' <pratyush.anand@st.com>
Subject: Re: [PATCH] PCI: spear: Remove unnecessary OOM message
Date: Thu, 13 Nov 2014 10:56:27 -0700 [thread overview]
Message-ID: <20141113175627.GQ5064@google.com> (raw)
In-Reply-To: <002d01cffe28$ce2f5870$6a8e0950$%han@samsung.com>
On Wed, Nov 12, 2014 at 12:29:02PM +0900, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message. This patch
> fixes the following checkpatch warning.
>
> WARNING: Possible unnecessary 'out of memory' message
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied with Viresh's ack to pci/host-spear for v3.19, thanks!
> ---
> drivers/pci/host/pcie-spear13xx.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-spear13xx.c b/drivers/pci/host/pcie-spear13xx.c
> index 85f594e..4647b62 100644
> --- a/drivers/pci/host/pcie-spear13xx.c
> +++ b/drivers/pci/host/pcie-spear13xx.c
> @@ -308,10 +308,8 @@ static int __init spear13xx_pcie_probe(struct platform_device *pdev)
> int ret;
>
> spear13xx_pcie = devm_kzalloc(dev, sizeof(*spear13xx_pcie), GFP_KERNEL);
> - if (!spear13xx_pcie) {
> - dev_err(dev, "no memory for SPEAr13xx pcie\n");
> + if (!spear13xx_pcie)
> return -ENOMEM;
> - }
>
> spear13xx_pcie->phy = devm_phy_get(dev, "pcie-phy");
> if (IS_ERR(spear13xx_pcie->phy)) {
> --
> 1.7.9.5
>
>
prev parent reply other threads:[~2014-11-13 17:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 3:29 [PATCH] PCI: spear: Remove unnecessary OOM message Jingoo Han
2014-11-12 3:48 ` Viresh Kumar
2014-11-13 17:56 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141113175627.GQ5064@google.com \
--to=bhelgaas@google.com \
--cc=jg1.han@samsung.com \
--cc=linux-pci@vger.kernel.org \
--cc=mohit.kumar@st.com \
--cc=pratyush.anand@st.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.