* [PATCH] PCI: spear: Remove unnecessary OOM message
@ 2014-11-12 3:29 Jingoo Han
2014-11-12 3:48 ` Viresh Kumar
2014-11-13 17:56 ` Bjorn Helgaas
0 siblings, 2 replies; 3+ messages in thread
From: Jingoo Han @ 2014-11-12 3:29 UTC (permalink / raw)
To: 'Bjorn Helgaas'
Cc: linux-pci, 'Jingoo Han', 'Mohit Kumar',
'Viresh Kumar', 'Pratyush Anand'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message. This patch
fixes the following checkpatch warning.
WARNING: Possible unnecessary 'out of memory' message
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/pci/host/pcie-spear13xx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/pci/host/pcie-spear13xx.c b/drivers/pci/host/pcie-spear13xx.c
index 85f594e..4647b62 100644
--- a/drivers/pci/host/pcie-spear13xx.c
+++ b/drivers/pci/host/pcie-spear13xx.c
@@ -308,10 +308,8 @@ static int __init spear13xx_pcie_probe(struct platform_device *pdev)
int ret;
spear13xx_pcie = devm_kzalloc(dev, sizeof(*spear13xx_pcie), GFP_KERNEL);
- if (!spear13xx_pcie) {
- dev_err(dev, "no memory for SPEAr13xx pcie\n");
+ if (!spear13xx_pcie)
return -ENOMEM;
- }
spear13xx_pcie->phy = devm_phy_get(dev, "pcie-phy");
if (IS_ERR(spear13xx_pcie->phy)) {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] PCI: spear: Remove unnecessary OOM message
2014-11-12 3:29 [PATCH] PCI: spear: Remove unnecessary OOM message Jingoo Han
@ 2014-11-12 3:48 ` Viresh Kumar
2014-11-13 17:56 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2014-11-12 3:48 UTC (permalink / raw)
To: Jingoo Han
Cc: Bjorn Helgaas, linux-pci@vger.kernel.org, Mohit Kumar,
Pratyush Anand
On 12 November 2014 08:59, Jingoo Han <jg1.han@samsung.com> wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message. This patch
> fixes the following checkpatch warning.
>
> WARNING: Possible unnecessary 'out of memory' message
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/pci/host/pcie-spear13xx.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: spear: Remove unnecessary OOM message
2014-11-12 3:29 [PATCH] PCI: spear: Remove unnecessary OOM message Jingoo Han
2014-11-12 3:48 ` Viresh Kumar
@ 2014-11-13 17:56 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2014-11-13 17:56 UTC (permalink / raw)
To: Jingoo Han
Cc: linux-pci, 'Mohit Kumar', 'Viresh Kumar',
'Pratyush Anand'
On Wed, Nov 12, 2014 at 12:29:02PM +0900, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message. This patch
> fixes the following checkpatch warning.
>
> WARNING: Possible unnecessary 'out of memory' message
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied with Viresh's ack to pci/host-spear for v3.19, thanks!
> ---
> drivers/pci/host/pcie-spear13xx.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-spear13xx.c b/drivers/pci/host/pcie-spear13xx.c
> index 85f594e..4647b62 100644
> --- a/drivers/pci/host/pcie-spear13xx.c
> +++ b/drivers/pci/host/pcie-spear13xx.c
> @@ -308,10 +308,8 @@ static int __init spear13xx_pcie_probe(struct platform_device *pdev)
> int ret;
>
> spear13xx_pcie = devm_kzalloc(dev, sizeof(*spear13xx_pcie), GFP_KERNEL);
> - if (!spear13xx_pcie) {
> - dev_err(dev, "no memory for SPEAr13xx pcie\n");
> + if (!spear13xx_pcie)
> return -ENOMEM;
> - }
>
> spear13xx_pcie->phy = devm_phy_get(dev, "pcie-phy");
> if (IS_ERR(spear13xx_pcie->phy)) {
> --
> 1.7.9.5
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-13 17:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-12 3:29 [PATCH] PCI: spear: Remove unnecessary OOM message Jingoo Han
2014-11-12 3:48 ` Viresh Kumar
2014-11-13 17:56 ` Bjorn Helgaas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.