From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel List <xen-devel@lists.xen.org>
Subject: Re: XenServer results from the Test Day for RC2
Date: Thu, 13 Nov 2014 14:16:29 -0500 [thread overview]
Message-ID: <20141113191629.GB11727@laptop.dumpdata.com> (raw)
In-Reply-To: <5464D627.7060104@citrix.com>
On Thu, Nov 13, 2014 at 04:02:47PM +0000, Andrew Cooper wrote:
> Hi,
>
> While attempting to test Konrads new interrupt injection logic, I got
> blocked behind yet another Pygrub bug caused by c/s d1b93ea
>
> This is the first time I have looked into the issue, but a cursory
> inspection of the first hunk shows that it cannot possibly be correct as
> self._default is either an integer or string.
>
> I have a possible workaround which I am testing, but cursory review of
> the patch would have shown that it cannot work as intended.
>
> Notice that self._default is now either a string or an integer,
> defaulting to an integer, and the top level code is updated to require a
> string. As a result, any bootloader configuration which doesn't
> explicitly set a default, or still drives this logic with integers
> (ExtLinux or LiLO) will die with an AttributeError
Thank you for testing it. In case you don't get to it - and are
preempted by other stuff - please do give me a braindump (and
preliminary patch if you have one) so I can dig into it.
Thank you!
>
> ~Andrew
>
prev parent reply other threads:[~2014-11-13 19:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 16:02 XenServer results from the Test Day for RC2 Andrew Cooper
2014-11-13 19:16 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141113191629.GB11727@laptop.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.