From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Konrad Wilk <konrad.wilk@oracle.com>
Cc: Xen-devel List <xen-devel@lists.xen.org>
Subject: XenServer results from the Test Day for RC2
Date: Thu, 13 Nov 2014 16:02:47 +0000 [thread overview]
Message-ID: <5464D627.7060104@citrix.com> (raw)
Hi,
While attempting to test Konrads new interrupt injection logic, I got
blocked behind yet another Pygrub bug caused by c/s d1b93ea
This is the first time I have looked into the issue, but a cursory
inspection of the first hunk shows that it cannot possibly be correct as
self._default is either an integer or string.
I have a possible workaround which I am testing, but cursory review of
the patch would have shown that it cannot work as intended.
Notice that self._default is now either a string or an integer,
defaulting to an integer, and the top level code is updated to require a
string. As a result, any bootloader configuration which doesn't
explicitly set a default, or still drives this logic with integers
(ExtLinux or LiLO) will die with an AttributeError
~Andrew
next reply other threads:[~2014-11-13 16:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 16:02 Andrew Cooper [this message]
2014-11-13 19:16 ` XenServer results from the Test Day for RC2 Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5464D627.7060104@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.