XenServer results from the Test Day for RC2

XenServer results from the Test Day for RC2

[Andrew Cooper]

Hi,

While attempting to test Konrads new interrupt injection logic, I got
blocked behind yet another Pygrub bug caused by c/s d1b93ea

This is the first time I have looked into the issue, but a cursory
inspection of the first hunk shows that it cannot possibly be correct as
self._default is either an integer or string.

I have a possible workaround which I am testing, but cursory review of
the patch would have shown that it cannot work as intended.

Notice that self._default is now either a string or an integer,
defaulting to an integer, and the top level code is updated to require a
string.  As a result, any bootloader configuration which doesn't
explicitly set a default, or still drives this logic with integers
(ExtLinux or LiLO) will die with an AttributeError

~Andrew

Re: XenServer results from the Test Day for RC2

[Konrad Rzeszutek Wilk]

On Thu, Nov 13, 2014 at 04:02:47PM +0000, Andrew Cooper wrote:
> Hi,
> 
> While attempting to test Konrads new interrupt injection logic, I got
> blocked behind yet another Pygrub bug caused by c/s d1b93ea
> 
> This is the first time I have looked into the issue, but a cursory
> inspection of the first hunk shows that it cannot possibly be correct as
> self._default is either an integer or string.
> 
> I have a possible workaround which I am testing, but cursory review of
> the patch would have shown that it cannot work as intended.
> 
> Notice that self._default is now either a string or an integer,
> defaulting to an integer, and the top level code is updated to require a
> string.  As a result, any bootloader configuration which doesn't
> explicitly set a default, or still drives this logic with integers
> (ExtLinux or LiLO) will die with an AttributeError

Thank you for testing it. In case you don't get to it - and are 
preempted by other stuff - please do give me a braindump (and
preliminary patch if you have one) so I can dig into it.

Thank you!
> 
> ~Andrew
>