* [PATCH 0/3] miscellaneous fixes in coresight
@ 2014-11-13 8:42 ` Pankaj Dubey
0 siblings, 0 replies; 16+ messages in thread
From: Pankaj Dubey @ 2014-11-13 8:42 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel
Cc: pratikp, mathieu.poirier, gregkh, Pankaj Dubey
This patch series fixes some typo and minor issues in coresight which
I observed while going through this driver.
Pankaj Dubey (3):
coresight: fix typo in comment in coresight-priv.h
coresight: fixed comments in coresight.h
coresight-replicator: remove .owner field for driver
drivers/coresight/coresight-priv.h | 2 +-
drivers/coresight/coresight-replicator.c | 1 -
include/linux/coresight.h | 6 +++---
3 files changed, 4 insertions(+), 5 deletions(-)
--
1.7.9.5
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 1/3] coresight: fix typo in comment in coresight-priv.h
2014-11-13 8:42 ` Pankaj Dubey
@ 2014-11-13 8:42 ` Pankaj Dubey
-1 siblings, 0 replies; 16+ messages in thread
From: Pankaj Dubey @ 2014-11-13 8:42 UTC (permalink / raw)
To: linux-arm-kernel
fixes a typo %s/eveyone/everyone/ in function CS_UNLOCK.
Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
---
drivers/coresight/coresight-priv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/coresight/coresight-priv.h b/drivers/coresight/coresight-priv.h
index 8d1180c..7b3372f 100644
--- a/drivers/coresight/coresight-priv.h
+++ b/drivers/coresight/coresight-priv.h
@@ -47,7 +47,7 @@ static inline void CS_UNLOCK(void __iomem *addr)
{
do {
writel_relaxed(CORESIGHT_UNLOCK, addr + CORESIGHT_LAR);
- /* Make sure eveyone has seen this */
+ /* Make sure everyone has seen this */
mb();
} while (0);
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 1/3] coresight: fix typo in comment in coresight-priv.h
@ 2014-11-13 8:42 ` Pankaj Dubey
0 siblings, 0 replies; 16+ messages in thread
From: Pankaj Dubey @ 2014-11-13 8:42 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel
Cc: pratikp, mathieu.poirier, gregkh, Pankaj Dubey
fixes a typo %s/eveyone/everyone/ in function CS_UNLOCK.
Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
---
drivers/coresight/coresight-priv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/coresight/coresight-priv.h b/drivers/coresight/coresight-priv.h
index 8d1180c..7b3372f 100644
--- a/drivers/coresight/coresight-priv.h
+++ b/drivers/coresight/coresight-priv.h
@@ -47,7 +47,7 @@ static inline void CS_UNLOCK(void __iomem *addr)
{
do {
writel_relaxed(CORESIGHT_UNLOCK, addr + CORESIGHT_LAR);
- /* Make sure eveyone has seen this */
+ /* Make sure everyone has seen this */
mb();
} while (0);
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 2/3] coresight: fixed comments in coresight.h
2014-11-13 8:42 ` Pankaj Dubey
@ 2014-11-13 8:42 ` Pankaj Dubey
-1 siblings, 0 replies; 16+ messages in thread
From: Pankaj Dubey @ 2014-11-13 8:42 UTC (permalink / raw)
To: linux-arm-kernel
fixes following minor issues in code comments in coresight.h
- typo %s/enpoint/endpoint
- alignment of comment section for struct coresight_desc
- correction of comment for struct coresight_connection and
struct coresight_device.
Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
---
include/linux/coresight.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/coresight.h b/include/linux/coresight.h
index bdde419..5d3c543 100644
--- a/include/linux/coresight.h
+++ b/include/linux/coresight.h
@@ -87,7 +87,7 @@ struct coresight_dev_subtype {
* @cpu: the CPU a source belongs to. Only applicable for ETM/PTMs.
* @name: name of the component as shown under sysfs.
* @nr_inport: number of input ports for this component.
- * @outports: list of remote enpoint port number.
+ * @outports: list of remote endpoint port number.
* @child_names:name of all child components connected to this device.
* @child_ports:child component port number the current component is
connected to.
@@ -113,7 +113,7 @@ struct coresight_platform_data {
by @coresight_ops.
* @pdata: platform data collected from DT.
* @dev: The device entity associated to this component.
- * @groups :operations specific to this component. These will end up
+ * @groups: operations specific to this component. These will end up
in the component's sysfs sub-directory.
*/
struct coresight_desc {
@@ -127,7 +127,6 @@ struct coresight_desc {
/**
* struct coresight_connection - representation of a single connection
- * @ref_count: keeping count a port' references.
* @outport: a connection's output port number.
* @chid_name: remote component's name.
* @child_port: remote component's port number @output is connected to.
@@ -143,6 +142,7 @@ struct coresight_connection {
/**
* struct coresight_device - representation of a device as used by the framework
+ * @conns: array of coresight_connections associated to this component.
* @nr_inport: number of input port associated to this component.
* @nr_outport: number of output port associated to this component.
* @type: as defined by @coresight_dev_type.
--
1.7.9.5
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 2/3] coresight: fixed comments in coresight.h
@ 2014-11-13 8:42 ` Pankaj Dubey
0 siblings, 0 replies; 16+ messages in thread
From: Pankaj Dubey @ 2014-11-13 8:42 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel
Cc: pratikp, mathieu.poirier, gregkh, Pankaj Dubey
fixes following minor issues in code comments in coresight.h
- typo %s/enpoint/endpoint
- alignment of comment section for struct coresight_desc
- correction of comment for struct coresight_connection and
struct coresight_device.
Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
---
include/linux/coresight.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/coresight.h b/include/linux/coresight.h
index bdde419..5d3c543 100644
--- a/include/linux/coresight.h
+++ b/include/linux/coresight.h
@@ -87,7 +87,7 @@ struct coresight_dev_subtype {
* @cpu: the CPU a source belongs to. Only applicable for ETM/PTMs.
* @name: name of the component as shown under sysfs.
* @nr_inport: number of input ports for this component.
- * @outports: list of remote enpoint port number.
+ * @outports: list of remote endpoint port number.
* @child_names:name of all child components connected to this device.
* @child_ports:child component port number the current component is
connected to.
@@ -113,7 +113,7 @@ struct coresight_platform_data {
by @coresight_ops.
* @pdata: platform data collected from DT.
* @dev: The device entity associated to this component.
- * @groups :operations specific to this component. These will end up
+ * @groups: operations specific to this component. These will end up
in the component's sysfs sub-directory.
*/
struct coresight_desc {
@@ -127,7 +127,6 @@ struct coresight_desc {
/**
* struct coresight_connection - representation of a single connection
- * @ref_count: keeping count a port' references.
* @outport: a connection's output port number.
* @chid_name: remote component's name.
* @child_port: remote component's port number @output is connected to.
@@ -143,6 +142,7 @@ struct coresight_connection {
/**
* struct coresight_device - representation of a device as used by the framework
+ * @conns: array of coresight_connections associated to this component.
* @nr_inport: number of input port associated to this component.
* @nr_outport: number of output port associated to this component.
* @type: as defined by @coresight_dev_type.
--
1.7.9.5
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 3/3] coresight-replicator: remove .owner field for driver
2014-11-13 8:42 ` Pankaj Dubey
@ 2014-11-13 8:42 ` Pankaj Dubey
-1 siblings, 0 replies; 16+ messages in thread
From: Pankaj Dubey @ 2014-11-13 8:42 UTC (permalink / raw)
To: linux-arm-kernel
There is no need of .owner field for driver using
module_platform_driver.
Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
---
drivers/coresight/coresight-replicator.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/coresight/coresight-replicator.c b/drivers/coresight/coresight-replicator.c
index c879039..a2dfcf9 100644
--- a/drivers/coresight/coresight-replicator.c
+++ b/drivers/coresight/coresight-replicator.c
@@ -117,7 +117,6 @@ static struct platform_driver replicator_driver = {
.remove = replicator_remove,
.driver = {
.name = "coresight-replicator",
- .owner = THIS_MODULE,
.of_match_table = replicator_match,
},
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 3/3] coresight-replicator: remove .owner field for driver
@ 2014-11-13 8:42 ` Pankaj Dubey
0 siblings, 0 replies; 16+ messages in thread
From: Pankaj Dubey @ 2014-11-13 8:42 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel
Cc: pratikp, mathieu.poirier, gregkh, Pankaj Dubey
There is no need of .owner field for driver using
module_platform_driver.
Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
---
drivers/coresight/coresight-replicator.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/coresight/coresight-replicator.c b/drivers/coresight/coresight-replicator.c
index c879039..a2dfcf9 100644
--- a/drivers/coresight/coresight-replicator.c
+++ b/drivers/coresight/coresight-replicator.c
@@ -117,7 +117,6 @@ static struct platform_driver replicator_driver = {
.remove = replicator_remove,
.driver = {
.name = "coresight-replicator",
- .owner = THIS_MODULE,
.of_match_table = replicator_match,
},
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 0/3] miscellaneous fixes in coresight
2014-11-13 8:42 ` Pankaj Dubey
@ 2014-11-13 18:12 ` Mathieu Poirier
-1 siblings, 0 replies; 16+ messages in thread
From: Mathieu Poirier @ 2014-11-13 18:12 UTC (permalink / raw)
To: linux-arm-kernel
On 13 November 2014 01:42, Pankaj Dubey <pankaj.dubey@samsung.com> wrote:
> This patch series fixes some typo and minor issues in coresight which
> I observed while going through this driver.
>
> Pankaj Dubey (3):
> coresight: fix typo in comment in coresight-priv.h
> coresight: fixed comments in coresight.h
> coresight-replicator: remove .owner field for driver
>
> drivers/coresight/coresight-priv.h | 2 +-
> drivers/coresight/coresight-replicator.c | 1 -
> include/linux/coresight.h | 6 +++---
> 3 files changed, 4 insertions(+), 5 deletions(-)
>
> --
> 1.7.9.5
>
Applied all 3 patches - thanks
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 0/3] miscellaneous fixes in coresight
@ 2014-11-13 18:12 ` Mathieu Poirier
0 siblings, 0 replies; 16+ messages in thread
From: Mathieu Poirier @ 2014-11-13 18:12 UTC (permalink / raw)
To: Pankaj Dubey
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Pratik Patel, Greg KH
On 13 November 2014 01:42, Pankaj Dubey <pankaj.dubey@samsung.com> wrote:
> This patch series fixes some typo and minor issues in coresight which
> I observed while going through this driver.
>
> Pankaj Dubey (3):
> coresight: fix typo in comment in coresight-priv.h
> coresight: fixed comments in coresight.h
> coresight-replicator: remove .owner field for driver
>
> drivers/coresight/coresight-priv.h | 2 +-
> drivers/coresight/coresight-replicator.c | 1 -
> include/linux/coresight.h | 6 +++---
> 3 files changed, 4 insertions(+), 5 deletions(-)
>
> --
> 1.7.9.5
>
Applied all 3 patches - thanks
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 0/3] miscellaneous fixes in coresight
2014-11-13 18:12 ` Mathieu Poirier
@ 2014-11-13 19:17 ` Greg KH
-1 siblings, 0 replies; 16+ messages in thread
From: Greg KH @ 2014-11-13 19:17 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Nov 13, 2014 at 11:12:40AM -0700, Mathieu Poirier wrote:
> On 13 November 2014 01:42, Pankaj Dubey <pankaj.dubey@samsung.com> wrote:
> > This patch series fixes some typo and minor issues in coresight which
> > I observed while going through this driver.
> >
> > Pankaj Dubey (3):
> > coresight: fix typo in comment in coresight-priv.h
> > coresight: fixed comments in coresight.h
> > coresight-replicator: remove .owner field for driver
> >
> > drivers/coresight/coresight-priv.h | 2 +-
> > drivers/coresight/coresight-replicator.c | 1 -
> > include/linux/coresight.h | 6 +++---
> > 3 files changed, 4 insertions(+), 5 deletions(-)
> >
> > --
> > 1.7.9.5
> >
>
> Applied all 3 patches - thanks
Applied to what? Shouldn't I be taking these?
confused,
greg k-h
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 0/3] miscellaneous fixes in coresight
@ 2014-11-13 19:17 ` Greg KH
0 siblings, 0 replies; 16+ messages in thread
From: Greg KH @ 2014-11-13 19:17 UTC (permalink / raw)
To: Mathieu Poirier
Cc: Pankaj Dubey, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Pratik Patel
On Thu, Nov 13, 2014 at 11:12:40AM -0700, Mathieu Poirier wrote:
> On 13 November 2014 01:42, Pankaj Dubey <pankaj.dubey@samsung.com> wrote:
> > This patch series fixes some typo and minor issues in coresight which
> > I observed while going through this driver.
> >
> > Pankaj Dubey (3):
> > coresight: fix typo in comment in coresight-priv.h
> > coresight: fixed comments in coresight.h
> > coresight-replicator: remove .owner field for driver
> >
> > drivers/coresight/coresight-priv.h | 2 +-
> > drivers/coresight/coresight-replicator.c | 1 -
> > include/linux/coresight.h | 6 +++---
> > 3 files changed, 4 insertions(+), 5 deletions(-)
> >
> > --
> > 1.7.9.5
> >
>
> Applied all 3 patches - thanks
Applied to what? Shouldn't I be taking these?
confused,
greg k-h
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 0/3] miscellaneous fixes in coresight
2014-11-13 19:17 ` Greg KH
@ 2014-11-13 22:27 ` Mathieu Poirier
-1 siblings, 0 replies; 16+ messages in thread
From: Mathieu Poirier @ 2014-11-13 22:27 UTC (permalink / raw)
To: linux-arm-kernel
I took them in my tree and I'll send you a pull request.
On 13 November 2014 12:17, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Thu, Nov 13, 2014 at 11:12:40AM -0700, Mathieu Poirier wrote:
>> On 13 November 2014 01:42, Pankaj Dubey <pankaj.dubey@samsung.com> wrote:
>> > This patch series fixes some typo and minor issues in coresight which
>> > I observed while going through this driver.
>> >
>> > Pankaj Dubey (3):
>> > coresight: fix typo in comment in coresight-priv.h
>> > coresight: fixed comments in coresight.h
>> > coresight-replicator: remove .owner field for driver
>> >
>> > drivers/coresight/coresight-priv.h | 2 +-
>> > drivers/coresight/coresight-replicator.c | 1 -
>> > include/linux/coresight.h | 6 +++---
>> > 3 files changed, 4 insertions(+), 5 deletions(-)
>> >
>> > --
>> > 1.7.9.5
>> >
>>
>> Applied all 3 patches - thanks
>
> Applied to what? Shouldn't I be taking these?
>
> confused,
>
> greg k-h
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 0/3] miscellaneous fixes in coresight
@ 2014-11-13 22:27 ` Mathieu Poirier
0 siblings, 0 replies; 16+ messages in thread
From: Mathieu Poirier @ 2014-11-13 22:27 UTC (permalink / raw)
To: Greg KH
Cc: Pankaj Dubey, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Pratik Patel
I took them in my tree and I'll send you a pull request.
On 13 November 2014 12:17, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Thu, Nov 13, 2014 at 11:12:40AM -0700, Mathieu Poirier wrote:
>> On 13 November 2014 01:42, Pankaj Dubey <pankaj.dubey@samsung.com> wrote:
>> > This patch series fixes some typo and minor issues in coresight which
>> > I observed while going through this driver.
>> >
>> > Pankaj Dubey (3):
>> > coresight: fix typo in comment in coresight-priv.h
>> > coresight: fixed comments in coresight.h
>> > coresight-replicator: remove .owner field for driver
>> >
>> > drivers/coresight/coresight-priv.h | 2 +-
>> > drivers/coresight/coresight-replicator.c | 1 -
>> > include/linux/coresight.h | 6 +++---
>> > 3 files changed, 4 insertions(+), 5 deletions(-)
>> >
>> > --
>> > 1.7.9.5
>> >
>>
>> Applied all 3 patches - thanks
>
> Applied to what? Shouldn't I be taking these?
>
> confused,
>
> greg k-h
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 0/3] miscellaneous fixes in coresight
2014-11-13 22:27 ` Mathieu Poirier
@ 2014-11-13 23:32 ` Greg KH
-1 siblings, 0 replies; 16+ messages in thread
From: Greg KH @ 2014-11-13 23:32 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Nov 13, 2014 at 03:27:05PM -0700, Mathieu Poirier wrote:
> I took them in my tree and I'll send you a pull request.
For a single driver? Ick, no, please just send patches in email.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 0/3] miscellaneous fixes in coresight
@ 2014-11-13 23:32 ` Greg KH
0 siblings, 0 replies; 16+ messages in thread
From: Greg KH @ 2014-11-13 23:32 UTC (permalink / raw)
To: Mathieu Poirier
Cc: Pankaj Dubey, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Pratik Patel
On Thu, Nov 13, 2014 at 03:27:05PM -0700, Mathieu Poirier wrote:
> I took them in my tree and I'll send you a pull request.
For a single driver? Ick, no, please just send patches in email.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 16+ messages in thread