From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH v2] ASoC: Fix kerneldoc errors
Date: Fri, 14 Nov 2014 12:57:04 +0000 [thread overview]
Message-ID: <20141114125704.GA3815@sirena.org.uk> (raw)
In-Reply-To: <1415652427-827-1-git-send-email-tiwai@suse.de>
[-- Attachment #1.1: Type: text/plain, Size: 841 bytes --]
On Mon, Nov 10, 2014 at 09:47:07PM +0100, Takashi Iwai wrote:
> Lots of typos and missing parameter descriptions.
>
> Some private struct fields are moved to the end of struct and put
> markers to make kerneldoc happy (and it make even easier for human
> readers).
This would've been better split up more. I've applied it, a couple of
smaller things though:
> /**
> * snd_soc_set_ac97_ops_of_reset - Set ac97 ops with generic ac97 reset functions
> + * @ops: AC97 opts to set
> + * @pdev: platform to deal with
It's not a platform, it's a platform device.
> * snd_soc_dai_set_bclk_ratio - configure BCLK to sample rate ratio.
> * @dai: DAI
> - * @ratio Ratio of BCLK to Sample rate.
> + * @ratio: Ratio of BCLK to Sample rate.
While you're fixing fixing the capitalization of sample would've been
good.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-11-14 14:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 20:47 [PATCH v2] ASoC: Fix kerneldoc errors Takashi Iwai
2014-11-14 12:57 ` Mark Brown [this message]
2014-11-14 17:29 ` Mark Brown
2014-11-16 8:40 ` Takashi Iwai
2014-11-16 11:06 ` Mark Brown
2014-11-16 12:10 ` Takashi Iwai
2014-11-16 14:46 ` Mark Brown
2014-11-16 14:58 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141114125704.GA3815@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.