From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH v2] ASoC: Fix kerneldoc errors
Date: Sun, 16 Nov 2014 09:40:23 +0100 [thread overview]
Message-ID: <s5hbno7o7wo.wl-tiwai@suse.de> (raw)
In-Reply-To: <20141114172924.GJ3815@sirena.org.uk>
At Fri, 14 Nov 2014 17:29:24 +0000,
Mark Brown wrote:
>
> On Fri, Nov 14, 2014 at 12:57:04PM +0000, Mark Brown wrote:
> > On Mon, Nov 10, 2014 at 09:47:07PM +0100, Takashi Iwai wrote:
> > > Lots of typos and missing parameter descriptions.
> > >
> > > Some private struct fields are moved to the end of struct and put
> > > markers to make kerneldoc happy (and it make even easier for human
> > > readers).
> >
> > This would've been better split up more. I've applied it, a couple of
> > smaller things though:
>
> Actually I had to revert this, it applies cleanly against Linus' tree
> but is causing annoying merge/apply issues with my current tree.
This reminds me of something to improve; can you send a pull request
one or twice during rc, not only the last week? This would make
people, not only me, easier to work on a tree-wide task like ALSA core
API.
thanks,
Takashi
next prev parent reply other threads:[~2014-11-16 8:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 20:47 [PATCH v2] ASoC: Fix kerneldoc errors Takashi Iwai
2014-11-14 12:57 ` Mark Brown
2014-11-14 17:29 ` Mark Brown
2014-11-16 8:40 ` Takashi Iwai [this message]
2014-11-16 11:06 ` Mark Brown
2014-11-16 12:10 ` Takashi Iwai
2014-11-16 14:46 ` Mark Brown
2014-11-16 14:58 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hbno7o7wo.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.