All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Mahendran Ganesh <opensource.ganesh@gmail.com>
Cc: minchan@kernel.org, ngupta@vflare.org, ddstreet@ieee.org,
	sergey.senozhatsky@gmail.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] mm/zsmalloc: add __init/__exit to zs_init/zs_exit
Date: Fri, 14 Nov 2014 21:59:00 +0900	[thread overview]
Message-ID: <20141114125900.GA1007@swordfish> (raw)
In-Reply-To: <1415885857-5283-2-git-send-email-opensource.ganesh@gmail.com>

On (11/13/14 21:37), Mahendran Ganesh wrote:
> After patch [1], the zs_exit is only called in module exit.
> So add __init/__exit to zs_init/zs_exit.
> 
>   [1] mm/zsmalloc: avoid unregister a NOT-registered zsmalloc zpool driver
> 
> Signed-off-by: Mahendran Ganesh <opensource.ganesh@gmail.com>

makes sense.

	-ss

> ---
>  mm/zsmalloc.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index 3d2bb36..92af030 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -881,7 +881,7 @@ static struct notifier_block zs_cpu_nb = {
>  	.notifier_call = zs_cpu_notifier
>  };
>  
> -static void zs_exit(void)
> +static void __exit zs_exit(void)
>  {
>  	int cpu;
>  
> @@ -898,7 +898,7 @@ static void zs_exit(void)
>  	cpu_notifier_register_done();
>  }
>  
> -static int zs_init(void)
> +static int __init zs_init(void)
>  {
>  	int cpu, ret;
>  
> -- 
> 1.7.9.5
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Mahendran Ganesh <opensource.ganesh@gmail.com>
Cc: minchan@kernel.org, ngupta@vflare.org, ddstreet@ieee.org,
	sergey.senozhatsky@gmail.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] mm/zsmalloc: add __init/__exit to zs_init/zs_exit
Date: Fri, 14 Nov 2014 21:59:00 +0900	[thread overview]
Message-ID: <20141114125900.GA1007@swordfish> (raw)
In-Reply-To: <1415885857-5283-2-git-send-email-opensource.ganesh@gmail.com>

On (11/13/14 21:37), Mahendran Ganesh wrote:
> After patch [1], the zs_exit is only called in module exit.
> So add __init/__exit to zs_init/zs_exit.
> 
>   [1] mm/zsmalloc: avoid unregister a NOT-registered zsmalloc zpool driver
> 
> Signed-off-by: Mahendran Ganesh <opensource.ganesh@gmail.com>

makes sense.

	-ss

> ---
>  mm/zsmalloc.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index 3d2bb36..92af030 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -881,7 +881,7 @@ static struct notifier_block zs_cpu_nb = {
>  	.notifier_call = zs_cpu_notifier
>  };
>  
> -static void zs_exit(void)
> +static void __exit zs_exit(void)
>  {
>  	int cpu;
>  
> @@ -898,7 +898,7 @@ static void zs_exit(void)
>  	cpu_notifier_register_done();
>  }
>  
> -static int zs_init(void)
> +static int __init zs_init(void)
>  {
>  	int cpu, ret;
>  
> -- 
> 1.7.9.5
> 

  reply	other threads:[~2014-11-14 12:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-13 13:37 [PATCH 1/3] mm/zsmalloc: avoid unregister a NOT-registered zsmalloc zpool driver Mahendran Ganesh
2014-11-13 13:37 ` Mahendran Ganesh
2014-11-13 13:37 ` [PATCH 2/3] mm/zsmalloc: add __init/__exit to zs_init/zs_exit Mahendran Ganesh
2014-11-13 13:37   ` Mahendran Ganesh
2014-11-14 12:59   ` Sergey Senozhatsky [this message]
2014-11-14 12:59     ` Sergey Senozhatsky
2014-11-13 13:37 ` [PATCH 3/3] mm/zsmalloc: adjust zs_init/zs_exit location Mahendran Ganesh
2014-11-13 13:37   ` Mahendran Ganesh
2014-11-13 15:22 ` [PATCH 1/3] mm/zsmalloc: avoid unregister a NOT-registered zsmalloc zpool driver Sergey Senozhatsky
2014-11-13 15:22   ` Sergey Senozhatsky
2014-11-13 15:30   ` Sergey Senozhatsky
2014-11-13 15:30     ` Sergey Senozhatsky
2014-11-13 22:31     ` Sergey Senozhatsky
2014-11-13 22:31       ` Sergey Senozhatsky
2014-11-13 23:29       ` Minchan Kim
2014-11-13 23:29         ` Minchan Kim
2014-11-13 23:38   ` Ganesh Mahendran
2014-11-13 23:38     ` Ganesh Mahendran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141114125900.GA1007@swordfish \
    --to=sergey.senozhatsky@gmail.com \
    --cc=ddstreet@ieee.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=ngupta@vflare.org \
    --cc=opensource.ganesh@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.