* [PATCH] staging: lustre: socklnd: sparse warning fix
@ 2014-11-16 14:33 Igor Bogomazov
2014-11-16 17:11 ` Al Viro
0 siblings, 1 reply; 2+ messages in thread
From: Igor Bogomazov @ 2014-11-16 14:33 UTC (permalink / raw)
To: linux-kernel
Cc: HPDD-discuss, devel, Oleg Drokin, Andreas Dilger,
Greg Kroah-Hartman
sparse reports the following issue:
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib-linux.c:393:9:
error: incompatible types in comparison expression (different address
spaces)
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Igor Bogomazov <ygrex@ygrex.ru>
---
applies to linux-next
the same value casted the same way few lines below:
csum = ksocknal_csum(~0, (void *)tx->tx_iov[0].iov_base,
then it seems like a typo in LASSERT() that is got fixed
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib-linux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib-linux.c b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib-linux.c
index 245c9d7..ebd400d 100644
--- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib-linux.c
+++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib-linux.c
@@ -390,7 +390,7 @@ ksocknal_lib_csum_tx(ksock_tx_t *tx)
__u32 csum;
void *base;
- LASSERT(tx->tx_iov[0].iov_base == (void *)&tx->tx_msg);
+ LASSERT((void *)tx->tx_iov[0].iov_base == &tx->tx_msg);
LASSERT(tx->tx_conn != NULL);
LASSERT(tx->tx_conn->ksnc_proto == &ksocknal_protocol_v2x);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: lustre: socklnd: sparse warning fix
2014-11-16 14:33 [PATCH] staging: lustre: socklnd: sparse warning fix Igor Bogomazov
@ 2014-11-16 17:11 ` Al Viro
0 siblings, 0 replies; 2+ messages in thread
From: Al Viro @ 2014-11-16 17:11 UTC (permalink / raw)
To: Igor Bogomazov
Cc: linux-kernel, HPDD-discuss, devel, Oleg Drokin, Andreas Dilger,
Greg Kroah-Hartman
> the same value casted the same way few lines below:
> csum = ksocknal_csum(~0, (void *)tx->tx_iov[0].iov_base,
>
> then it seems like a typo in LASSERT() that is got fixed
>
> drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib-linux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib-linux.c b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib-linux.c
> index 245c9d7..ebd400d 100644
> --- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib-linux.c
> +++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib-linux.c
> @@ -390,7 +390,7 @@ ksocknal_lib_csum_tx(ksock_tx_t *tx)
> __u32 csum;
> void *base;
>
> - LASSERT(tx->tx_iov[0].iov_base == (void *)&tx->tx_msg);
> + LASSERT((void *)tx->tx_iov[0].iov_base == &tx->tx_msg);
Turn tx_iov into struct kvec * instead.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-16 17:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-16 14:33 [PATCH] staging: lustre: socklnd: sparse warning fix Igor Bogomazov
2014-11-16 17:11 ` Al Viro
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.