All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Valentin <edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Mikko Perttunen <mikko.perttunen-/1wQRMveznE@public.gmane.org>
Cc: Linux PM <linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Caesar Wang <caesar.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Lukasz Majewski
	<l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Alexandre Courbot
	<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Grant Likely
	<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
	Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
	Thierry Reding
	<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Zhang Rui <rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCHv2 1/1] thermal: of: improve of-thermal sensor registration API
Date: Mon, 17 Nov 2014 20:01:36 -0400	[thread overview]
Message-ID: <20141118000133.GA10027@developer> (raw)
In-Reply-To: <546A8EA9.5070001-/1wQRMveznE@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 722 bytes --]

Mikko,

On Tue, Nov 18, 2014 at 02:11:21AM +0200, Mikko Perttunen wrote:

<big cut>

> > diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c
> > index 70f7e9e..893c39c 100644
> > --- a/drivers/thermal/tegra_soctherm.c
> > +++ b/drivers/thermal/tegra_soctherm.c
> > @@ -317,6 +317,10 @@ static int tegra_thermctl_get_temp(void *data, long *out_temp)
> >   	return 0;
> >   }
> >
> > +static const struct thermal_zone_of_device_ops tegra_of_thermal_ops = {
> > +	.get_trend = tegra_thermctl_get_temp,
> > +};
> 
> This should probably read ".get_temp = tegra_thermctl_get_temp" instead 
> of .get_trend :)

Indeed. Sending in v3.

> 
> > ...
> 
> Cheers,
> Mikko
> 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Valentin <edubezval@gmail.com>
To: Mikko Perttunen <mikko.perttunen-/1wQRMveznE@public.gmane.org>
Cc: Linux PM <linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Caesar Wang <caesar.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Lukasz Majewski
	<l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Alexandre Courbot
	<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Grant Likely
	<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
	Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
	Thierry Reding
	<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Zhang Rui <rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [lm-sensors] [PATCHv2 1/1] thermal: of: improve of-thermal sensor registration API
Date: Tue, 18 Nov 2014 00:01:36 +0000	[thread overview]
Message-ID: <20141118000133.GA10027@developer> (raw)
In-Reply-To: <546A8EA9.5070001-/1wQRMveznE@public.gmane.org>


[-- Attachment #1.1: Type: text/plain, Size: 722 bytes --]

Mikko,

On Tue, Nov 18, 2014 at 02:11:21AM +0200, Mikko Perttunen wrote:

<big cut>

> > diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c
> > index 70f7e9e..893c39c 100644
> > --- a/drivers/thermal/tegra_soctherm.c
> > +++ b/drivers/thermal/tegra_soctherm.c
> > @@ -317,6 +317,10 @@ static int tegra_thermctl_get_temp(void *data, long *out_temp)
> >   	return 0;
> >   }
> >
> > +static const struct thermal_zone_of_device_ops tegra_of_thermal_ops = {
> > +	.get_trend = tegra_thermctl_get_temp,
> > +};
> 
> This should probably read ".get_temp = tegra_thermctl_get_temp" instead 
> of .get_trend :)

Indeed. Sending in v3.

> 
> > ...
> 
> Cheers,
> Mikko
> 

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Valentin <edubezval@gmail.com>
To: Mikko Perttunen <mikko.perttunen@kapsi.fi>
Cc: Linux PM <linux-pm@vger.kernel.org>,
	Caesar Wang <caesar.wang@rock-chips.com>, Wei Ni <wni@nvidia.com>,
	Lukasz Majewski <l.majewski@samsung.com>,
	Alexandre Courbot <gnurou@gmail.com>,
	devicetree@vger.kernel.org,
	Grant Likely <grant.likely@linaro.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Jean Delvare <jdelvare@suse.de>,
	linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
	lm-sensors@lm-sensors.org, Rob Herring <robh+dt@kernel.org>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Zhang Rui <rui.zhang@intel.com>
Subject: Re: [PATCHv2 1/1] thermal: of: improve of-thermal sensor registration API
Date: Mon, 17 Nov 2014 20:01:36 -0400	[thread overview]
Message-ID: <20141118000133.GA10027@developer> (raw)
In-Reply-To: <546A8EA9.5070001@kapsi.fi>

[-- Attachment #1: Type: text/plain, Size: 722 bytes --]

Mikko,

On Tue, Nov 18, 2014 at 02:11:21AM +0200, Mikko Perttunen wrote:

<big cut>

> > diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c
> > index 70f7e9e..893c39c 100644
> > --- a/drivers/thermal/tegra_soctherm.c
> > +++ b/drivers/thermal/tegra_soctherm.c
> > @@ -317,6 +317,10 @@ static int tegra_thermctl_get_temp(void *data, long *out_temp)
> >   	return 0;
> >   }
> >
> > +static const struct thermal_zone_of_device_ops tegra_of_thermal_ops = {
> > +	.get_trend = tegra_thermctl_get_temp,
> > +};
> 
> This should probably read ".get_temp = tegra_thermctl_get_temp" instead 
> of .get_trend :)

Indeed. Sending in v3.

> 
> > ...
> 
> Cheers,
> Mikko
> 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  parent reply	other threads:[~2014-11-18  0:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-17 22:36 [PATCH 0/1] of-thermal API change Eduardo Valentin
2014-11-17 22:36 ` [PATCH 1/1] thermal: of: improve of-thermal sensor registration API Eduardo Valentin
2014-11-17 22:36   ` [lm-sensors] " Eduardo Valentin
     [not found]   ` <1416263769-6578-2-git-send-email-edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-17 22:44     ` [PATCHv2 " Eduardo Valentin
2014-11-17 22:44       ` Eduardo Valentin
2014-11-17 22:44       ` [lm-sensors] " Eduardo Valentin
2014-11-18  0:05       ` [PATCH " Eduardo Valentin
2014-11-18  0:05         ` [lm-sensors] " Eduardo Valentin
2014-11-18  7:38         ` Lukasz Majewski
2014-11-18  7:38           ` [lm-sensors] " Lukasz Majewski
2014-11-18 12:50           ` Eduardo Valentin
2014-11-18 12:50             ` [lm-sensors] " Eduardo Valentin
     [not found]       ` <1416264255-10083-1-git-send-email-edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-18  0:11         ` [PATCHv2 " Mikko Perttunen
2014-11-18  0:11           ` Mikko Perttunen
2014-11-18  0:11           ` [lm-sensors] " Mikko Perttunen
     [not found]           ` <546A8EA9.5070001-/1wQRMveznE@public.gmane.org>
2014-11-18  0:01             ` Eduardo Valentin [this message]
2014-11-18  0:01               ` Eduardo Valentin
2014-11-18  0:01               ` [lm-sensors] " Eduardo Valentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141118000133.GA10027@developer \
    --to=edubezval-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=caesar.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=jdelvare-l3A5Bk7waGM@public.gmane.org \
    --cc=l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
    --cc=mikko.perttunen-/1wQRMveznE@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.