From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, Myron Stowe <myron.stowe@redhat.com>
Cc: "Kevin Hilman" <khilman@kernel.org>,
"Jason Cooper" <jason@lakedaemon.net>,
"Andrew Lunn" <andrew@lunn.ch>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Gregory Clément" <gregory.clement@free-electrons.com>,
"Ezequiel Garcia" <ezequiel.garcia@free-electrons.com>
Subject: Re: Regression caused by "PCI: Shrink decoding-disabled window while sizing BARs"
Date: Tue, 18 Nov 2014 12:34:02 +0100 [thread overview]
Message-ID: <20141118123402.7318ec94@free-electrons.com> (raw)
In-Reply-To: <20141118105843.3c1651d5@free-electrons.com>
Hello,
On Tue, 18 Nov 2014 10:58:43 +0100, Thomas Petazzoni wrote:
> Another issue (possibly related, or not), is the following compile time
> warning:
>
> /home/thomas/projets/linux-2.6/drivers/pci/probe.c: In function ‘pci_read_bridge_mmio_pref’:
> /home/thomas/projets/linux-2.6/drivers/pci/probe.c:430:5: warning: left shift count >= width of type
> base |= ((dma_addr_t) mem_base_hi) << 32;
> ^
> /home/thomas/projets/linux-2.6/drivers/pci/probe.c:431:5: warning: left shift count >= width of type
> limit |= ((dma_addr_t) mem_limit_hi) << 32;
> ^
>
> This happens because dma_addr_t is 32 bits on ARM platforms, which
> isn't properly taken into account by the commit that introduces support
> for 64 bits DMA addresses.
Not sure about this one: the commit introducing the issue is in
next-20141117, but not in the current pci/next of Bjorn. Was it
reverted? Am I looking at the wrong place?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-11-18 11:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 9:55 Regression caused by "PCI: Shrink decoding-disabled window while sizing BARs" Thomas Petazzoni
2014-11-18 9:58 ` Thomas Petazzoni
2014-11-18 11:34 ` Thomas Petazzoni [this message]
2014-11-18 14:27 ` Bjorn Helgaas
2014-11-18 14:45 ` [PATCH] PCI: fix probe.c warning on !CONFIG_ARCH_DMA_ADDR_T_64BIT platforms Thomas Petazzoni
2014-11-18 18:18 ` Regression caused by "PCI: Shrink decoding-disabled window while sizing BARs" Yinghai Lu
2014-11-18 21:00 ` Thomas Petazzoni
2014-11-18 22:36 ` Yinghai Lu
2014-11-19 21:22 ` Bjorn Helgaas
2014-11-19 23:31 ` Yinghai Lu
2014-11-18 11:31 ` [PATCH] PCI: fixup __pci_read_base() after refactoring Thomas Petazzoni
2014-11-18 16:31 ` Thierry Reding
2014-11-18 17:37 ` Kevin Hilman
2014-11-19 22:14 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141118123402.7318ec94@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=bhelgaas@google.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=khilman@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=myron.stowe@redhat.com \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.