From: konrad.wilk@oracle.com (Konrad Rzeszutek Wilk)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 13/13] swiotlb-xen: remove BUG_ON in xen_bus_to_phys
Date: Wed, 19 Nov 2014 16:06:26 -0500 [thread overview]
Message-ID: <20141119210626.GD20440@laptop.dumpdata.com> (raw)
In-Reply-To: <1415792454-23161-13-git-send-email-stefano.stabellini@eu.citrix.com>
On Wed, Nov 12, 2014 at 11:40:54AM +0000, Stefano Stabellini wrote:
> On x86 truncation cannot occur because config XEN depends on X86_64 ||
> (X86_32 && X86_PAE).
>
> On ARM truncation can occur without CONFIG_ARM_LPAE, when the dma
> operation involves foreign grants. However in that case the physical
> address returned by xen_bus_to_phys is actually invalid (there is no mfn
> to pfn tracking for foreign grants on ARM) and it is not used.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
> drivers/xen/swiotlb-xen.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
> index 498b654..153cf14 100644
> --- a/drivers/xen/swiotlb-xen.c
> +++ b/drivers/xen/swiotlb-xen.c
> @@ -96,8 +96,6 @@ static inline phys_addr_t xen_bus_to_phys(dma_addr_t baddr)
> dma_addr_t dma = (dma_addr_t)pfn << PAGE_SHIFT;
> phys_addr_t paddr = dma;
>
> - BUG_ON(paddr != dma); /* truncation has occurred, should never happen */
> -
> paddr |= baddr & ~PAGE_MASK;
>
> return paddr;
> --
> 1.7.10.4
>
WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, Ian.Campbell@citrix.com,
david.vrabel@citrix.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com
Subject: Re: [PATCH v9 13/13] swiotlb-xen: remove BUG_ON in xen_bus_to_phys
Date: Wed, 19 Nov 2014 16:06:26 -0500 [thread overview]
Message-ID: <20141119210626.GD20440@laptop.dumpdata.com> (raw)
In-Reply-To: <1415792454-23161-13-git-send-email-stefano.stabellini@eu.citrix.com>
On Wed, Nov 12, 2014 at 11:40:54AM +0000, Stefano Stabellini wrote:
> On x86 truncation cannot occur because config XEN depends on X86_64 ||
> (X86_32 && X86_PAE).
>
> On ARM truncation can occur without CONFIG_ARM_LPAE, when the dma
> operation involves foreign grants. However in that case the physical
> address returned by xen_bus_to_phys is actually invalid (there is no mfn
> to pfn tracking for foreign grants on ARM) and it is not used.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
> drivers/xen/swiotlb-xen.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
> index 498b654..153cf14 100644
> --- a/drivers/xen/swiotlb-xen.c
> +++ b/drivers/xen/swiotlb-xen.c
> @@ -96,8 +96,6 @@ static inline phys_addr_t xen_bus_to_phys(dma_addr_t baddr)
> dma_addr_t dma = (dma_addr_t)pfn << PAGE_SHIFT;
> phys_addr_t paddr = dma;
>
> - BUG_ON(paddr != dma); /* truncation has occurred, should never happen */
> -
> paddr |= baddr & ~PAGE_MASK;
>
> return paddr;
> --
> 1.7.10.4
>
next prev parent reply other threads:[~2014-11-19 21:06 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 11:39 [PATCH v9 0/13] introduce GNTTABOP_cache_flush Stefano Stabellini
2014-11-12 11:39 ` Stefano Stabellini
2014-11-12 11:39 ` Stefano Stabellini
2014-11-12 11:40 ` [PATCH v9 01/13] xen/arm: remove handling of XENFEAT_grant_map_identity Stefano Stabellini
2014-11-12 11:40 ` Stefano Stabellini
2014-11-12 11:40 ` Stefano Stabellini
2014-11-12 11:40 ` [PATCH v9 02/13] xen/arm: remove outer_*_range call Stefano Stabellini
2014-11-12 11:40 ` Stefano Stabellini
2014-11-12 11:40 ` Stefano Stabellini
2014-11-12 11:40 ` [PATCH v9 03/13] xen/arm: if(pfn_valid(pfn)) call native dma_ops Stefano Stabellini
2014-11-12 11:40 ` Stefano Stabellini
2014-11-12 11:40 ` Stefano Stabellini
2014-11-12 11:40 ` [PATCH v9 04/13] arm64: introduce is_device_dma_coherent Stefano Stabellini
2014-11-12 11:40 ` Stefano Stabellini
2014-11-12 11:40 ` Stefano Stabellini
2014-11-12 11:40 ` [PATCH v9 05/13] arm: " Stefano Stabellini
2014-11-12 11:40 ` Stefano Stabellini
2014-11-12 11:40 ` Stefano Stabellini
2014-11-14 11:59 ` Stefano Stabellini
2014-11-14 11:59 ` Stefano Stabellini
2014-11-14 11:59 ` Stefano Stabellini
2014-11-18 16:49 ` Stefano Stabellini
2014-11-18 16:49 ` Stefano Stabellini
2014-11-18 16:49 ` Stefano Stabellini
2014-11-20 0:07 ` Russell King - ARM Linux
2014-11-20 0:07 ` Russell King - ARM Linux
2014-11-20 10:39 ` Stefano Stabellini
2014-11-20 10:39 ` Stefano Stabellini
2014-11-20 10:39 ` Stefano Stabellini
2014-11-21 15:29 ` Russell King - ARM Linux
2014-11-21 15:29 ` Russell King - ARM Linux
2014-11-12 11:40 ` [PATCH v9 06/13] xen/arm: use is_device_dma_coherent Stefano Stabellini
2014-11-12 11:40 ` Stefano Stabellini
2014-11-12 11:40 ` Stefano Stabellini
2014-11-12 11:40 ` [PATCH v9 07/13] xen: add a dma_addr_t dev_addr argument to xen_dma_map_page Stefano Stabellini
2014-11-12 11:40 ` Stefano Stabellini
2014-11-12 11:40 ` Stefano Stabellini
2014-11-12 11:40 ` [PATCH v9 08/13] xen/arm: use hypercall to flush caches in map_page Stefano Stabellini
2014-11-12 11:40 ` Stefano Stabellini
2014-11-12 11:40 ` Stefano Stabellini
2014-11-12 11:40 ` [PATCH v9 09/13] xen/arm/arm64: merge xen/mm32.c into xen/mm.c Stefano Stabellini
2014-11-12 11:40 ` Stefano Stabellini
2014-11-12 11:40 ` Stefano Stabellini
2014-11-12 11:40 ` [PATCH v9 10/13] xen/arm/arm64: introduce xen_arch_need_swiotlb Stefano Stabellini
2014-11-12 11:40 ` Stefano Stabellini
2014-11-12 11:40 ` Stefano Stabellini
2014-11-21 16:31 ` Stefano Stabellini
2014-11-21 16:31 ` Stefano Stabellini
2014-11-21 16:31 ` Stefano Stabellini
2014-11-21 16:48 ` Konrad Rzeszutek Wilk
2014-11-21 16:48 ` Konrad Rzeszutek Wilk
2014-11-12 11:40 ` [PATCH v9 11/13] xen/arm: introduce GNTTABOP_cache_flush Stefano Stabellini
2014-11-12 11:40 ` Stefano Stabellini
2014-11-12 11:40 ` Stefano Stabellini
2014-11-12 11:40 ` [PATCH v9 12/13] swiotlb-xen: pass dev_addr to xen_dma_unmap_page and xen_dma_sync_single_for_cpu Stefano Stabellini
2014-11-12 11:40 ` Stefano Stabellini
2014-11-12 11:40 ` Stefano Stabellini
2014-11-19 21:07 ` Konrad Rzeszutek Wilk
2014-11-19 21:07 ` Konrad Rzeszutek Wilk
2014-11-20 10:33 ` Stefano Stabellini
2014-11-20 10:33 ` Stefano Stabellini
2014-11-20 10:33 ` Stefano Stabellini
2014-11-20 10:47 ` Stefano Stabellini
2014-11-20 10:47 ` Stefano Stabellini
2014-11-20 10:47 ` Stefano Stabellini
2014-11-20 20:30 ` Konrad Rzeszutek Wilk
2014-11-20 20:30 ` Konrad Rzeszutek Wilk
2014-11-12 11:40 ` [PATCH v9 13/13] swiotlb-xen: remove BUG_ON in xen_bus_to_phys Stefano Stabellini
2014-11-12 11:40 ` Stefano Stabellini
2014-11-12 11:40 ` Stefano Stabellini
2014-11-19 21:06 ` Konrad Rzeszutek Wilk [this message]
2014-11-19 21:06 ` Konrad Rzeszutek Wilk
2014-11-12 14:22 ` [Xen-devel] [PATCH v9 0/13] introduce GNTTABOP_cache_flush Julien Grall
2014-11-12 14:22 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141119210626.GD20440@laptop.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.