All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Stefan Beller <sbeller@google.com>
Cc: sahlberg@google.com, gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH] refs.c: add a function to append a reflog entry to a fd
Date: Wed, 19 Nov 2014 17:42:49 -0800	[thread overview]
Message-ID: <20141120014249.GE6527@google.com> (raw)
In-Reply-To: <1416444142-28042-1-git-send-email-sbeller@google.com>

Stefan Beller wrote:

> Compared to the last send of this patch[1], there was one change in the print
> function. Replaced sprintf by snprintf for security reasons.

I prefer the version that didn't change the code while we are
extracting it into a new function.  A separate patch on top can switch
it to use strbuf_addf or xstrfmt if we want that.

My two cents,
Jonathan

      parent reply	other threads:[~2014-11-20  1:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-20  0:42 [PATCH] refs.c: add a function to append a reflog entry to a fd Stefan Beller
2014-11-20  1:22 ` Junio C Hamano
2014-11-20  1:34   ` Junio C Hamano
2014-11-20  2:05     ` Stefan Beller
2014-11-20  2:36       ` Jonathan Nieder
2014-11-20 16:57         ` Junio C Hamano
2014-11-20 18:37         ` [PATCH v3] " Stefan Beller
2014-11-20 21:20           ` Jonathan Nieder
2014-11-20 21:24             ` Stefan Beller
2014-11-20 21:31               ` Jonathan Nieder
2014-11-20 21:42           ` Junio C Hamano
2014-11-20 21:58             ` Stefan Beller
2014-11-20 22:05               ` Jonathan Nieder
2014-11-20 22:11                 ` Junio C Hamano
2014-11-20 21:59             ` [PATCH v4] " Stefan Beller
2014-11-20 22:11               ` Jonathan Nieder
2014-11-20 22:29                 ` Junio C Hamano
2014-11-20  1:42 ` Jonathan Nieder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141120014249.GE6527@google.com \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sahlberg@google.com \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.