All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Stefan Beller <sbeller@google.com>,
	git@vger.kernel.org, Ronnie Sahlberg <sahlberg@google.com>
Subject: Re: [PATCH v4] refs.c: add a function to append a reflog entry to a fd
Date: Thu, 20 Nov 2014 14:29:21 -0800	[thread overview]
Message-ID: <xmqqvbm91p6m.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20141120221110.GM6527@google.com> (Jonathan Nieder's message of "Thu, 20 Nov 2014 14:11:10 -0800")

Jonathan Nieder <jrnieder@gmail.com> writes:

> Stefan Beller wrote:
>
>> Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
>> Signed-off-by: Stefan Beller <sbeller@google.com>
>> ---
> [...]
>>  refs.c | 48 ++++++++++++++++++++++++++++++------------------
>>  1 file changed, 30 insertions(+), 18 deletions(-)
>
> The --patience diff makes review of this version very simple.

I guess it depends on what the reader is focusing on, but at least
to me I found the default or histogram much easier to see what is
going on.  It could be due to my use of large -U<context> value,
too.

> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.

  reply	other threads:[~2014-11-20 22:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-20  0:42 [PATCH] refs.c: add a function to append a reflog entry to a fd Stefan Beller
2014-11-20  1:22 ` Junio C Hamano
2014-11-20  1:34   ` Junio C Hamano
2014-11-20  2:05     ` Stefan Beller
2014-11-20  2:36       ` Jonathan Nieder
2014-11-20 16:57         ` Junio C Hamano
2014-11-20 18:37         ` [PATCH v3] " Stefan Beller
2014-11-20 21:20           ` Jonathan Nieder
2014-11-20 21:24             ` Stefan Beller
2014-11-20 21:31               ` Jonathan Nieder
2014-11-20 21:42           ` Junio C Hamano
2014-11-20 21:58             ` Stefan Beller
2014-11-20 22:05               ` Jonathan Nieder
2014-11-20 22:11                 ` Junio C Hamano
2014-11-20 21:59             ` [PATCH v4] " Stefan Beller
2014-11-20 22:11               ` Jonathan Nieder
2014-11-20 22:29                 ` Junio C Hamano [this message]
2014-11-20  1:42 ` [PATCH] " Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqvbm91p6m.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=sahlberg@google.com \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.