Re: [PATCH] drm/atomic: Add missing ERR_PTR casting

From: Thierry Reding <thierry.reding@gmail.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH] drm/atomic: Add missing ERR_PTR casting
Date: Thu, 20 Nov 2014 09:58:52 +0100	[thread overview]
Message-ID: <20141120085851.GC23043@ulmo> (raw)
In-Reply-To: <1416473615-17267-1-git-send-email-daniel.vetter@ffwll.ch>


[-- Attachment #1.1: Type: text/plain, Size: 1137 bytes --]

On Thu, Nov 20, 2014 at 09:53:35AM +0100, Daniel Vetter wrote:
> This is an oversight from
> 
> commit f52b69f1ecfdd7ef6867a257620258c09e569552
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date:   Wed Nov 19 18:38:08 2014 +0100
> 
>     drm/atomic: Don't overrun the connector array when hotplugging
> 
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Rob Clark <robdclark@gmail.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  drivers/gpu/drm/drm_atomic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
> index 3624632084e2..d3b46746b611 100644
> --- a/drivers/gpu/drm/drm_atomic.c
> +++ b/drivers/gpu/drm/drm_atomic.c
> @@ -318,7 +318,7 @@ drm_atomic_get_connector_state(struct drm_atomic_state *state,
>  	 */
>  	if (index >= state->num_connector) {
>  		DRM_DEBUG_KMS("Hot-added connector would overflow state array, restarting\n");
> -		return -EAGAIN;
> +		return ERR_PTR(-EAGAIN);
>  	}
>  
>  	if (state->connector_states[index])

=)

Reviewed-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx