All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Scott Baker <bakers@canbytel.com>
Cc: git@vger.kernel.org
Subject: [PATCH 0/7] color fixes and configurable diff-highlight
Date: Thu, 20 Nov 2014 10:14:19 -0500	[thread overview]
Message-ID: <20141120151418.GA23607@peff.net> (raw)
In-Reply-To: <5463A007.4090302@canbytel.com>

On Wed, Nov 12, 2014 at 09:59:35AM -0800, Scott Baker wrote:

> It's 2014, most terminals are at least 256 colors. I'm fine if the
> defaults are 16 colors (that's safest), but it would be really cool if
> we could have an option for:
> 
> line add color
> line remove color
> word add color
> word remove color
> 
> I would then configure appropriate colors from the 256 color palette. I
> think the Github style diffs which include the lines/words that are
> changed are very readable and make dealing with diffs easier.

I thought I'd just procrastinate for an hour by doing this, but somehow
it turned into a 7-patch series.

The first few are actual fixes I noticed along the way.

Patches 4 and 5 support RGB-mode, which works on XTerm, at least (we
This is probably excessive over 256-color mode (which we already
supported), but I find the resulting color specifications significantly
easier to understand (quick, what's ANSI color 137?).

Patch 6 implements negative attributes (like "nobold"). This is probably
not all that useful for normal git color specs, but is required for
diff-highlight, which wants to leave some attributes untouched.

Patch 7 is the part you actually asked for. :)

  [1/7]: docs: describe ANSI 256-color mode
  [2/7]: config: fix parsing of "git config --get-color some.key -1"
  [3/7]: t4026: test "normal" color
  [4/7]: parse_color: refactor color storage
  [5/7]: parse_color: support 24-bit RGB values
  [6/7]: parse_color: recognize "no$foo" to clear the $foo attribute
  [7/7]: diff-highlight: allow configurable colors

-Peff

  reply	other threads:[~2014-11-20 15:14 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5462907B.1050207@canbytel.com>
2014-11-12  7:56 ` diff-highlight highlight words? Jeff King
2014-11-12 17:59   ` Scott Baker
2014-11-20 15:14     ` Jeff King [this message]
2014-11-20 15:15       ` [PATCH 1/7] docs: describe ANSI 256-color mode Jeff King
2014-11-20 15:15       ` [PATCH 2/7] config: fix parsing of "git config --get-color some.key -1" Jeff King
2014-11-20 15:16       ` [PATCH 3/7] t4026: test "normal" color Jeff King
2014-11-20 18:53         ` Junio C Hamano
2014-11-20 19:00           ` Jeff King
2014-11-20 15:17       ` [PATCH 4/7] parse_color: refactor color storage Jeff King
2014-11-20 19:37         ` Junio C Hamano
2014-12-09 20:14         ` Johannes Sixt
2014-12-09 20:21           ` Jeff King
2014-12-09 20:52             ` Johannes Sixt
2014-12-09 21:01               ` Jeff King
2014-12-09 20:56           ` Eric Sunshine
2014-11-20 15:25       ` [PATCH 5/7] parse_color: support 24-bit RGB values Jeff King
2014-11-20 19:44         ` Junio C Hamano
2014-11-20 20:10           ` Jeff King
2014-11-20 20:25             ` Junio C Hamano
2014-11-20 15:25       ` [PATCH 6/7] parse_color: recognize "no$foo" to clear the $foo attribute Jeff King
2014-11-20 19:46         ` Junio C Hamano
2014-11-20 15:29       ` [PATCH 7/7] diff-highlight: allow configurable colors Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141120151418.GA23607@peff.net \
    --to=peff@peff.net \
    --cc=bakers@canbytel.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.