From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Scott Baker <bakers@canbytel.com>, git@vger.kernel.org
Subject: Re: [PATCH 3/7] t4026: test "normal" color
Date: Thu, 20 Nov 2014 14:00:48 -0500 [thread overview]
Message-ID: <20141120190048.GA3741@peff.net> (raw)
In-Reply-To: <xmqqwq6p3dq3.fsf@gitster.dls.corp.google.com>
On Thu, Nov 20, 2014 at 10:53:56AM -0800, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > If the user specifiers "normal" for a foreground color, this
Argh, s/specifiers/specifies/
> > We also check that color "-1" does the same thing. This is
> > not documented, but has worked forever, so let's make sure
> > we keep supporting it.
>
> YLNTED, really? I do not object to the conclusion, but I am
> mildly surprised ;-)
I was surprised by it, too, when writing the refactoring patch that
comes next in the series. :)
I was also surprised that we further check that "-2" is _not_ valid in
the tests. I do not mind declaring everything negative to be the same
(either invalid, or "normal"), but I decided that there was really no
benefit to breaking compatibility in this case. And I suppose if you are
using 256-color mode, then "-1 255" is perhaps a natural way to write
it.
-Peff
next prev parent reply other threads:[~2014-11-20 19:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5462907B.1050207@canbytel.com>
2014-11-12 7:56 ` diff-highlight highlight words? Jeff King
2014-11-12 17:59 ` Scott Baker
2014-11-20 15:14 ` [PATCH 0/7] color fixes and configurable diff-highlight Jeff King
2014-11-20 15:15 ` [PATCH 1/7] docs: describe ANSI 256-color mode Jeff King
2014-11-20 15:15 ` [PATCH 2/7] config: fix parsing of "git config --get-color some.key -1" Jeff King
2014-11-20 15:16 ` [PATCH 3/7] t4026: test "normal" color Jeff King
2014-11-20 18:53 ` Junio C Hamano
2014-11-20 19:00 ` Jeff King [this message]
2014-11-20 15:17 ` [PATCH 4/7] parse_color: refactor color storage Jeff King
2014-11-20 19:37 ` Junio C Hamano
2014-12-09 20:14 ` Johannes Sixt
2014-12-09 20:21 ` Jeff King
2014-12-09 20:52 ` Johannes Sixt
2014-12-09 21:01 ` Jeff King
2014-12-09 20:56 ` Eric Sunshine
2014-11-20 15:25 ` [PATCH 5/7] parse_color: support 24-bit RGB values Jeff King
2014-11-20 19:44 ` Junio C Hamano
2014-11-20 20:10 ` Jeff King
2014-11-20 20:25 ` Junio C Hamano
2014-11-20 15:25 ` [PATCH 6/7] parse_color: recognize "no$foo" to clear the $foo attribute Jeff King
2014-11-20 19:46 ` Junio C Hamano
2014-11-20 15:29 ` [PATCH 7/7] diff-highlight: allow configurable colors Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141120190048.GA3741@peff.net \
--to=peff@peff.net \
--cc=bakers@canbytel.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.