* Re: [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"
@ 2014-11-21 10:59 ` Johan Hovold
0 siblings, 0 replies; 33+ messages in thread
From: Johan Hovold @ 2014-11-21 10:59 UTC (permalink / raw)
To: Auto Configured, Lee Jones, Mark Brown
Cc: heiko, grant.likely, robh, devicetree, lgirdwood, broonie, johan,
mark.rutland, linux-pm, linux-kernel, linux-arm-kernel, balbi
On Thu, Nov 13, 2014 at 01:34:58PM +0000, Auto Configured wrote:
> From: Romain Perier <romain.perier@gmail.com>
>
> It reverts commit a4b4e0461ec5 ("of: Add standard property for poweroff capability").
> As discussed on the mailing list, it makes more sense to rename back to the
> old established property name, without the vendor prefix. Problem being that
> the word "source" usually tends to be used for inputs and that is out of control
> of the OS. The poweroff capability is an output which simply turns the
> system-power off. Also, this property might be used by drivers which power-off
> the system and power back on subsequent RTC alarms. This seems to suggest to
> remove "poweroff" from the property name and to choose "system-power-controller"
> as the more generic name. This patchs adds the required renaming changes and
> defines an helper function which is compatible with both properties, the old one
> which was only used by tps65910 and the new one without vendor-prefix.
Now this is a bit of a mess.
There's a commit in the mfd tree, 25f833c1171d ("mfd: tps65910: Convert
ti,system-power-controller DT property to poweroff-source"), which
breaks all dts using tps65910 since these are never updated to the now
retracted property name ("poweroff-source").
This one should simply be reverted ASAP.
> Signed-off-by: Romain Perier <romain.perier@gmail.com>
> ---
> .../bindings/power/{poweroff.txt => power-controller.txt} | 0
> .../devicetree/bindings/regulator/act8865-regulator.txt | 4 ++--
> drivers/mfd/tps65910.c | 9 ++++++++-
> drivers/regulator/act8865-regulator.c | 2 +-
> include/linux/of.h | 6 +++---
> 5 files changed, 14 insertions(+), 7 deletions(-)
Romain, what tree is this patch against? The changes to the tps65910
driver appears not to even be in the regulator tree, yet you asked Mark
to merge this. And the MFD maintainer is not even on CC.
Let's fix the breakage by reverting the offending commit in mfd. Then the
new standard name can be introduced in regulator alone (e.g. this patch
without the tps65910 bits) as nothing outside of regulator should be
using the new power-off feature (or binding) for act8865. Then other
drivers and dts can be converted to use the new property name (while
retaining backwards compatibility) for 3.20.
[ We should probably also consider adding an "of_device_is_" prefix to
the helper name for consistency. ]
Johan
^ permalink raw reply [flat|nested] 33+ messages in thread* [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"
@ 2014-11-21 10:59 ` Johan Hovold
0 siblings, 0 replies; 33+ messages in thread
From: Johan Hovold @ 2014-11-21 10:59 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Nov 13, 2014 at 01:34:58PM +0000, Auto Configured wrote:
> From: Romain Perier <romain.perier@gmail.com>
>
> It reverts commit a4b4e0461ec5 ("of: Add standard property for poweroff capability").
> As discussed on the mailing list, it makes more sense to rename back to the
> old established property name, without the vendor prefix. Problem being that
> the word "source" usually tends to be used for inputs and that is out of control
> of the OS. The poweroff capability is an output which simply turns the
> system-power off. Also, this property might be used by drivers which power-off
> the system and power back on subsequent RTC alarms. This seems to suggest to
> remove "poweroff" from the property name and to choose "system-power-controller"
> as the more generic name. This patchs adds the required renaming changes and
> defines an helper function which is compatible with both properties, the old one
> which was only used by tps65910 and the new one without vendor-prefix.
Now this is a bit of a mess.
There's a commit in the mfd tree, 25f833c1171d ("mfd: tps65910: Convert
ti,system-power-controller DT property to poweroff-source"), which
breaks all dts using tps65910 since these are never updated to the now
retracted property name ("poweroff-source").
This one should simply be reverted ASAP.
> Signed-off-by: Romain Perier <romain.perier@gmail.com>
> ---
> .../bindings/power/{poweroff.txt => power-controller.txt} | 0
> .../devicetree/bindings/regulator/act8865-regulator.txt | 4 ++--
> drivers/mfd/tps65910.c | 9 ++++++++-
> drivers/regulator/act8865-regulator.c | 2 +-
> include/linux/of.h | 6 +++---
> 5 files changed, 14 insertions(+), 7 deletions(-)
Romain, what tree is this patch against? The changes to the tps65910
driver appears not to even be in the regulator tree, yet you asked Mark
to merge this. And the MFD maintainer is not even on CC.
Let's fix the breakage by reverting the offending commit in mfd. Then the
new standard name can be introduced in regulator alone (e.g. this patch
without the tps65910 bits) as nothing outside of regulator should be
using the new power-off feature (or binding) for act8865. Then other
drivers and dts can be converted to use the new property name (while
retaining backwards compatibility) for 3.20.
[ We should probably also consider adding an "of_device_is_" prefix to
the helper name for consistency. ]
Johan
^ permalink raw reply [flat|nested] 33+ messages in thread* [PATCH] Revert "mfd: tps65910: Convert ti,system-power-controller DT property to poweroff-source"
2014-11-21 10:59 ` Johan Hovold
@ 2014-11-21 11:00 ` Johan Hovold
-1 siblings, 0 replies; 33+ messages in thread
From: Johan Hovold @ 2014-11-21 11:00 UTC (permalink / raw)
To: Lee Jones
Cc: Samuel Ortiz, heiko, grant.likely, robh, devicetree, lgirdwood,
broonie, mark.rutland, linux-pm, linux-kernel, linux-arm-kernel,
balbi, Romain Perier, Johan Hovold
This reverts commit 25f833c1171d ("mfd: tps65910: Convert
ti,system-power-controller DT property to poweroff-source"), which
switched to a new device-tree property name for configuring the device
as a power-off controller, but failed to update the affected device-tree
sources and neither provided backward compatibility with the old
property name.
This fixes broken power-off functionality for all boards relying on
tps65910 to power off the system.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/mfd/tps65910.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
index b8dca8a0db41..7612d89850dd 100644
--- a/drivers/mfd/tps65910.c
+++ b/drivers/mfd/tps65910.c
@@ -423,7 +423,8 @@ static struct tps65910_board *tps65910_parse_dt(struct i2c_client *client,
board_info->irq = client->irq;
board_info->irq_base = -1;
- board_info->pm_off = of_system_has_poweroff_source(np);
+ board_info->pm_off = of_property_read_bool(np,
+ "ti,system-power-controller");
return board_info;
}
--
2.0.4
^ permalink raw reply related [flat|nested] 33+ messages in thread* [PATCH] Revert "mfd: tps65910: Convert ti, system-power-controller DT property to poweroff-source"
@ 2014-11-21 11:00 ` Johan Hovold
0 siblings, 0 replies; 33+ messages in thread
From: Johan Hovold @ 2014-11-21 11:00 UTC (permalink / raw)
To: linux-arm-kernel
This reverts commit 25f833c1171d ("mfd: tps65910: Convert
ti,system-power-controller DT property to poweroff-source"), which
switched to a new device-tree property name for configuring the device
as a power-off controller, but failed to update the affected device-tree
sources and neither provided backward compatibility with the old
property name.
This fixes broken power-off functionality for all boards relying on
tps65910 to power off the system.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/mfd/tps65910.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
index b8dca8a0db41..7612d89850dd 100644
--- a/drivers/mfd/tps65910.c
+++ b/drivers/mfd/tps65910.c
@@ -423,7 +423,8 @@ static struct tps65910_board *tps65910_parse_dt(struct i2c_client *client,
board_info->irq = client->irq;
board_info->irq_base = -1;
- board_info->pm_off = of_system_has_poweroff_source(np);
+ board_info->pm_off = of_property_read_bool(np,
+ "ti,system-power-controller");
return board_info;
}
--
2.0.4
^ permalink raw reply related [flat|nested] 33+ messages in thread
* Re: [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"
2014-11-21 10:59 ` Johan Hovold
@ 2014-11-21 13:18 ` Romain Perier
-1 siblings, 0 replies; 33+ messages in thread
From: Romain Perier @ 2014-11-21 13:18 UTC (permalink / raw)
To: Johan Hovold
Cc: Lee Jones, Mark Brown, Heiko Stübner, Grant Likely, robh,
devicetree, Liam Girdwood, Mark Rutland, linux-pm@vger.kernel.org,
Linux Kernel Mailing List, linux-arm-kernel@lists.infradead.org,
Felipe Balbi
2014-11-21 11:59 GMT+01:00 Johan Hovold <johan@kernel.org>:
> On Thu, Nov 13, 2014 at 01:34:58PM +0000, Auto Configured wrote:
>> From: Romain Perier <romain.perier@gmail.com>
>>
>> It reverts commit a4b4e0461ec5 ("of: Add standard property for poweroff capability").
>> As discussed on the mailing list, it makes more sense to rename back to the
>> old established property name, without the vendor prefix. Problem being that
>> the word "source" usually tends to be used for inputs and that is out of control
>> of the OS. The poweroff capability is an output which simply turns the
>> system-power off. Also, this property might be used by drivers which power-off
>> the system and power back on subsequent RTC alarms. This seems to suggest to
>> remove "poweroff" from the property name and to choose "system-power-controller"
>> as the more generic name. This patchs adds the required renaming changes and
>> defines an helper function which is compatible with both properties, the old one
>> which was only used by tps65910 and the new one without vendor-prefix.
>
> Now this is a bit of a mess.
>
> There's a commit in the mfd tree, 25f833c1171d ("mfd: tps65910: Convert
> ti,system-power-controller DT property to poweroff-source"), which
> breaks all dts using tps65910 since these are never updated to the now
> retracted property name ("poweroff-source").
No seriously ? yes, this is why I ask for feedbacks since 3 weeks... ^^
>
> This one should simply be reverted ASAP.
>
>> Signed-off-by: Romain Perier <romain.perier@gmail.com>
>> ---
>> .../bindings/power/{poweroff.txt => power-controller.txt} | 0
>> .../devicetree/bindings/regulator/act8865-regulator.txt | 4 ++--
>> drivers/mfd/tps65910.c | 9 ++++++++-
>> drivers/regulator/act8865-regulator.c | 2 +-
>> include/linux/of.h | 6 +++---
>> 5 files changed, 14 insertions(+), 7 deletions(-)
>
> Romain, what tree is this patch against? The changes to the tps65910
> driver appears not to even be in the regulator tree, yet you asked Mark
> to merge this. And the MFD maintainer is not even on CC.
I work with linux-next, this patch is present in that tree. If I
remember correctly, it was merged by Lee Jones (so it was merged onto
the mfd tree)
>
> Let's fix the breakage by reverting the offending commit in mfd. Then the
> new standard name can be introduced in regulator alone (e.g. this patch
> without the tps65910 bits) as nothing outside of regulator should be
> using the new power-off feature (or binding) for act8865. Then other
> drivers and dts can be converted to use the new property name (while
> retaining backwards compatibility) for 3.20.
>
> [ We should probably also consider adding an "of_device_is_" prefix to
> the helper name for consistency. ]
>
> Johan
Maintainers, Mark, Grant, Lee, what do you think ?
Thanks,
Romain
^ permalink raw reply [flat|nested] 33+ messages in thread* [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"
@ 2014-11-21 13:18 ` Romain Perier
0 siblings, 0 replies; 33+ messages in thread
From: Romain Perier @ 2014-11-21 13:18 UTC (permalink / raw)
To: linux-arm-kernel
2014-11-21 11:59 GMT+01:00 Johan Hovold <johan@kernel.org>:
> On Thu, Nov 13, 2014 at 01:34:58PM +0000, Auto Configured wrote:
>> From: Romain Perier <romain.perier@gmail.com>
>>
>> It reverts commit a4b4e0461ec5 ("of: Add standard property for poweroff capability").
>> As discussed on the mailing list, it makes more sense to rename back to the
>> old established property name, without the vendor prefix. Problem being that
>> the word "source" usually tends to be used for inputs and that is out of control
>> of the OS. The poweroff capability is an output which simply turns the
>> system-power off. Also, this property might be used by drivers which power-off
>> the system and power back on subsequent RTC alarms. This seems to suggest to
>> remove "poweroff" from the property name and to choose "system-power-controller"
>> as the more generic name. This patchs adds the required renaming changes and
>> defines an helper function which is compatible with both properties, the old one
>> which was only used by tps65910 and the new one without vendor-prefix.
>
> Now this is a bit of a mess.
>
> There's a commit in the mfd tree, 25f833c1171d ("mfd: tps65910: Convert
> ti,system-power-controller DT property to poweroff-source"), which
> breaks all dts using tps65910 since these are never updated to the now
> retracted property name ("poweroff-source").
No seriously ? yes, this is why I ask for feedbacks since 3 weeks... ^^
>
> This one should simply be reverted ASAP.
>
>> Signed-off-by: Romain Perier <romain.perier@gmail.com>
>> ---
>> .../bindings/power/{poweroff.txt => power-controller.txt} | 0
>> .../devicetree/bindings/regulator/act8865-regulator.txt | 4 ++--
>> drivers/mfd/tps65910.c | 9 ++++++++-
>> drivers/regulator/act8865-regulator.c | 2 +-
>> include/linux/of.h | 6 +++---
>> 5 files changed, 14 insertions(+), 7 deletions(-)
>
> Romain, what tree is this patch against? The changes to the tps65910
> driver appears not to even be in the regulator tree, yet you asked Mark
> to merge this. And the MFD maintainer is not even on CC.
I work with linux-next, this patch is present in that tree. If I
remember correctly, it was merged by Lee Jones (so it was merged onto
the mfd tree)
>
> Let's fix the breakage by reverting the offending commit in mfd. Then the
> new standard name can be introduced in regulator alone (e.g. this patch
> without the tps65910 bits) as nothing outside of regulator should be
> using the new power-off feature (or binding) for act8865. Then other
> drivers and dts can be converted to use the new property name (while
> retaining backwards compatibility) for 3.20.
>
> [ We should probably also consider adding an "of_device_is_" prefix to
> the helper name for consistency. ]
>
> Johan
Maintainers, Mark, Grant, Lee, what do you think ?
Thanks,
Romain
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"
2014-11-21 13:18 ` Romain Perier
@ 2014-11-21 13:22 ` Romain Perier
-1 siblings, 0 replies; 33+ messages in thread
From: Romain Perier @ 2014-11-21 13:22 UTC (permalink / raw)
To: Johan Hovold
Cc: Lee Jones, Mark Brown, Heiko Stübner, Grant Likely, robh,
devicetree, Liam Girdwood, Mark Rutland, linux-pm@vger.kernel.org,
Linux Kernel Mailing List, linux-arm-kernel@lists.infradead.org,
Felipe Balbi
2014-11-21 14:18 GMT+01:00 Romain Perier <romain.perier@gmail.com>:
> it was merged by Lee Jones (so it was merged onto
> the mfd tree)
It was done, for a previous serie, not this one . This is when I
proposed to update the dts too (for all boards using the custom
property) until the discussion turned into a troll.
Romain
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"
@ 2014-11-21 13:22 ` Romain Perier
0 siblings, 0 replies; 33+ messages in thread
From: Romain Perier @ 2014-11-21 13:22 UTC (permalink / raw)
To: linux-arm-kernel
2014-11-21 14:18 GMT+01:00 Romain Perier <romain.perier@gmail.com>:
> it was merged by Lee Jones (so it was merged onto
> the mfd tree)
It was done, for a previous serie, not this one . This is when I
proposed to update the dts too (for all boards using the custom
property) until the discussion turned into a troll.
Romain
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"
2014-11-21 10:59 ` Johan Hovold
@ 2014-11-24 10:24 ` Lee Jones
-1 siblings, 0 replies; 33+ messages in thread
From: Lee Jones @ 2014-11-24 10:24 UTC (permalink / raw)
To: Johan Hovold
Cc: Auto Configured, Mark Brown, heiko, grant.likely, robh,
devicetree, lgirdwood, mark.rutland, linux-pm, linux-kernel,
linux-arm-kernel, balbi
On Fri, 21 Nov 2014, Johan Hovold wrote:
> On Thu, Nov 13, 2014 at 01:34:58PM +0000, Auto Configured wrote:
> > From: Romain Perier <romain.perier@gmail.com>
> >
> > It reverts commit a4b4e0461ec5 ("of: Add standard property for poweroff capability").
> > As discussed on the mailing list, it makes more sense to rename back to the
> > old established property name, without the vendor prefix. Problem being that
> > the word "source" usually tends to be used for inputs and that is out of control
> > of the OS. The poweroff capability is an output which simply turns the
> > system-power off. Also, this property might be used by drivers which power-off
> > the system and power back on subsequent RTC alarms. This seems to suggest to
> > remove "poweroff" from the property name and to choose "system-power-controller"
> > as the more generic name. This patchs adds the required renaming changes and
> > defines an helper function which is compatible with both properties, the old one
> > which was only used by tps65910 and the new one without vendor-prefix.
>
> Now this is a bit of a mess.
>
> There's a commit in the mfd tree, 25f833c1171d ("mfd: tps65910: Convert
> ti,system-power-controller DT property to poweroff-source"), which
> breaks all dts using tps65910 since these are never updated to the now
> retracted property name ("poweroff-source").
My word!
Romain, what conversation on the MLs are you talking about?
> This one should simply be reverted ASAP.
No need to revert, I can just remove the patch from the MFD tree.
> > Signed-off-by: Romain Perier <romain.perier@gmail.com>
> > ---
> > .../bindings/power/{poweroff.txt => power-controller.txt} | 0
> > .../devicetree/bindings/regulator/act8865-regulator.txt | 4 ++--
> > drivers/mfd/tps65910.c | 9 ++++++++-
> > drivers/regulator/act8865-regulator.c | 2 +-
> > include/linux/of.h | 6 +++---
> > 5 files changed, 14 insertions(+), 7 deletions(-)
>
> Romain, what tree is this patch against? The changes to the tps65910
> driver appears not to even be in the regulator tree, yet you asked Mark
> to merge this. And the MFD maintainer is not even on CC.
>
> Let's fix the breakage by reverting the offending commit in mfd. Then the
> new standard name can be introduced in regulator alone (e.g. this patch
> without the tps65910 bits) as nothing outside of regulator should be
> using the new power-off feature (or binding) for act8865. Then other
> drivers and dts can be converted to use the new property name (while
> retaining backwards compatibility) for 3.20.
>
> [ We should probably also consider adding an "of_device_is_" prefix to
> the helper name for consistency. ]
>
> Johan
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 33+ messages in thread* [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"
@ 2014-11-24 10:24 ` Lee Jones
0 siblings, 0 replies; 33+ messages in thread
From: Lee Jones @ 2014-11-24 10:24 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, 21 Nov 2014, Johan Hovold wrote:
> On Thu, Nov 13, 2014 at 01:34:58PM +0000, Auto Configured wrote:
> > From: Romain Perier <romain.perier@gmail.com>
> >
> > It reverts commit a4b4e0461ec5 ("of: Add standard property for poweroff capability").
> > As discussed on the mailing list, it makes more sense to rename back to the
> > old established property name, without the vendor prefix. Problem being that
> > the word "source" usually tends to be used for inputs and that is out of control
> > of the OS. The poweroff capability is an output which simply turns the
> > system-power off. Also, this property might be used by drivers which power-off
> > the system and power back on subsequent RTC alarms. This seems to suggest to
> > remove "poweroff" from the property name and to choose "system-power-controller"
> > as the more generic name. This patchs adds the required renaming changes and
> > defines an helper function which is compatible with both properties, the old one
> > which was only used by tps65910 and the new one without vendor-prefix.
>
> Now this is a bit of a mess.
>
> There's a commit in the mfd tree, 25f833c1171d ("mfd: tps65910: Convert
> ti,system-power-controller DT property to poweroff-source"), which
> breaks all dts using tps65910 since these are never updated to the now
> retracted property name ("poweroff-source").
My word!
Romain, what conversation on the MLs are you talking about?
> This one should simply be reverted ASAP.
No need to revert, I can just remove the patch from the MFD tree.
> > Signed-off-by: Romain Perier <romain.perier@gmail.com>
> > ---
> > .../bindings/power/{poweroff.txt => power-controller.txt} | 0
> > .../devicetree/bindings/regulator/act8865-regulator.txt | 4 ++--
> > drivers/mfd/tps65910.c | 9 ++++++++-
> > drivers/regulator/act8865-regulator.c | 2 +-
> > include/linux/of.h | 6 +++---
> > 5 files changed, 14 insertions(+), 7 deletions(-)
>
> Romain, what tree is this patch against? The changes to the tps65910
> driver appears not to even be in the regulator tree, yet you asked Mark
> to merge this. And the MFD maintainer is not even on CC.
>
> Let's fix the breakage by reverting the offending commit in mfd. Then the
> new standard name can be introduced in regulator alone (e.g. this patch
> without the tps65910 bits) as nothing outside of regulator should be
> using the new power-off feature (or binding) for act8865. Then other
> drivers and dts can be converted to use the new property name (while
> retaining backwards compatibility) for 3.20.
>
> [ We should probably also consider adding an "of_device_is_" prefix to
> the helper name for consistency. ]
>
> Johan
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"
2014-11-24 10:24 ` Lee Jones
@ 2014-11-24 11:35 ` Johan Hovold
-1 siblings, 0 replies; 33+ messages in thread
From: Johan Hovold @ 2014-11-24 11:35 UTC (permalink / raw)
To: Lee Jones
Cc: Johan Hovold, Auto Configured, Mark Brown, heiko, grant.likely,
robh, devicetree, lgirdwood, mark.rutland, linux-pm, linux-kernel,
linux-arm-kernel, balbi
On Mon, Nov 24, 2014 at 10:24:56AM +0000, Lee Jones wrote:
> On Fri, 21 Nov 2014, Johan Hovold wrote:
> > On Thu, Nov 13, 2014 at 01:34:58PM +0000, Auto Configured wrote:
> > > From: Romain Perier <romain.perier@gmail.com>
> > >
> > > It reverts commit a4b4e0461ec5 ("of: Add standard property for poweroff capability").
> > > As discussed on the mailing list, it makes more sense to rename back to the
> > > old established property name, without the vendor prefix. Problem being that
> > > the word "source" usually tends to be used for inputs and that is out of control
> > > of the OS. The poweroff capability is an output which simply turns the
> > > system-power off. Also, this property might be used by drivers which power-off
> > > the system and power back on subsequent RTC alarms. This seems to suggest to
> > > remove "poweroff" from the property name and to choose "system-power-controller"
> > > as the more generic name. This patchs adds the required renaming changes and
> > > defines an helper function which is compatible with both properties, the old one
> > > which was only used by tps65910 and the new one without vendor-prefix.
> >
> > Now this is a bit of a mess.
> >
> > There's a commit in the mfd tree, 25f833c1171d ("mfd: tps65910: Convert
> > ti,system-power-controller DT property to poweroff-source"), which
> > breaks all dts using tps65910 since these are never updated to the now
> > retracted property name ("poweroff-source").
>
> My word!
>
> Romain, what conversation on the MLs are you talking about?
I think Romain is referring to this thread:
https://lkml.org/lkml/2014/10/23/161
> > This one should simply be reverted ASAP.
>
> No need to revert, I can just remove the patch from the MFD tree.
Ok, good. Then this is limited to the regulator tree, and we could
proceed as I outlined below.
> > > Signed-off-by: Romain Perier <romain.perier@gmail.com>
> > > ---
> > > .../bindings/power/{poweroff.txt => power-controller.txt} | 0
> > > .../devicetree/bindings/regulator/act8865-regulator.txt | 4 ++--
> > > drivers/mfd/tps65910.c | 9 ++++++++-
> > > drivers/regulator/act8865-regulator.c | 2 +-
> > > include/linux/of.h | 6 +++---
> > > 5 files changed, 14 insertions(+), 7 deletions(-)
> >
> > Romain, what tree is this patch against? The changes to the tps65910
> > driver appears not to even be in the regulator tree, yet you asked Mark
> > to merge this. And the MFD maintainer is not even on CC.
> >
> > Let's fix the breakage by reverting the offending commit in mfd. Then the
> > new standard name can be introduced in regulator alone (e.g. this patch
> > without the tps65910 bits) as nothing outside of regulator should be
> > using the new power-off feature (or binding) for act8865. Then other
> > drivers and dts can be converted to use the new property name (while
> > retaining backwards compatibility) for 3.20.
> >
> > [ We should probably also consider adding an "of_device_is_" prefix to
> > the helper name for consistency. ]
Romain, care to resend this patch without the tps65910 chunks?
You should also fix the commit message, which claims to define a "helper
function which is compatible with both properties", something which was
no longer the case.
Thanks,
Johan
^ permalink raw reply [flat|nested] 33+ messages in thread* [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"
@ 2014-11-24 11:35 ` Johan Hovold
0 siblings, 0 replies; 33+ messages in thread
From: Johan Hovold @ 2014-11-24 11:35 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Nov 24, 2014 at 10:24:56AM +0000, Lee Jones wrote:
> On Fri, 21 Nov 2014, Johan Hovold wrote:
> > On Thu, Nov 13, 2014 at 01:34:58PM +0000, Auto Configured wrote:
> > > From: Romain Perier <romain.perier@gmail.com>
> > >
> > > It reverts commit a4b4e0461ec5 ("of: Add standard property for poweroff capability").
> > > As discussed on the mailing list, it makes more sense to rename back to the
> > > old established property name, without the vendor prefix. Problem being that
> > > the word "source" usually tends to be used for inputs and that is out of control
> > > of the OS. The poweroff capability is an output which simply turns the
> > > system-power off. Also, this property might be used by drivers which power-off
> > > the system and power back on subsequent RTC alarms. This seems to suggest to
> > > remove "poweroff" from the property name and to choose "system-power-controller"
> > > as the more generic name. This patchs adds the required renaming changes and
> > > defines an helper function which is compatible with both properties, the old one
> > > which was only used by tps65910 and the new one without vendor-prefix.
> >
> > Now this is a bit of a mess.
> >
> > There's a commit in the mfd tree, 25f833c1171d ("mfd: tps65910: Convert
> > ti,system-power-controller DT property to poweroff-source"), which
> > breaks all dts using tps65910 since these are never updated to the now
> > retracted property name ("poweroff-source").
>
> My word!
>
> Romain, what conversation on the MLs are you talking about?
I think Romain is referring to this thread:
https://lkml.org/lkml/2014/10/23/161
> > This one should simply be reverted ASAP.
>
> No need to revert, I can just remove the patch from the MFD tree.
Ok, good. Then this is limited to the regulator tree, and we could
proceed as I outlined below.
> > > Signed-off-by: Romain Perier <romain.perier@gmail.com>
> > > ---
> > > .../bindings/power/{poweroff.txt => power-controller.txt} | 0
> > > .../devicetree/bindings/regulator/act8865-regulator.txt | 4 ++--
> > > drivers/mfd/tps65910.c | 9 ++++++++-
> > > drivers/regulator/act8865-regulator.c | 2 +-
> > > include/linux/of.h | 6 +++---
> > > 5 files changed, 14 insertions(+), 7 deletions(-)
> >
> > Romain, what tree is this patch against? The changes to the tps65910
> > driver appears not to even be in the regulator tree, yet you asked Mark
> > to merge this. And the MFD maintainer is not even on CC.
> >
> > Let's fix the breakage by reverting the offending commit in mfd. Then the
> > new standard name can be introduced in regulator alone (e.g. this patch
> > without the tps65910 bits) as nothing outside of regulator should be
> > using the new power-off feature (or binding) for act8865. Then other
> > drivers and dts can be converted to use the new property name (while
> > retaining backwards compatibility) for 3.20.
> >
> > [ We should probably also consider adding an "of_device_is_" prefix to
> > the helper name for consistency. ]
Romain, care to resend this patch without the tps65910 chunks?
You should also fix the commit message, which claims to define a "helper
function which is compatible with both properties", something which was
no longer the case.
Thanks,
Johan
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"
2014-11-24 11:35 ` Johan Hovold
@ 2014-11-24 12:58 ` Romain Perier
-1 siblings, 0 replies; 33+ messages in thread
From: Romain Perier @ 2014-11-24 12:58 UTC (permalink / raw)
To: Johan Hovold
Cc: Lee Jones, Mark Brown, Heiko Stübner, Grant Likely, robh,
devicetree, Liam Girdwood, Mark Rutland, linux-pm@vger.kernel.org,
Linux Kernel Mailing List, linux-arm-kernel@lists.infradead.org,
Felipe Balbi
2014-11-24 12:35 GMT+01:00 Johan Hovold <johan@kernel.org>:
> On Mon, Nov 24, 2014 at 10:24:56AM +0000, Lee Jones wrote:
>> On Fri, 21 Nov 2014, Johan Hovold wrote:
>> > On Thu, Nov 13, 2014 at 01:34:58PM +0000, Auto Configured wrote:
>> > > From: Romain Perier <romain.perier@gmail.com>
>> > >
>> > > It reverts commit a4b4e0461ec5 ("of: Add standard property for poweroff capability").
>> > > As discussed on the mailing list, it makes more sense to rename back to the
>> > > old established property name, without the vendor prefix. Problem being that
>> > > the word "source" usually tends to be used for inputs and that is out of control
>> > > of the OS. The poweroff capability is an output which simply turns the
>> > > system-power off. Also, this property might be used by drivers which power-off
>> > > the system and power back on subsequent RTC alarms. This seems to suggest to
>> > > remove "poweroff" from the property name and to choose "system-power-controller"
>> > > as the more generic name. This patchs adds the required renaming changes and
>> > > defines an helper function which is compatible with both properties, the old one
>> > > which was only used by tps65910 and the new one without vendor-prefix.
>> >
>> > Now this is a bit of a mess.
>> >
>> > There's a commit in the mfd tree, 25f833c1171d ("mfd: tps65910: Convert
>> > ti,system-power-controller DT property to poweroff-source"), which
>> > breaks all dts using tps65910 since these are never updated to the now
>> > retracted property name ("poweroff-source").
>>
>> My word!
>>
>> Romain, what conversation on the MLs are you talking about?
>
> I think Romain is referring to this thread:
>
> https://lkml.org/lkml/2014/10/23/161
Yes, this is this one.
>
>> > This one should simply be reverted ASAP.
>>
>> No need to revert, I can just remove the patch from the MFD tree.
>
> Ok, good. Then this is limited to the regulator tree, and we could
> proceed as I outlined below.
>
>
> Romain, care to resend this patch without the tps65910 chunks?
If you can just drop the patch from mfd tree Lee, please do.
Yes Johan, np, what I want is that we find a smart solution, nothing more.
>
> You should also fix the commit message, which claims to define a "helper
> function which is compatible with both properties", something which was
> no longer the case.
>
> Thanks,
> Johan
So I need to resend this patch which would only introduce an helper
function which checks for "system-power-controller" property (it would
also have a new commit message).
As you suggested, this helper might be named
"of_device_is_system_power_controller" ?
Everything is okay ?
Romain
^ permalink raw reply [flat|nested] 33+ messages in thread* [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"
@ 2014-11-24 12:58 ` Romain Perier
0 siblings, 0 replies; 33+ messages in thread
From: Romain Perier @ 2014-11-24 12:58 UTC (permalink / raw)
To: linux-arm-kernel
2014-11-24 12:35 GMT+01:00 Johan Hovold <johan@kernel.org>:
> On Mon, Nov 24, 2014 at 10:24:56AM +0000, Lee Jones wrote:
>> On Fri, 21 Nov 2014, Johan Hovold wrote:
>> > On Thu, Nov 13, 2014 at 01:34:58PM +0000, Auto Configured wrote:
>> > > From: Romain Perier <romain.perier@gmail.com>
>> > >
>> > > It reverts commit a4b4e0461ec5 ("of: Add standard property for poweroff capability").
>> > > As discussed on the mailing list, it makes more sense to rename back to the
>> > > old established property name, without the vendor prefix. Problem being that
>> > > the word "source" usually tends to be used for inputs and that is out of control
>> > > of the OS. The poweroff capability is an output which simply turns the
>> > > system-power off. Also, this property might be used by drivers which power-off
>> > > the system and power back on subsequent RTC alarms. This seems to suggest to
>> > > remove "poweroff" from the property name and to choose "system-power-controller"
>> > > as the more generic name. This patchs adds the required renaming changes and
>> > > defines an helper function which is compatible with both properties, the old one
>> > > which was only used by tps65910 and the new one without vendor-prefix.
>> >
>> > Now this is a bit of a mess.
>> >
>> > There's a commit in the mfd tree, 25f833c1171d ("mfd: tps65910: Convert
>> > ti,system-power-controller DT property to poweroff-source"), which
>> > breaks all dts using tps65910 since these are never updated to the now
>> > retracted property name ("poweroff-source").
>>
>> My word!
>>
>> Romain, what conversation on the MLs are you talking about?
>
> I think Romain is referring to this thread:
>
> https://lkml.org/lkml/2014/10/23/161
Yes, this is this one.
>
>> > This one should simply be reverted ASAP.
>>
>> No need to revert, I can just remove the patch from the MFD tree.
>
> Ok, good. Then this is limited to the regulator tree, and we could
> proceed as I outlined below.
>
>
> Romain, care to resend this patch without the tps65910 chunks?
If you can just drop the patch from mfd tree Lee, please do.
Yes Johan, np, what I want is that we find a smart solution, nothing more.
>
> You should also fix the commit message, which claims to define a "helper
> function which is compatible with both properties", something which was
> no longer the case.
>
> Thanks,
> Johan
So I need to resend this patch which would only introduce an helper
function which checks for "system-power-controller" property (it would
also have a new commit message).
As you suggested, this helper might be named
"of_device_is_system_power_controller" ?
Everything is okay ?
Romain
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"
2014-11-24 12:58 ` Romain Perier
@ 2014-11-24 13:01 ` Romain Perier
-1 siblings, 0 replies; 33+ messages in thread
From: Romain Perier @ 2014-11-24 13:01 UTC (permalink / raw)
To: Johan Hovold
Cc: Lee Jones, Mark Brown, Heiko Stübner, Grant Likely, robh,
devicetree, Liam Girdwood, Mark Rutland, linux-pm@vger.kernel.org,
Linux Kernel Mailing List, linux-arm-kernel@lists.infradead.org,
Felipe Balbi
2014-11-24 13:58 GMT+01:00 Romain Perier <romain.perier@gmail.com>:
> 2014-11-24 12:35 GMT+01:00 Johan Hovold <johan@kernel.org>:
>> On Mon, Nov 24, 2014 at 10:24:56AM +0000, Lee Jones wrote:
>>> On Fri, 21 Nov 2014, Johan Hovold wrote:
>>> > On Thu, Nov 13, 2014 at 01:34:58PM +0000, Auto Configured wrote:
>>> > > From: Romain Perier <romain.perier@gmail.com>
>>> > >
>>> > > It reverts commit a4b4e0461ec5 ("of: Add standard property for poweroff capability").
>>> > > As discussed on the mailing list, it makes more sense to rename back to the
>>> > > old established property name, without the vendor prefix. Problem being that
>>> > > the word "source" usually tends to be used for inputs and that is out of control
>>> > > of the OS. The poweroff capability is an output which simply turns the
>>> > > system-power off. Also, this property might be used by drivers which power-off
>>> > > the system and power back on subsequent RTC alarms. This seems to suggest to
>>> > > remove "poweroff" from the property name and to choose "system-power-controller"
>>> > > as the more generic name. This patchs adds the required renaming changes and
>>> > > defines an helper function which is compatible with both properties, the old one
>>> > > which was only used by tps65910 and the new one without vendor-prefix.
>>> >
>>> > Now this is a bit of a mess.
>>> >
>>> > There's a commit in the mfd tree, 25f833c1171d ("mfd: tps65910: Convert
>>> > ti,system-power-controller DT property to poweroff-source"), which
>>> > breaks all dts using tps65910 since these are never updated to the now
>>> > retracted property name ("poweroff-source").
>>>
>>> My word!
>>>
>>> Romain, what conversation on the MLs are you talking about?
>>
>> I think Romain is referring to this thread:
>>
>> https://lkml.org/lkml/2014/10/23/161
>
> Yes, this is this one.
>
>>
>>> > This one should simply be reverted ASAP.
>>>
>>> No need to revert, I can just remove the patch from the MFD tree.
>>
>> Ok, good. Then this is limited to the regulator tree, and we could
>> proceed as I outlined below.
>>
>>
>> Romain, care to resend this patch without the tps65910 chunks?
>
> If you can just drop the patch from mfd tree Lee, please do.
> Yes Johan, np, what I want is that we find a smart solution, nothing more.
>
>>
>> You should also fix the commit message, which claims to define a "helper
>> function which is compatible with both properties", something which was
>> no longer the case.
>>
>> Thanks,
>> Johan
>
> So I need to resend this patch which would only introduce an helper
> function which checks for "system-power-controller" property (it would
> also have a new commit message).
> As you suggested, this helper might be named
> "of_device_is_system_power_controller" ?
I mean, the backward compatibility can be handled directly from the
device driver which would use the new property, no ?
^ permalink raw reply [flat|nested] 33+ messages in thread* [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"
@ 2014-11-24 13:01 ` Romain Perier
0 siblings, 0 replies; 33+ messages in thread
From: Romain Perier @ 2014-11-24 13:01 UTC (permalink / raw)
To: linux-arm-kernel
2014-11-24 13:58 GMT+01:00 Romain Perier <romain.perier@gmail.com>:
> 2014-11-24 12:35 GMT+01:00 Johan Hovold <johan@kernel.org>:
>> On Mon, Nov 24, 2014 at 10:24:56AM +0000, Lee Jones wrote:
>>> On Fri, 21 Nov 2014, Johan Hovold wrote:
>>> > On Thu, Nov 13, 2014 at 01:34:58PM +0000, Auto Configured wrote:
>>> > > From: Romain Perier <romain.perier@gmail.com>
>>> > >
>>> > > It reverts commit a4b4e0461ec5 ("of: Add standard property for poweroff capability").
>>> > > As discussed on the mailing list, it makes more sense to rename back to the
>>> > > old established property name, without the vendor prefix. Problem being that
>>> > > the word "source" usually tends to be used for inputs and that is out of control
>>> > > of the OS. The poweroff capability is an output which simply turns the
>>> > > system-power off. Also, this property might be used by drivers which power-off
>>> > > the system and power back on subsequent RTC alarms. This seems to suggest to
>>> > > remove "poweroff" from the property name and to choose "system-power-controller"
>>> > > as the more generic name. This patchs adds the required renaming changes and
>>> > > defines an helper function which is compatible with both properties, the old one
>>> > > which was only used by tps65910 and the new one without vendor-prefix.
>>> >
>>> > Now this is a bit of a mess.
>>> >
>>> > There's a commit in the mfd tree, 25f833c1171d ("mfd: tps65910: Convert
>>> > ti,system-power-controller DT property to poweroff-source"), which
>>> > breaks all dts using tps65910 since these are never updated to the now
>>> > retracted property name ("poweroff-source").
>>>
>>> My word!
>>>
>>> Romain, what conversation on the MLs are you talking about?
>>
>> I think Romain is referring to this thread:
>>
>> https://lkml.org/lkml/2014/10/23/161
>
> Yes, this is this one.
>
>>
>>> > This one should simply be reverted ASAP.
>>>
>>> No need to revert, I can just remove the patch from the MFD tree.
>>
>> Ok, good. Then this is limited to the regulator tree, and we could
>> proceed as I outlined below.
>>
>>
>> Romain, care to resend this patch without the tps65910 chunks?
>
> If you can just drop the patch from mfd tree Lee, please do.
> Yes Johan, np, what I want is that we find a smart solution, nothing more.
>
>>
>> You should also fix the commit message, which claims to define a "helper
>> function which is compatible with both properties", something which was
>> no longer the case.
>>
>> Thanks,
>> Johan
>
> So I need to resend this patch which would only introduce an helper
> function which checks for "system-power-controller" property (it would
> also have a new commit message).
> As you suggested, this helper might be named
> "of_device_is_system_power_controller" ?
I mean, the backward compatibility can be handled directly from the
device driver which would use the new property, no ?
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"
2014-11-24 13:01 ` Romain Perier
@ 2014-11-24 13:12 ` Heiko Stübner
-1 siblings, 0 replies; 33+ messages in thread
From: Heiko Stübner @ 2014-11-24 13:12 UTC (permalink / raw)
To: Romain Perier
Cc: Johan Hovold, Lee Jones, Mark Brown, Grant Likely, robh,
devicetree, Liam Girdwood, Mark Rutland, linux-pm@vger.kernel.org,
Linux Kernel Mailing List, linux-arm-kernel@lists.infradead.org,
Felipe Balbi
Am Montag, 24. November 2014, 14:01:02 schrieb Romain Perier:
> 2014-11-24 13:58 GMT+01:00 Romain Perier <romain.perier@gmail.com>:
> > So I need to resend this patch which would only introduce an helper
> > function which checks for "system-power-controller" property (it would
> > also have a new commit message).
> > As you suggested, this helper might be named
> > "of_device_is_system_power_controller" ?
>
> I mean, the backward compatibility can be handled directly from the
> device driver which would use the new property, no ?
yep, that is what Grant asked for ... to have drivers that need backward-
compatibility (like with the "ti,"-prefix) to do this themselfs.
Heiko
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"
@ 2014-11-24 13:12 ` Heiko Stübner
0 siblings, 0 replies; 33+ messages in thread
From: Heiko Stübner @ 2014-11-24 13:12 UTC (permalink / raw)
To: linux-arm-kernel
Am Montag, 24. November 2014, 14:01:02 schrieb Romain Perier:
> 2014-11-24 13:58 GMT+01:00 Romain Perier <romain.perier@gmail.com>:
> > So I need to resend this patch which would only introduce an helper
> > function which checks for "system-power-controller" property (it would
> > also have a new commit message).
> > As you suggested, this helper might be named
> > "of_device_is_system_power_controller" ?
>
> I mean, the backward compatibility can be handled directly from the
> device driver which would use the new property, no ?
yep, that is what Grant asked for ... to have drivers that need backward-
compatibility (like with the "ti,"-prefix) to do this themselfs.
Heiko
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"
2014-11-24 12:58 ` Romain Perier
@ 2014-11-24 13:21 ` Johan Hovold
-1 siblings, 0 replies; 33+ messages in thread
From: Johan Hovold @ 2014-11-24 13:21 UTC (permalink / raw)
To: Romain Perier
Cc: Johan Hovold, Lee Jones, Mark Brown, Heiko Stübner,
Grant Likely, robh, devicetree, Liam Girdwood, Mark Rutland,
linux-pm@vger.kernel.org, Linux Kernel Mailing List,
linux-arm-kernel@lists.infradead.org, Felipe Balbi
On Mon, Nov 24, 2014 at 01:58:50PM +0100, Romain Perier wrote:
> 2014-11-24 12:35 GMT+01:00 Johan Hovold <johan@kernel.org>:
> > You should also fix the commit message, which claims to define a "helper
> > function which is compatible with both properties", something which was
> > no longer the case.
> >
> So I need to resend this patch which would only introduce an helper
> function which checks for "system-power-controller" property (it would
> also have a new commit message).
> As you suggested, this helper might be named
> "of_device_is_system_power_controller" ?
Correct. Rename the helper and property name you introduced to
"of_device_is_system_power_controller" and "system-power-controller" and
update the act8865 driver to use the new names (all in one patch).
Send the patch to Mark (and keep everyone else one CC) so he can apply
it to the regulator tree.
Other drivers that are currently using "ti,system-power-controller" can
continue to do so (for backward compatibility), while we later also add
a call to your helper function (and update binding documentation) and
also update the device trees for boards that use this functionality.
Thanks,
Johan
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"
@ 2014-11-24 13:21 ` Johan Hovold
0 siblings, 0 replies; 33+ messages in thread
From: Johan Hovold @ 2014-11-24 13:21 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Nov 24, 2014 at 01:58:50PM +0100, Romain Perier wrote:
> 2014-11-24 12:35 GMT+01:00 Johan Hovold <johan@kernel.org>:
> > You should also fix the commit message, which claims to define a "helper
> > function which is compatible with both properties", something which was
> > no longer the case.
> >
> So I need to resend this patch which would only introduce an helper
> function which checks for "system-power-controller" property (it would
> also have a new commit message).
> As you suggested, this helper might be named
> "of_device_is_system_power_controller" ?
Correct. Rename the helper and property name you introduced to
"of_device_is_system_power_controller" and "system-power-controller" and
update the act8865 driver to use the new names (all in one patch).
Send the patch to Mark (and keep everyone else one CC) so he can apply
it to the regulator tree.
Other drivers that are currently using "ti,system-power-controller" can
continue to do so (for backward compatibility), while we later also add
a call to your helper function (and update binding documentation) and
also update the device trees for boards that use this functionality.
Thanks,
Johan
^ permalink raw reply [flat|nested] 33+ messages in thread