Re: [PATCH v2] tiptop: Add new recipe

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 4290 bytes --]

On Thu, Nov 20, 2014 at 04:59:01PM +0800, Qian Lei wrote:
> Tiptop is a performance monitoring tool for Linux. It provides a
> dynamic real-time view of the tasks running in the system. Tiptop
> is very similar to the top utility, but most of the information
> displayed comes from hardware counters.
> 
> Signed-off-by: Qian Lei <qianl.fnst@cn.fujitsu.com>
> ---
>  .../files/tiptop-remove-path-of-libxml2.patch      | 28 ++++++++++++++++++++++
>  meta-oe/recipes-extended/tiptop/tiptop_2.2.bb      | 15 ++++++++++++
>  2 files changed, 43 insertions(+)
>  create mode 100644 meta-oe/recipes-extended/tiptop/files/tiptop-remove-path-of-libxml2.patch
>  create mode 100644 meta-oe/recipes-extended/tiptop/tiptop_2.2.bb
> 
> diff --git a/meta-oe/recipes-extended/tiptop/files/tiptop-remove-path-of-libxml2.patch b/meta-oe/recipes-extended/tiptop/files/tiptop-remove-path-of-libxml2.patch
> new file mode 100644
> index 0000000..7499828
> --- /dev/null
> +++ b/meta-oe/recipes-extended/tiptop/files/tiptop-remove-path-of-libxml2.patch
> @@ -0,0 +1,28 @@
> +From 2f9cb586d6675371f9db8d4b62a4b339625d73a6 Mon Sep 17 00:00:00 2001
> +From: Qian Lei <qianl.fnst@cn.fujitsu.com>
> +Date: Thu, 20 Nov 2014 16:34:47 +0800
> +Subject: [PATCH] tiptop: Remove the include path
> +
> +Remove the path and specify it in .bb file
> +
> +Signed-off-by: Qian Lei <qianl.fnst@cn.fujitsu.com>
> +---
> + configure.ac | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/configure.ac b/configure.ac
> +index 6a71782..7408f82 100644
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -31,7 +31,7 @@ AC_CHECK_LIB([xml2], [xmlParseFile],
> +                   [have_xml2=yes;
> +                   AC_DEFINE([HAVE_LIBXML2], [1], [Define to 1 if you have the `libxml2' library (-lxml2).])
> +                   LIBS="-lxml2 $LIBS"
> +-                  CFLAGS="$CFLAGS -I/usr/include/libxml2"],
> ++                  CFLAGS="$CFLAGS"],
> +              [have_xml2=no])
> + fi
> + 
> +-- 
> +1.8.3.1
> +
> diff --git a/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb b/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb
> new file mode 100644
> index 0000000..d8a0de4
> --- /dev/null
> +++ b/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb
> @@ -0,0 +1,15 @@
> +SUMMARY = "Hardware performance monitoring counters"
> +HOMEPAGE = "http://tiptop.gforge.inria.fr/"
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> +DEPENDS = "ncurses libxml2"
> +
> +SRC_URI = "http://tiptop.gforge.inria.fr/releases/${BP}.tar.gz;name=tarball \
> +           file://tiptop-remove-path-of-libxml2.patch \
> +"
> +SRC_URI[tarball.md5sum] = "74255a29acf44569db021b080ad3e3f7"
> +SRC_URI[tarball.sha256sum] = "965cb99b16cb59df78363d83b62877ce8501b0aac1116a86bed8a16aa96b171d"

Drop name=tarball and tarball. prefix.

Fails to build for qemuarm:

| In file included from target.c:17:0:
| target-x86.c: In function 'disp_family_model':
| target-x86.c:54:3: error: unknown register name '%edx' in 'asm'
|    asm("mov $1, %%eax; " /* a into eax */
|    ^
| target-x86.c:54:3: error: unknown register name '%ecx' in 'asm'
| target-x86.c:54:3: error: unknown register name '%ebx' in 'asm'
| target-x86.c:54:3: error: unknown register name '%eax' in 'asm'
| make[1]: *** [target.o] Error 1
| make[1]: *** Waiting for unfinished jobs....
| make[1]: Leaving directory `/home/jenkins/oe/world/shr-core/tmp-glibc/work/armv5te-oe-linux-gnueabi/tiptop/2.2-r0/tiptop-2.2/src'
| make: *** [all] Error 2
| ERROR: oe_runmake failed
| WARNING: exit code 1 from a shell command.
| ERROR: Function failed: do_compile (log file is located at /home/jenkins/oe/world/shr-core/tmp-glibc/work/armv5te-oe-linux-gnueabi/tiptop/2.2-r0/temp/log.do_compile.7484)
NOTE: recipe tiptop-2.2-r0: task do_compile: Failed


> +
> +EXTRA_OECONF = "CFLAGS="$CFLAGS -I${STAGING_INCDIR}/libxml2""
> +
> +inherit autotools-brokensep
> -- 
> 1.8.3.1
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]