Re: [meta-oe][PATCH v3] tiptop: Add new recipe

[Qian Lei <qianl.fnst@cn.fujitsu.com>]

On Thu, 27 Nov 2014 10:40:59 +0100
Koen Kooi <koen@dominion.thruhere.net> wrote:

> > diff --git a/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb
> > b/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb new file mode 100644 
> > index 0000000..126976c --- /dev/null +++
> > b/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb @@ -0,0 +1,26 @@ +SUMMARY
> > = "Hardware performance monitoring counters" +HOMEPAGE =
> > "http://tiptop.gforge.inria.fr/" +LICENSE = "GPLv2" +LIC_FILES_CHKSUM =
> > "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263" +DEPENDS = "ncurses
> > libxml2" + +SRC_URI =
> > "http://tiptop.gforge.inria.fr/releases/${BP}.tar.gz" +SRC_URI[md5sum] =
> > "74255a29acf44569db021b080ad3e3f7" +SRC_URI[sha256sum] =
> > "965cb99b16cb59df78363d83b62877ce8501b0aac1116a86bed8a16aa96b171d" + 
> > +inherit autotools-brokensep +EXTRA_OECONF = "CFLAGS="$CFLAGS
> > -I${STAGING_INCDIR}/libxml2"" +COMPATIBLE_HOST =
> > "(i.86|x86_64|arm|powerpc).*-linux"
> 
> What's broken on mips, armv8 and avr32?

It seems that tiptop is not supported on some architectures. The patch on
bugzilla[1] has only fixed part of this issue(mips not included). I failed to
build it on qemu-mips and have to use COMPATIBLE_HOST to limit the target
architectures. I have only built it on qemux-(x86|x86-64|arm|ppc|mips) and know
few about armv8, arv32. Any documents for them? How can I simulate them in qemu?

By the way, there are also some patches[2-3] on debian. Should I include them
in the next patch?

[1]https://bugzilla.redhat.com/show_bug.cgi?id=1122009
[2]http://anonscm.debian.org/cgit/collab-maint/tiptop.git/tree/debian/patches/0001-Fix-minor-problems-with-the-manpage.patch
[3]http://anonscm.debian.org/cgit/collab-maint/tiptop.git/tree/debian/patches/0002-Fix-linking-phase.patch

> 
> > + +do_configure_prepend () { +    # Two bugs in configure.ac when
> > cross-compiling. +    # 1. The path of libxml2. Specify it in
> > EXTRA_OECONF. +    # 2. hw's value on other platforms. Replace it if the
> > target is +    #    not i*86/x86_64. +    if ( echo "${TARGET_ARCH}" |
> > grep -q -e 'i.86' -e 'x86_64' ); then +        sed -i 's=
> > -I/usr/include/libxml2=='    ${S}/configure.ac +    else +        sed -i
> > 's/hw=`uname -m`/hw="unknown"/'  ${S}/configure.ac +        sed -i 's=
> > -I/usr/include/libxml2=='    ${S}/configure.ac +    fi +}
> 
> Drop the conditional, it should *never* use uname.

Ok, it will be modified in next patch, which will be submitted a few days later.

-- 
Qian Lei