Re: [PATCH v1] usb: phy: nop: device tree documentation for vbus

[Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]

On Fri, Nov 21, 2014 at 06:49:47PM +0100, Robert Jarzmik wrote:
> Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> writes:
> 
> > On Fri, Nov 21, 2014 at 06:17:58PM +0100, Robert Jarzmik wrote:
> >> Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> writes:
> >> 
> >> > On Sun, Nov 09, 2014 at 02:02:18PM +0100, Robert Jarzmik wrote:
> >> >>  	hsusb1_phy {
> >> >> @@ -26,8 +31,11 @@ Example:
> >> >>  		clock-names = "main_clk";
> >> >>  		vcc-supply = <&hsusb1_vcc_regulator>;
> >> >>  		reset-gpios = <&gpio1 7 GPIO_ACTIVE_LOW>;
> >> >> +		vbus-gpios = <&gpio2 13 GPIO_ACTIVE_HIGH>;
> >> >> +		vbus-regulator = <&vbus_regulator>;
> >> >
> >> > not sure why you need vbus-gpios here. You can pass the gpio to the
> >> > regulator as enable-gpio, right ?
> >> 
> >> Euh no. From my understanding a regulator enable-gpio is an _output_ gpio
> >> enabling the regulator. This vbus-gpio is an _input_ gpio detecting the vbus
> >> assertion. Maybe a name like "vbus-detect-gpio" would be more accurante ?
> >
> > aha, that clears it up, yeah. So the GPIO is detecting if we have VBUS
> > from the host side while the regulator supplies VBUS ?
> Yup, exactly. I'll amend the name for v2.

Thank you

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]