From: Robert Jarzmik <robert.jarzmik-GANU6spQydw@public.gmane.org>
To: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v1] usb: phy: nop: device tree documentation for vbus
Date: Fri, 21 Nov 2014 18:17:58 +0100 [thread overview]
Message-ID: <87r3ww5v7d.fsf@free.fr> (raw)
In-Reply-To: <20141121154506.GG7508@saruman> (Felipe Balbi's message of "Fri, 21 Nov 2014 09:45:06 -0600")
Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> writes:
> On Sun, Nov 09, 2014 at 02:02:18PM +0100, Robert Jarzmik wrote:
>> hsusb1_phy {
>> @@ -26,8 +31,11 @@ Example:
>> clock-names = "main_clk";
>> vcc-supply = <&hsusb1_vcc_regulator>;
>> reset-gpios = <&gpio1 7 GPIO_ACTIVE_LOW>;
>> + vbus-gpios = <&gpio2 13 GPIO_ACTIVE_HIGH>;
>> + vbus-regulator = <&vbus_regulator>;
>
> not sure why you need vbus-gpios here. You can pass the gpio to the
> regulator as enable-gpio, right ?
Euh no. From my understanding a regulator enable-gpio is an _output_ gpio
enabling the regulator. This vbus-gpio is an _input_ gpio detecting the vbus
assertion. Maybe a name like "vbus-detect-gpio" would be more accurante ?
Cheers.
--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-11-21 17:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-09 13:02 [PATCH v1] usb: phy: nop: device tree documentation for vbus Robert Jarzmik
[not found] ` <1415538138-24434-1-git-send-email-robert.jarzmik-GANU6spQydw@public.gmane.org>
2014-11-21 15:45 ` Felipe Balbi
2014-11-21 17:17 ` Robert Jarzmik [this message]
[not found] ` <87r3ww5v7d.fsf-GANU6spQydw@public.gmane.org>
2014-11-21 17:22 ` Felipe Balbi
2014-11-21 17:49 ` Robert Jarzmik
[not found] ` <87ioi85tqc.fsf-GANU6spQydw@public.gmane.org>
2014-11-21 18:03 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3ww5v7d.fsf@free.fr \
--to=robert.jarzmik-ganu6spqydw@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.