All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
Cc: Alexander Kochetkov
	<al.kochet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH 2/4] i2c: omap: implement workaround for handling invalid BB-bit values
Date: Sat, 22 Nov 2014 14:23:09 +0100	[thread overview]
Message-ID: <20141122132309.GC2679@katana> (raw)
In-Reply-To: <20141121160808.GM7508@saruman>

[-- Attachment #1: Type: text/plain, Size: 1204 bytes --]

On Fri, Nov 21, 2014 at 10:08:08AM -0600, Felipe Balbi wrote:
> On Fri, Nov 21, 2014 at 01:28:43AM +0400, Alexander Kochetkov wrote:
> > In a multimaster environment, after IP software reset, BB-bit value doesn't
> > correspond to the current bus state. It may happen what BB-bit will be 0,
> > while the bus is busy due to another I2C master activity.
> > 
> > Any transfer started when BB=0 and bus is busy wouldn't be completed by IP
> > and results in controller timeout. More over, in some cases IP could
> > interrupt another master's transfer and corrupt data on wire.
> > 
> > The commit implement method allowing to prevent IP from entering into
> > "controller timeout" state and from "data corruption" state.
> > 
> > The one drawback is the need to wait for 10ms before the first transfer.
> > 
> > Tested on Beagleboard XM C.
> > 
> > Signed-off-by: Alexander Kochetkov <al.kochet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> 
> Tested on BBB and AM437x Starter Kit
> 
> Tested-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
> Reviewed-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>

Huh, I can't apply this one? Which kernel version is this based on?


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Felipe Balbi <balbi@ti.com>
Cc: Alexander Kochetkov <al.kochet@gmail.com>,
	linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org,
	linux-kernel@vger.kernel.org, Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 2/4] i2c: omap: implement workaround for handling invalid BB-bit values
Date: Sat, 22 Nov 2014 14:23:09 +0100	[thread overview]
Message-ID: <20141122132309.GC2679@katana> (raw)
In-Reply-To: <20141121160808.GM7508@saruman>

[-- Attachment #1: Type: text/plain, Size: 1130 bytes --]

On Fri, Nov 21, 2014 at 10:08:08AM -0600, Felipe Balbi wrote:
> On Fri, Nov 21, 2014 at 01:28:43AM +0400, Alexander Kochetkov wrote:
> > In a multimaster environment, after IP software reset, BB-bit value doesn't
> > correspond to the current bus state. It may happen what BB-bit will be 0,
> > while the bus is busy due to another I2C master activity.
> > 
> > Any transfer started when BB=0 and bus is busy wouldn't be completed by IP
> > and results in controller timeout. More over, in some cases IP could
> > interrupt another master's transfer and corrupt data on wire.
> > 
> > The commit implement method allowing to prevent IP from entering into
> > "controller timeout" state and from "data corruption" state.
> > 
> > The one drawback is the need to wait for 10ms before the first transfer.
> > 
> > Tested on Beagleboard XM C.
> > 
> > Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>
> 
> Tested on BBB and AM437x Starter Kit
> 
> Tested-by: Felipe Balbi <balbi@ti.com>
> Reviewed-by: Felipe Balbi <balbi@ti.com>

Huh, I can't apply this one? Which kernel version is this based on?


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2014-11-22 13:23 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-20 21:28 [RFC 0/4] i2c: omap: patch series related to multimaster mode Alexander Kochetkov
2014-11-20 21:28 ` Alexander Kochetkov
2014-11-20 21:28 ` [PATCH 1/4] i2c: omap: cleanup register definitions Alexander Kochetkov
     [not found]   ` <1416518925-20679-2-git-send-email-al.kochet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-21 16:08     ` Felipe Balbi
2014-11-21 16:08       ` Felipe Balbi
2014-11-20 21:28 ` [PATCH 3/4] i2c: omap: don't reset controller if Arbitration Lost detected Alexander Kochetkov
2014-11-21 16:08   ` Felipe Balbi
2014-11-21 16:08     ` Felipe Balbi
2014-11-21 18:11   ` Wolfram Sang
     [not found]   ` <1416518925-20679-4-git-send-email-al.kochet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-21 22:51     ` [PATCH v2 " Alexander Kochetkov
2014-11-21 22:51       ` Alexander Kochetkov
     [not found]       ` <1416610307-3698-1-git-send-email-al.kochet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-22  1:07         ` Felipe Balbi
2014-11-22  1:07           ` Felipe Balbi
2014-11-20 21:28 ` [PATCH 4/4] i2c: omap: add notes related to i2c multimaster mode Alexander Kochetkov
2014-11-21 16:08   ` Felipe Balbi
2014-11-21 16:08     ` Felipe Balbi
     [not found] ` <1416518925-20679-1-git-send-email-al.kochet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-20 21:28   ` [PATCH 2/4] i2c: omap: implement workaround for handling invalid BB-bit values Alexander Kochetkov
2014-11-20 21:28     ` Alexander Kochetkov
2014-11-21 16:08     ` Felipe Balbi
2014-11-21 16:08       ` Felipe Balbi
2014-11-22 13:23       ` Wolfram Sang [this message]
2014-11-22 13:23         ` Wolfram Sang
2014-11-22 14:06         ` Alexander Kochetkov
2014-11-22 14:06           ` Alexander Kochetkov
     [not found]           ` <B6D9B4D7-25CB-456F-88B4-EB6A53E33A9D-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-22 18:02             ` Wolfram Sang
2014-11-22 18:02               ` Wolfram Sang
2014-11-23  4:43               ` Felipe Balbi
2014-11-23  4:43                 ` Felipe Balbi
2014-11-23 13:18                 ` Alexander Kochetkov
2014-11-23 13:18                   ` Alexander Kochetkov
2014-11-24 19:08                   ` Felipe Balbi
2014-11-24 19:08                     ` Felipe Balbi
2014-11-24 19:09     ` Felipe Balbi
2014-11-24 19:09       ` Felipe Balbi
2014-11-22 19:47   ` [PATCH v3 0/4] i2c: omap: patch series related to multimaster mode Alexander Kochetkov
2014-11-22 19:47     ` Alexander Kochetkov
2014-11-22 19:47     ` [PATCH v3 2/4] i2c: omap: implement workaround for handling invalid BB-bit values Alexander Kochetkov
2014-11-24 19:08       ` Kevin Hilman
     [not found]         ` <CAMAWPa8whctBR6fBFaSzPvm3qn+QK06CimRrxFxxH=0kNkF4UA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-24 19:10           ` Felipe Balbi
2014-11-24 19:10             ` Felipe Balbi
2014-11-24 19:13             ` Wolfram Sang
2014-11-24 19:25               ` Tony Lindgren
2014-11-24 19:25                 ` Tony Lindgren
2014-11-24 19:39         ` Alexander Kochetkov
2014-11-24 19:39           ` Alexander Kochetkov
     [not found]           ` <47A1A441-952C-4AC3-859C-5A8E405767E0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-24 19:47             ` Tony Lindgren
2014-11-24 19:47               ` Tony Lindgren
2014-11-24 20:05               ` Alexander Kochetkov
     [not found]                 ` <47749B61-5924-4E56-9931-77B0CFC0AAA0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-25  0:09                   ` Alexander Kochetkov
2014-11-25  0:09                     ` Alexander Kochetkov
     [not found]                     ` <06376010-5DED-49AA-9494-A9546567E7CA-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-25 15:41                       ` Tony Lindgren
2014-11-25 15:41                         ` Tony Lindgren
2014-11-24 21:08               ` Alexander Kochetkov
2014-11-24 21:08                 ` Alexander Kochetkov
2014-11-26 22:30               ` Alexander Kochetkov
     [not found]       ` <1416685634-5864-3-git-send-email-al.kochet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-24 20:33         ` [PATCH] omap: i2c: don't check bus state IP rev3.3 and earlier Alexander Kochetkov
2014-11-24 20:33           ` Alexander Kochetkov
     [not found]           ` <1416861189-17109-1-git-send-email-al.kochet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-24 21:08             ` Tony Lindgren
2014-11-24 21:08               ` Tony Lindgren
     [not found]               ` <20141124210809.GG2817-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2014-11-24 22:20                 ` [PATCH v2] " Alexander Kochetkov
2014-11-24 22:20                   ` Alexander Kochetkov
2014-11-25 14:19                   ` Wolfram Sang
2014-11-25 14:38                     ` Alexander Kochetkov
     [not found]                       ` <7E0A0B24-91D5-41A4-B007-004C5965D0D7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-25 19:13                         ` Kevin Hilman
2014-11-25 19:13                           ` Kevin Hilman
     [not found]                           ` <7hvbm3jdq1.fsf-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
2014-11-26 19:26                             ` Alexander Kochetkov
2014-11-26 19:26                               ` Alexander Kochetkov
     [not found]                               ` <65BAE81D-E894-48EB-B5A0-0D0FFB9B448F-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-26 21:33                                 ` Kevin Hilman
2014-11-26 21:33                                   ` Kevin Hilman
     [not found]                   ` <1416867655-22232-1-git-send-email-al.kochet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-25 19:12                     ` Kevin Hilman
2014-11-25 19:12                       ` Kevin Hilman
2014-11-26 19:05       ` [RFC] i2c: omap: TEST: do IP reset during probe Alexander Kochetkov
2014-11-26 21:25         ` Kevin Hilman
     [not found]           ` <7hzjbdd57j.fsf-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
2014-11-28 22:13             ` Tony Lindgren
2014-11-28 22:13               ` Tony Lindgren
     [not found]               ` <20141128221350.GW2817-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2014-11-28 23:25                 ` Alexander Kochetkov
2014-11-28 23:25                   ` Alexander Kochetkov
     [not found]                   ` <E4A4FA05-0752-41CB-B86B-84035C6EAF05-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-29 22:06                     ` Tony Lindgren
2014-11-29 22:06                       ` Tony Lindgren
2014-11-29  2:14                 ` Alexander Kochetkov
2014-11-29  2:14                   ` Alexander Kochetkov
2014-11-22 19:47     ` [PATCH v3 4/4] i2c: omap: add notes related to i2c multimaster mode Alexander Kochetkov
     [not found]     ` <1416685634-5864-1-git-send-email-al.kochet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-22 19:47       ` [PATCH v3 1/4] i2c: omap: cleanup register definitions Alexander Kochetkov
2014-11-22 19:47         ` Alexander Kochetkov
2014-11-22 19:47       ` [PATCH v3 3/4] i2c: omap: don't reset controller if Arbitration Lost detected Alexander Kochetkov
2014-11-22 19:47         ` Alexander Kochetkov
2014-11-22 21:08       ` [PATCH v3 0/4] i2c: omap: patch series related to multimaster mode Wolfram Sang
2014-11-22 21:08         ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141122132309.GC2679@katana \
    --to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
    --cc=al.kochet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=balbi-l0cyMroinI0@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.