All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@samsung.com>
To: Kukjin Kim <kgene@kernel.org>
Cc: linux-samsung-soc@vger.kernel.org, tomasz.figa@gmail.com,
	linux-arm-kernel@lists.infradead.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Kukjin Kim <kgene.kim@samsung.com>
Subject: Re: [RESEND PATCH 1/2] ARM: dts: exynos4x12: Device tree node definition for TMU on Exynos4x12
Date: Mon, 24 Nov 2014 09:49:26 +0100	[thread overview]
Message-ID: <20141124094926.04ffacfd@amdc2363> (raw)
In-Reply-To: <035001d005fd$7abac670$70305350$@kernel.org>

Hi Kukjin,

> Lukasz Majewski wrote:
> > 
> + Bart, Tomasz and MLs
> 
> Hi Lukasz,
> 
> Please post including MLs, even resending.
> 
> Will apply for v3.19, and just note that you asked me to apply this
> for 3.18 in personal talk but I couldn't see any requirements for
> fixes-3.18. If I'm missing something, please let me know.

The thing is that by default Exynos 4412 (trats2) can run with modified
cpufreq to support SW governed overclocking (BOOST).

To provide safe BOOST operation, TMU (thermal) _must_ be configured.
Configuration is not possible when trats2 DTS lacks of those patches.

So, yes there is a requirement to add those patches to v3.18 (if not
possible please add it to v3.19).

> 
> Thanks,
> Kukjin
> 
> > The TMU device tree node definition for Exynos4x12 family of SoCs.
> > 
> > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> > Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Reviewed-by: Tomasz Figa <tomasz.figa@gmail.com>
> > ---
> >  arch/arm/boot/dts/exynos4x12.dtsi | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/exynos4x12.dtsi
> > b/arch/arm/boot/dts/exynos4x12.dtsi index 861bb91..2e9f1f7 100644
> > --- a/arch/arm/boot/dts/exynos4x12.dtsi
> > +++ b/arch/arm/boot/dts/exynos4x12.dtsi
> > @@ -271,4 +271,14 @@
> >  		compatible = "samsung,exynos4x12-usb2-phy";
> >  		samsung,sysreg-phandle = <&sys_reg>;
> >  	};
> > +
> > +	tmu@100C0000 {
> > +		compatible = "samsung,exynos4412-tmu";
> > +		interrupt-parent = <&combiner>;
> > +		interrupts = <2 4>;
> > +		reg = <0x100C0000 0x100>;
> > +		clocks = <&clock 383>;
> > +		clock-names = "tmu_apbif";
> > +		status = "disabled";
> > +	};
> >  };
> > --
> > 2.0.0.rc2
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

WARNING: multiple messages have this Message-ID (diff)
From: l.majewski@samsung.com (Lukasz Majewski)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH 1/2] ARM: dts: exynos4x12: Device tree node definition for TMU on Exynos4x12
Date: Mon, 24 Nov 2014 09:49:26 +0100	[thread overview]
Message-ID: <20141124094926.04ffacfd@amdc2363> (raw)
In-Reply-To: <035001d005fd$7abac670$70305350$@kernel.org>

Hi Kukjin,

> Lukasz Majewski wrote:
> > 
> + Bart, Tomasz and MLs
> 
> Hi Lukasz,
> 
> Please post including MLs, even resending.
> 
> Will apply for v3.19, and just note that you asked me to apply this
> for 3.18 in personal talk but I couldn't see any requirements for
> fixes-3.18. If I'm missing something, please let me know.

The thing is that by default Exynos 4412 (trats2) can run with modified
cpufreq to support SW governed overclocking (BOOST).

To provide safe BOOST operation, TMU (thermal) _must_ be configured.
Configuration is not possible when trats2 DTS lacks of those patches.

So, yes there is a requirement to add those patches to v3.18 (if not
possible please add it to v3.19).

> 
> Thanks,
> Kukjin
> 
> > The TMU device tree node definition for Exynos4x12 family of SoCs.
> > 
> > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> > Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Reviewed-by: Tomasz Figa <tomasz.figa@gmail.com>
> > ---
> >  arch/arm/boot/dts/exynos4x12.dtsi | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/exynos4x12.dtsi
> > b/arch/arm/boot/dts/exynos4x12.dtsi index 861bb91..2e9f1f7 100644
> > --- a/arch/arm/boot/dts/exynos4x12.dtsi
> > +++ b/arch/arm/boot/dts/exynos4x12.dtsi
> > @@ -271,4 +271,14 @@
> >  		compatible = "samsung,exynos4x12-usb2-phy";
> >  		samsung,sysreg-phandle = <&sys_reg>;
> >  	};
> > +
> > +	tmu at 100C0000 {
> > +		compatible = "samsung,exynos4412-tmu";
> > +		interrupt-parent = <&combiner>;
> > +		interrupts = <2 4>;
> > +		reg = <0x100C0000 0x100>;
> > +		clocks = <&clock 383>;
> > +		clock-names = "tmu_apbif";
> > +		status = "disabled";
> > +	};
> >  };
> > --
> > 2.0.0.rc2
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

  reply	other threads:[~2014-11-24  8:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1416474343-1283-1-git-send-email-l.majewski@samsung.com>
2014-11-22  2:39 ` [RESEND PATCH 1/2] ARM: dts: exynos4x12: Device tree node definition for TMU on Exynos4x12 Kukjin Kim
2014-11-22  2:39   ` Kukjin Kim
2014-11-24  8:49   ` Lukasz Majewski [this message]
2014-11-24  8:49     ` Lukasz Majewski
2014-11-26 17:56     ` Kukjin Kim
2014-11-26 17:56       ` Kukjin Kim
     [not found] ` <1416474343-1283-2-git-send-email-l.majewski@samsung.com>
2014-11-22  2:40   ` [RESEND PATCH 2/2] ARM: dts: exynos4412-trats2: Enable TMU support at Trats2 Kukjin Kim
2014-11-22  2:40     ` Kukjin Kim
2013-10-09  6:29 [PATCH v2 4/5] ARM: dts: exynos4x12: Device tree node definition for TMU on Exynos4x12 Lukasz Majewski
     [not found] ` <1381300194-13134-5-git-send-email-l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-11-14 10:03   ` [RESEND PATCH 1/2] " Lukasz Majewski
2014-11-14 10:03     ` Lukasz Majewski
2014-11-14 10:03     ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141124094926.04ffacfd@amdc2363 \
    --to=l.majewski@samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.