From: "John W. Linville" <linville@tuxdriver.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
Valerio Passini <valerio.passini@unicam.it>
Subject: Re: [PATCH 1/2 3.18] rtlwifi: rtl8821ae: Fix 5G detection problem
Date: Tue, 25 Nov 2014 14:53:34 -0500 [thread overview]
Message-ID: <20141125195333.GJ15476@tuxdriver.com> (raw)
In-Reply-To: <5474DD88.7060002@lwfinger.net>
On Tue, Nov 25, 2014 at 01:50:32PM -0600, Larry Finger wrote:
> On 11/25/2014 12:46 PM, John W. Linville wrote:
> >On Tue, Nov 25, 2014 at 10:32:06AM -0600, Larry Finger wrote:
> >>The changes associated with moving this driver from staging to the regular
> >>tree missed one section setting the allowable rates for the 5GHz band.
> >>
> >>This patch is needed to fix the regression reported in Bug #88811
> >>(https://bugzilla.kernel.org/show_bug.cgi?id=88811).
> >>
> >>Reported-by: Valerio Passini <valerio.passini@unicam.it>
> >>Tested-by: Valerio Passini <valerio.passini@unicam.it>
> >>Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> >>Cc: Valerio Passini <valerio.passini@unicam.it>
> >>---
> >> drivers/net/wireless/rtlwifi/rtl8821ae/hw.c | 5 +++--
> >> 1 file changed, 3 insertions(+), 2 deletions(-)
> >>
> >>diff --git a/drivers/net/wireless/rtlwifi/rtl8821ae/hw.c b/drivers/net/wireless/rtlwifi/rtl8821ae/hw.c
> >>index 310d316..18f34f7 100644
> >>--- a/drivers/net/wireless/rtlwifi/rtl8821ae/hw.c
> >>+++ b/drivers/net/wireless/rtlwifi/rtl8821ae/hw.c
> >>@@ -3672,8 +3672,9 @@ static void rtl8821ae_update_hal_rate_mask(struct ieee80211_hw *hw,
> >> mac->opmode == NL80211_IFTYPE_ADHOC)
> >> macid = sta->aid + 1;
> >> if (wirelessmode == WIRELESS_MODE_N_5G ||
> >>- wirelessmode == WIRELESS_MODE_AC_5G)
> >>- ratr_bitmap = sta->supp_rates[NL80211_BAND_5GHZ];
> >>+ wirelessmode == WIRELESS_MODE_AC_5G ||
> >>+ wirelessmode == WIRELESS_MODE_A)
> >>+ ratr_bitmap = (sta->supp_rates[NL80211_BAND_5GHZ])<<4;
> >
> >The parenthesis seem superfluous. How about this line instead?
> >
> >+ ratr_bitmap = sta->supp_rates[NL80211_BAND_5GHZ] << 4;
> >
> >> else
> >> ratr_bitmap = sta->supp_rates[NL80211_BAND_2GHZ];
>
> Good idea. V2 is on its way.
No need -- I merged it with my version of the line. :-)
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
WARNING: multiple messages have this Message-ID (diff)
From: "John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
To: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Valerio Passini
<valerio.passini-vbqOIlEVYMdeoWH0uzbU5w@public.gmane.org>
Subject: Re: [PATCH 1/2 3.18] rtlwifi: rtl8821ae: Fix 5G detection problem
Date: Tue, 25 Nov 2014 14:53:34 -0500 [thread overview]
Message-ID: <20141125195333.GJ15476@tuxdriver.com> (raw)
In-Reply-To: <5474DD88.7060002-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
On Tue, Nov 25, 2014 at 01:50:32PM -0600, Larry Finger wrote:
> On 11/25/2014 12:46 PM, John W. Linville wrote:
> >On Tue, Nov 25, 2014 at 10:32:06AM -0600, Larry Finger wrote:
> >>The changes associated with moving this driver from staging to the regular
> >>tree missed one section setting the allowable rates for the 5GHz band.
> >>
> >>This patch is needed to fix the regression reported in Bug #88811
> >>(https://bugzilla.kernel.org/show_bug.cgi?id=88811).
> >>
> >>Reported-by: Valerio Passini <valerio.passini-vbqOIlEVYMdeoWH0uzbU5w@public.gmane.org>
> >>Tested-by: Valerio Passini <valerio.passini-vbqOIlEVYMdeoWH0uzbU5w@public.gmane.org>
> >>Signed-off-by: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
> >>Cc: Valerio Passini <valerio.passini-vbqOIlEVYMdeoWH0uzbU5w@public.gmane.org>
> >>---
> >> drivers/net/wireless/rtlwifi/rtl8821ae/hw.c | 5 +++--
> >> 1 file changed, 3 insertions(+), 2 deletions(-)
> >>
> >>diff --git a/drivers/net/wireless/rtlwifi/rtl8821ae/hw.c b/drivers/net/wireless/rtlwifi/rtl8821ae/hw.c
> >>index 310d316..18f34f7 100644
> >>--- a/drivers/net/wireless/rtlwifi/rtl8821ae/hw.c
> >>+++ b/drivers/net/wireless/rtlwifi/rtl8821ae/hw.c
> >>@@ -3672,8 +3672,9 @@ static void rtl8821ae_update_hal_rate_mask(struct ieee80211_hw *hw,
> >> mac->opmode == NL80211_IFTYPE_ADHOC)
> >> macid = sta->aid + 1;
> >> if (wirelessmode == WIRELESS_MODE_N_5G ||
> >>- wirelessmode == WIRELESS_MODE_AC_5G)
> >>- ratr_bitmap = sta->supp_rates[NL80211_BAND_5GHZ];
> >>+ wirelessmode == WIRELESS_MODE_AC_5G ||
> >>+ wirelessmode == WIRELESS_MODE_A)
> >>+ ratr_bitmap = (sta->supp_rates[NL80211_BAND_5GHZ])<<4;
> >
> >The parenthesis seem superfluous. How about this line instead?
> >
> >+ ratr_bitmap = sta->supp_rates[NL80211_BAND_5GHZ] << 4;
> >
> >> else
> >> ratr_bitmap = sta->supp_rates[NL80211_BAND_2GHZ];
>
> Good idea. V2 is on its way.
No need -- I merged it with my version of the line. :-)
John
--
John W. Linville Someday the world will need a hero, and you
linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-11-25 20:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 16:32 [PATCH 0/2 3.18] Fixes for Bug #88811 Larry Finger
2014-11-25 16:32 ` [PATCH 1/2 3.18] rtlwifi: rtl8821ae: Fix 5G detection problem Larry Finger
2014-11-25 18:46 ` John W. Linville
2014-11-25 19:50 ` Larry Finger
2014-11-25 19:53 ` John W. Linville [this message]
2014-11-25 19:53 ` John W. Linville
2014-11-25 16:32 ` [PATCH 2/2 3.18] rtlwifi: Change order in device startup Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141125195333.GJ15476@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=valerio.passini@unicam.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.