From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Kevin Hilman <khilman@deeprootsystems.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Sekhar Nori <nsekhar@ti.com>,
linux-kernel@vger.kernel.org,
Murali Karicheri <m-karicheri2@ti.com>,
linux-i2c@vger.kernel.org,
Mike Looijmans <milo-software@users.sourceforge.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/5] i2c: davinci: query STP always when NACK is received
Date: Wed, 26 Nov 2014 18:15:19 +0100 [thread overview]
Message-ID: <20141126171519.GP4431@pengutronix.de> (raw)
In-Reply-To: <5476005A.6090207@ti.com>
Hello Grygorii,
On Wed, Nov 26, 2014 at 06:31:22PM +0200, Grygorii Strashko wrote:
> On 11/26/2014 05:57 PM, Uwe Kleine-König wrote:
> >I don't understand your use of "query" in the subject and later in the
> >commit log. Do you mean "send"?
>
> will change to "generate". Ok?
yes that would be better understandable
> Can I assume that you are ok with this patch in general?
Yeah, your argument that being able to send a Sr is not sensible made
sense to me. If Wolfram is happy with your patch so am I.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
WARNING: multiple messages have this Message-ID (diff)
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/5] i2c: davinci: query STP always when NACK is received
Date: Wed, 26 Nov 2014 18:15:19 +0100 [thread overview]
Message-ID: <20141126171519.GP4431@pengutronix.de> (raw)
In-Reply-To: <5476005A.6090207@ti.com>
Hello Grygorii,
On Wed, Nov 26, 2014 at 06:31:22PM +0200, Grygorii Strashko wrote:
> On 11/26/2014 05:57 PM, Uwe Kleine-K?nig wrote:
> >I don't understand your use of "query" in the subject and later in the
> >commit log. Do you mean "send"?
>
> will change to "generate". Ok?
yes that would be better understandable
> Can I assume that you are ok with this patch in general?
Yeah, your argument that being able to send a Sr is not sensible made
sense to me. If Wolfram is happy with your patch so am I.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2014-11-26 17:15 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 13:59 [PATCH v2 0/5] i2c: davinci improvements and fixes Grygorii Strashko
2014-11-26 13:59 ` Grygorii Strashko
2014-11-26 13:59 ` Grygorii Strashko
2014-11-26 13:59 ` [PATCH v2 1/5] i2c: i2c-davinci: switch to use platform_get_irq Grygorii Strashko
2014-11-26 13:59 ` Grygorii Strashko
2014-11-26 13:59 ` Grygorii Strashko
[not found] ` <1417010393-30598-2-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org>
2014-11-26 15:54 ` Uwe Kleine-König
2014-11-26 15:54 ` Uwe Kleine-König
2014-11-26 15:54 ` Uwe Kleine-König
[not found] ` <20141126155431.GK4431-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-11-26 16:28 ` Grygorii Strashko
2014-11-26 16:28 ` Grygorii Strashko
2014-11-26 16:28 ` Grygorii Strashko
2014-11-26 13:59 ` [PATCH v2 2/5] i2c: davinci: query STP always when NACK is received Grygorii Strashko
2014-11-26 13:59 ` Grygorii Strashko
2014-11-26 13:59 ` Grygorii Strashko
[not found] ` <1417010393-30598-3-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org>
2014-11-26 15:57 ` Uwe Kleine-König
2014-11-26 15:57 ` Uwe Kleine-König
2014-11-26 15:57 ` Uwe Kleine-König
2014-11-26 16:31 ` Grygorii Strashko
2014-11-26 16:31 ` Grygorii Strashko
2014-11-26 16:31 ` Grygorii Strashko
2014-11-26 17:15 ` Uwe Kleine-König [this message]
2014-11-26 17:15 ` Uwe Kleine-König
2014-11-26 13:59 ` [PATCH v2 3/5] i2c: recovery: change input parameter to i2c_adapter for prepare/unprepare_recovery Grygorii Strashko
2014-11-26 13:59 ` Grygorii Strashko
2014-11-26 13:59 ` Grygorii Strashko
2014-11-26 13:59 ` [PATCH v2 4/5] i2c: davinci: use bus recovery infrastructure Grygorii Strashko
2014-11-26 13:59 ` Grygorii Strashko
2014-11-26 13:59 ` Grygorii Strashko
[not found] ` <1417010393-30598-5-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org>
2014-11-26 15:59 ` Uwe Kleine-König
2014-11-26 15:59 ` Uwe Kleine-König
2014-11-26 15:59 ` Uwe Kleine-König
2014-11-26 13:59 ` [PATCH v2 5/5] i2c: davinci: use ICPFUNC to toggle I2C as gpio for bus recovery Grygorii Strashko
2014-11-26 13:59 ` Grygorii Strashko
2014-11-26 13:59 ` Grygorii Strashko
[not found] ` <1417010393-30598-6-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org>
2014-11-26 16:04 ` Uwe Kleine-König
2014-11-26 16:04 ` Uwe Kleine-König
2014-11-26 16:04 ` Uwe Kleine-König
[not found] ` <20141126160407.GN4431-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-11-26 17:05 ` Grygorii Strashko
2014-11-26 17:05 ` Grygorii Strashko
2014-11-26 17:05 ` Grygorii Strashko
[not found] ` <5476085B.40009-l0cyMroinI0@public.gmane.org>
2015-07-07 13:37 ` Jan Lübbe
2015-07-07 13:37 ` Jan Lübbe
2015-07-07 13:37 ` Jan Lübbe
[not found] ` <1436276269.3344.94.camel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-07-07 13:43 ` Wolfram Sang
2015-07-07 13:43 ` Wolfram Sang
2015-07-07 13:43 ` Wolfram Sang
2015-07-07 13:48 ` Uwe Kleine-König
2015-07-07 13:48 ` Uwe Kleine-König
2015-07-07 13:48 ` Uwe Kleine-König
[not found] ` <20150707134852.GE9671-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-07-07 14:13 ` Wolfram Sang
2015-07-07 14:13 ` Wolfram Sang
2015-07-07 14:13 ` Wolfram Sang
2015-07-07 14:53 ` Grygorii Strashko
2015-07-07 14:53 ` Grygorii Strashko
2015-07-07 14:53 ` Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141126171519.GP4431@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=grygorii.strashko@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=milo-software@users.sourceforge.net \
--cc=nsekhar@ti.com \
--cc=ssantosh@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.