From: Lina Iyer <lina.iyer@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: daniel.lezcano@linaro.org, khilman@linaro.org,
galak@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
lorenzo.pieralisi@arm.com, msivasub@codeaurora.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v10 02/10] qcom: scm: Add SCM warmboot support for quad core SoCs
Date: Wed, 26 Nov 2014 12:56:36 -0700 [thread overview]
Message-ID: <20141126195636.GE594@linaro.org> (raw)
In-Reply-To: <54762E88.50300@codeaurora.org>
On Wed, Nov 26 2014 at 12:48 -0700, Stephen Boyd wrote:
>On 11/21/2014 10:03 AM, Lina Iyer wrote:
>>@@ -37,3 +54,17 @@ int scm_set_boot_addr(phys_addr_t addr, int flags)
>> &cmd, sizeof(cmd), NULL, 0);
>> }
>> EXPORT_SYMBOL(scm_set_boot_addr);
>>+
>>+int scm_set_warm_boot_addr(void *entry, int cpu)
>>+{
>>+ int ret;
>>+
>>+ if (entry == scm_flags[cpu].entry)
>>+ return 0;
>
>Is the entry going to be different at some point? I wonder why we
>can't just call this function once when the SPM device probes to setup
>the entry point to cpu_resume()?
>
Hotplug would use a different re-entry point. Hence the check.
>--
>Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
>a Linux Foundation Collaborative Project
>
WARNING: multiple messages have this Message-ID (diff)
From: lina.iyer@linaro.org (Lina Iyer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v10 02/10] qcom: scm: Add SCM warmboot support for quad core SoCs
Date: Wed, 26 Nov 2014 12:56:36 -0700 [thread overview]
Message-ID: <20141126195636.GE594@linaro.org> (raw)
In-Reply-To: <54762E88.50300@codeaurora.org>
On Wed, Nov 26 2014 at 12:48 -0700, Stephen Boyd wrote:
>On 11/21/2014 10:03 AM, Lina Iyer wrote:
>>@@ -37,3 +54,17 @@ int scm_set_boot_addr(phys_addr_t addr, int flags)
>> &cmd, sizeof(cmd), NULL, 0);
>> }
>> EXPORT_SYMBOL(scm_set_boot_addr);
>>+
>>+int scm_set_warm_boot_addr(void *entry, int cpu)
>>+{
>>+ int ret;
>>+
>>+ if (entry == scm_flags[cpu].entry)
>>+ return 0;
>
>Is the entry going to be different at some point? I wonder why we
>can't just call this function once when the SPM device probes to setup
>the entry point to cpu_resume()?
>
Hotplug would use a different re-entry point. Hence the check.
>--
>Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
>a Linux Foundation Collaborative Project
>
next prev parent reply other threads:[~2014-11-26 19:56 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 18:03 [PATCH v10 00/10] cpuidle driver for QCOM SoCs: 8064, 8074, 8084 Lina Iyer
2014-11-21 18:03 ` Lina Iyer
2014-11-21 18:03 ` [PATCH v10 01/10] qom: scm: Move scm-boot files to drivers/soc/qcom/ and include/soc/qcom Lina Iyer
2014-11-21 18:03 ` Lina Iyer
2014-11-26 19:41 ` Stephen Boyd
2014-11-26 19:41 ` Stephen Boyd
2014-11-21 18:03 ` [PATCH v10 02/10] qcom: scm: Add SCM warmboot support for quad core SoCs Lina Iyer
2014-11-21 18:03 ` Lina Iyer
2014-11-26 9:41 ` Daniel Lezcano
2014-11-26 9:41 ` Daniel Lezcano
2014-11-26 19:48 ` Stephen Boyd
2014-11-26 19:48 ` Stephen Boyd
2014-11-26 19:56 ` Lina Iyer [this message]
2014-11-26 19:56 ` Lina Iyer
2014-11-21 18:03 ` [PATCH v10 03/10] qcom: spm: Add Subsystem Power Manager driver Lina Iyer
2014-11-21 18:03 ` Lina Iyer
2014-11-26 20:00 ` Stephen Boyd
2014-11-26 20:00 ` Stephen Boyd
2014-11-21 18:03 ` [PATCH v10 04/10] arm: dts: qcom: Add power-controller device node for 8074 Krait CPUs Lina Iyer
2014-11-21 18:03 ` Lina Iyer
2014-11-26 20:01 ` Stephen Boyd
2014-11-26 20:01 ` Stephen Boyd
2014-11-21 18:03 ` [PATCH v10 05/10] arm: dts: qcom: Add power-controller device node for 8084 " Lina Iyer
2014-11-21 18:03 ` Lina Iyer
2014-11-26 20:05 ` Stephen Boyd
2014-11-26 20:05 ` Stephen Boyd
2014-11-21 18:03 ` [PATCH v10 06/10] arm: dts: qcom: Update power-controller device node for 8064 " Lina Iyer
2014-11-21 18:03 ` Lina Iyer
2014-11-26 20:06 ` Stephen Boyd
2014-11-26 20:06 ` Stephen Boyd
2014-11-21 18:03 ` [PATCH v10 07/10] qcom: cpuidle: Add cpuidle driver for QCOM cpus Lina Iyer
2014-11-21 18:03 ` Lina Iyer
2014-11-26 10:04 ` Daniel Lezcano
2014-11-26 10:04 ` Daniel Lezcano
2014-11-26 19:43 ` Kevin Hilman
2014-11-26 19:43 ` Kevin Hilman
2014-11-27 10:23 ` Lorenzo Pieralisi
2014-11-27 10:23 ` Lorenzo Pieralisi
2014-11-26 17:59 ` Lorenzo Pieralisi
2014-11-26 17:59 ` Lorenzo Pieralisi
2014-11-26 21:03 ` Lina Iyer
2014-11-26 21:03 ` Lina Iyer
[not found] ` <1416593037-27527-1-git-send-email-lina.iyer-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-11-21 18:03 ` [PATCH v10 08/10] arm: dts: qcom: Add idle states device nodes for 8074 Lina Iyer
2014-11-21 18:03 ` Lina Iyer
2014-11-26 20:15 ` Stephen Boyd
2014-11-26 20:15 ` Stephen Boyd
2014-11-21 18:03 ` [PATCH v10 09/10] arm: dts: qcom: Add idle states device nodes for 8084 Lina Iyer
2014-11-21 18:03 ` Lina Iyer
2014-11-26 20:16 ` Stephen Boyd
2014-11-26 20:16 ` Stephen Boyd
2014-11-21 18:03 ` [PATCH v10 10/10] arm: dts: qcom: Add idle state device nodes for 8064 Lina Iyer
2014-11-21 18:03 ` Lina Iyer
2014-11-26 20:18 ` Stephen Boyd
2014-11-26 20:18 ` Stephen Boyd
2014-11-25 19:11 ` [PATCH v10 00/10] cpuidle driver for QCOM SoCs: 8064, 8074, 8084 Lina Iyer
2014-11-25 19:11 ` Lina Iyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141126195636.GE594@linaro.org \
--to=lina.iyer@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=msivasub@codeaurora.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.