From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/9] clk: sunxi: Give sunxi_factors_register a registers parameter
Date: Wed, 26 Nov 2014 21:40:00 +0100 [thread overview]
Message-ID: <20141126204000.GM25249@lukather> (raw)
In-Reply-To: <1416749895-25013-2-git-send-email-hdegoede@redhat.com>
On Sun, Nov 23, 2014 at 02:38:07PM +0100, Hans de Goede wrote:
> Before this commit sunxi_factors_register uses of_iomap(node, 0) to get
> the clk registers. The sun6i prcm has factor clocks, for which we want to
> use sunxi_factors_register, but of_iomap(node, 0) does not work for the prcm
> factor clocks, because the prcm uses the mfd framework, so the registers
> are not part of the dt-node, instead they are added to the platform_device,
> as platform_device resources.
>
> This commit makes getting the registers the callers duty, so that
> sunxi_factors_register can be used with mfd instantiated platform device too.
>
> While at it also add error checking to the of_iomap calls.
>
> This commit also drops the __init function from sunxi_factors_register since
> platform driver probe functions are not __init.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Queued for 3.20, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141126/e3e5ffcc/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Emilio Lopez <emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org>,
Mike Turquette
<mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Linux Media Mailing List
<linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH v2 1/9] clk: sunxi: Give sunxi_factors_register a registers parameter
Date: Wed, 26 Nov 2014 21:40:00 +0100 [thread overview]
Message-ID: <20141126204000.GM25249@lukather> (raw)
In-Reply-To: <1416749895-25013-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1050 bytes --]
On Sun, Nov 23, 2014 at 02:38:07PM +0100, Hans de Goede wrote:
> Before this commit sunxi_factors_register uses of_iomap(node, 0) to get
> the clk registers. The sun6i prcm has factor clocks, for which we want to
> use sunxi_factors_register, but of_iomap(node, 0) does not work for the prcm
> factor clocks, because the prcm uses the mfd framework, so the registers
> are not part of the dt-node, instead they are added to the platform_device,
> as platform_device resources.
>
> This commit makes getting the registers the callers duty, so that
> sunxi_factors_register can be used with mfd instantiated platform device too.
>
> While at it also add error checking to the of_iomap calls.
>
> This commit also drops the __init function from sunxi_factors_register since
> platform driver probe functions are not __init.
>
> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Queued for 3.20, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Emilio Lopez <emilio@elopez.com.ar>,
Mike Turquette <mturquette@linaro.org>,
Lee Jones <lee.jones@linaro.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org,
devicetree <devicetree@vger.kernel.org>,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH v2 1/9] clk: sunxi: Give sunxi_factors_register a registers parameter
Date: Wed, 26 Nov 2014 21:40:00 +0100 [thread overview]
Message-ID: <20141126204000.GM25249@lukather> (raw)
In-Reply-To: <1416749895-25013-2-git-send-email-hdegoede@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]
On Sun, Nov 23, 2014 at 02:38:07PM +0100, Hans de Goede wrote:
> Before this commit sunxi_factors_register uses of_iomap(node, 0) to get
> the clk registers. The sun6i prcm has factor clocks, for which we want to
> use sunxi_factors_register, but of_iomap(node, 0) does not work for the prcm
> factor clocks, because the prcm uses the mfd framework, so the registers
> are not part of the dt-node, instead they are added to the platform_device,
> as platform_device resources.
>
> This commit makes getting the registers the callers duty, so that
> sunxi_factors_register can be used with mfd instantiated platform device too.
>
> While at it also add error checking to the of_iomap calls.
>
> This commit also drops the __init function from sunxi_factors_register since
> platform driver probe functions are not __init.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Queued for 3.20, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-11-26 20:40 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-23 13:38 [PATCH v2 0/9] sun6i / A31 ir receiver support Hans de Goede
2014-11-23 13:38 ` Hans de Goede
2014-11-23 13:38 ` Hans de Goede
2014-11-23 13:38 ` [PATCH v2 1/9] clk: sunxi: Give sunxi_factors_register a registers parameter Hans de Goede
2014-11-23 13:38 ` Hans de Goede
2014-11-23 13:38 ` Hans de Goede
2014-11-26 20:40 ` Maxime Ripard [this message]
2014-11-26 20:40 ` Maxime Ripard
2014-11-26 20:40 ` Maxime Ripard
2014-11-23 13:38 ` [PATCH v2 2/9] clk: sunxi: Make sun4i_a10_mod0_data available outside of clk-mod0.c Hans de Goede
2014-11-23 13:38 ` Hans de Goede
2014-11-23 13:38 ` Hans de Goede
2014-11-23 13:38 ` [PATCH v2 3/9] clk: sunxi: Add prcm mod0 clock driver Hans de Goede
2014-11-23 13:38 ` Hans de Goede
2014-11-23 13:38 ` Hans de Goede
2014-11-25 16:57 ` Lee Jones
2014-11-25 16:57 ` Lee Jones
2014-11-25 16:57 ` Lee Jones
2014-11-26 8:04 ` Hans de Goede
2014-11-26 8:04 ` Hans de Goede
2014-11-26 8:04 ` Hans de Goede
2014-11-27 8:36 ` Lee Jones
2014-11-27 8:36 ` Lee Jones
2014-11-27 8:36 ` Lee Jones
2014-11-23 13:38 ` [PATCH v2 4/9] rc: sunxi-cir: Add support for an optional reset controller Hans de Goede
2014-11-23 13:38 ` Hans de Goede
2014-11-23 13:38 ` Hans de Goede
2014-11-23 13:38 ` [PATCH v2 5/9] rc: sunxi-cir: Add support for the larger fifo found on sun5i and sun6i Hans de Goede
2014-11-23 13:38 ` Hans de Goede
2014-11-23 13:38 ` Hans de Goede
2014-11-23 13:38 ` [PATCH v2 6/9] ARM: dts: sun6i: Add ir_clk node Hans de Goede
2014-11-23 13:38 ` Hans de Goede
2014-11-23 13:38 ` Hans de Goede
2014-11-23 13:38 ` [PATCH v2 7/9] ARM: dts: sun6i: Add ir node Hans de Goede
2014-11-23 13:38 ` Hans de Goede
2014-11-23 13:38 ` Hans de Goede
2014-11-23 13:38 ` [PATCH v2 8/9] ARM: dts: sun6i: Add pinmux settings for the ir pins Hans de Goede
2014-11-23 13:38 ` Hans de Goede
2014-11-23 13:38 ` Hans de Goede
2014-11-27 9:14 ` Maxime Ripard
2014-11-27 9:14 ` Maxime Ripard
2014-11-27 9:14 ` Maxime Ripard
2014-11-23 13:38 ` [PATCH v2 9/9] ARM: dts: sun6i: Enable ir receiver on the Mele M9 Hans de Goede
2014-11-23 13:38 ` Hans de Goede
2014-11-23 13:38 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141126204000.GM25249@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.