* [patch] ALSA: hda - using uninitialized data
@ 2014-11-26 22:34 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2014-11-26 22:34 UTC (permalink / raw)
To: Jaroslav Kysela, Danny Tholen
Cc: Takashi Iwai, Mengdong Lin, alsa-devel, kernel-janitors,
David Henningsson
In olden times the snd_hda_param_read() function always set "*start_id"
but in 2007 we introduced a new return and it causes uninitialized data
bugs in a couple of the callers: print_codec_info() and
hdmi_parse_codec().
Fixes: e8a7f136f5ed ('[ALSA] hda-intel - Improve HD-audio codec probing robustness')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This is from static analysis. Untested.
diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index b2d5899..2fe86d2 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -346,8 +346,10 @@ int snd_hda_get_sub_nodes(struct hda_codec *codec, hda_nid_t nid,
unsigned int parm;
parm = snd_hda_param_read(codec, nid, AC_PAR_NODE_COUNT);
- if (parm == -1)
+ if (parm == -1) {
+ *start_id = 0;
return 0;
+ }
*start_id = (parm >> 16) & 0x7fff;
return (int)(parm & 0x7fff);
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* [patch] ALSA: hda - using uninitialized data
@ 2014-11-26 22:34 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2014-11-26 22:34 UTC (permalink / raw)
To: Jaroslav Kysela, Danny Tholen
Cc: Takashi Iwai, Mengdong Lin, alsa-devel, kernel-janitors,
David Henningsson
In olden times the snd_hda_param_read() function always set "*start_id"
but in 2007 we introduced a new return and it causes uninitialized data
bugs in a couple of the callers: print_codec_info() and
hdmi_parse_codec().
Fixes: e8a7f136f5ed ('[ALSA] hda-intel - Improve HD-audio codec probing robustness')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This is from static analysis. Untested.
diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index b2d5899..2fe86d2 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -346,8 +346,10 @@ int snd_hda_get_sub_nodes(struct hda_codec *codec, hda_nid_t nid,
unsigned int parm;
parm = snd_hda_param_read(codec, nid, AC_PAR_NODE_COUNT);
- if (parm = -1)
+ if (parm = -1) {
+ *start_id = 0;
return 0;
+ }
*start_id = (parm >> 16) & 0x7fff;
return (int)(parm & 0x7fff);
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [patch] ALSA: hda - using uninitialized data
2014-11-26 22:34 ` Dan Carpenter
@ 2014-11-27 8:38 ` Takashi Iwai
-1 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2014-11-27 8:38 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jaroslav Kysela, Danny Tholen, Mengdong Lin, David Henningsson,
alsa-devel, kernel-janitors
At Thu, 27 Nov 2014 01:34:43 +0300,
Dan Carpenter wrote:
>
> In olden times the snd_hda_param_read() function always set "*start_id"
> but in 2007 we introduced a new return and it causes uninitialized data
> bugs in a couple of the callers: print_codec_info() and
> hdmi_parse_codec().
>
> Fixes: e8a7f136f5ed ('[ALSA] hda-intel - Improve HD-audio codec probing robustness')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> This is from static analysis. Untested.
Applied, thanks.
Takashi
>
> diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
> index b2d5899..2fe86d2 100644
> --- a/sound/pci/hda/hda_codec.c
> +++ b/sound/pci/hda/hda_codec.c
> @@ -346,8 +346,10 @@ int snd_hda_get_sub_nodes(struct hda_codec *codec, hda_nid_t nid,
> unsigned int parm;
>
> parm = snd_hda_param_read(codec, nid, AC_PAR_NODE_COUNT);
> - if (parm == -1)
> + if (parm == -1) {
> + *start_id = 0;
> return 0;
> + }
> *start_id = (parm >> 16) & 0x7fff;
> return (int)(parm & 0x7fff);
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [patch] ALSA: hda - using uninitialized data
@ 2014-11-27 8:38 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2014-11-27 8:38 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jaroslav Kysela, Danny Tholen, Mengdong Lin, David Henningsson,
alsa-devel, kernel-janitors
At Thu, 27 Nov 2014 01:34:43 +0300,
Dan Carpenter wrote:
>
> In olden times the snd_hda_param_read() function always set "*start_id"
> but in 2007 we introduced a new return and it causes uninitialized data
> bugs in a couple of the callers: print_codec_info() and
> hdmi_parse_codec().
>
> Fixes: e8a7f136f5ed ('[ALSA] hda-intel - Improve HD-audio codec probing robustness')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> This is from static analysis. Untested.
Applied, thanks.
Takashi
>
> diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
> index b2d5899..2fe86d2 100644
> --- a/sound/pci/hda/hda_codec.c
> +++ b/sound/pci/hda/hda_codec.c
> @@ -346,8 +346,10 @@ int snd_hda_get_sub_nodes(struct hda_codec *codec, hda_nid_t nid,
> unsigned int parm;
>
> parm = snd_hda_param_read(codec, nid, AC_PAR_NODE_COUNT);
> - if (parm = -1)
> + if (parm = -1) {
> + *start_id = 0;
> return 0;
> + }
> *start_id = (parm >> 16) & 0x7fff;
> return (int)(parm & 0x7fff);
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-11-27 8:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-26 22:34 [patch] ALSA: hda - using uninitialized data Dan Carpenter
2014-11-26 22:34 ` Dan Carpenter
2014-11-27 8:38 ` Takashi Iwai
2014-11-27 8:38 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.