From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Zidan Wang <b50113@freescale.com>
Cc: alsa-devel@alsa-project.org, lars@metafoo.de, tiwai@suse.de,
linux-kernel@vger.kernel.org, broonie@kernel.org,
patches@opensource.wolfsonmicro.com, lgirdwood@gmail.com,
Li.Xiubo@freescale.com
Subject: Re: [PATCH] ASoC: wm8960: Move register initialisation to I2C driver probe()
Date: Thu, 27 Nov 2014 10:19:11 +0000 [thread overview]
Message-ID: <20141127101911.GB13764@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1417078388-1289-1-git-send-email-b50113@freescale.com>
On Thu, Nov 27, 2014 at 04:53:08PM +0800, Zidan Wang wrote:
> We must ensure that the clocking configuration is valid as rapidly as possible.
> And do software reset before the others registers updates, or the registers
> will be reset to the default state.
>
> Signed-off-by: Zidan Wang <b50113@freescale.com>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Looks ok to me.
Thanks,
Charles
WARNING: multiple messages have this Message-ID (diff)
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Zidan Wang <b50113@freescale.com>
Cc: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.de, lars@metafoo.de, Li.Xiubo@freescale.com,
patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel][PATCH] ASoC: wm8960: Move register initialisation to I2C driver probe()
Date: Thu, 27 Nov 2014 10:19:11 +0000 [thread overview]
Message-ID: <20141127101911.GB13764@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1417078388-1289-1-git-send-email-b50113@freescale.com>
On Thu, Nov 27, 2014 at 04:53:08PM +0800, Zidan Wang wrote:
> We must ensure that the clocking configuration is valid as rapidly as possible.
> And do software reset before the others registers updates, or the registers
> will be reset to the default state.
>
> Signed-off-by: Zidan Wang <b50113@freescale.com>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Looks ok to me.
Thanks,
Charles
next prev parent reply other threads:[~2014-11-27 10:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 8:53 [PATCH] ASoC: wm8960: Move register initialisation to I2C driver probe() Zidan Wang
2014-11-27 8:53 ` [alsa-devel][PATCH] " Zidan Wang
2014-11-27 10:19 ` Charles Keepax [this message]
2014-11-27 10:19 ` Charles Keepax
2014-11-27 10:35 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141127101911.GB13764@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=b50113@freescale.com \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.