From: "Michael S. Tsirkin" <mst@redhat.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, David Miller <davem@davemloft.net>,
rusty@au1.ibm.com, nab@linux-iscsi.org, pbonzini@redhat.com,
Rusty Russell <rusty@rustcorp.com.au>,
Christian Borntraeger <borntraeger@de.ibm.com>,
linux390@de.ibm.com, Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Pawel Moll <pawel.moll@arm.com>, Ohad Ben-Cohen <ohad@wizery.com>,
Sudeep Dutt <sudeep.dutt@intel.com>,
Ashutosh Dixit <ashutosh.dixit@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nikhil Rao <nikhil.rao@intel.com>,
Siva Yerramreddy <yshivakrishna@gmail.com>,
lguest@lists.ozlabs.org, linux-s390@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v4 04/42] virtio: disable virtio 1.0 in transports
Date: Thu, 27 Nov 2014 13:06:01 +0200 [thread overview]
Message-ID: <20141127110601.GB8961@redhat.com> (raw)
In-Reply-To: <20141127120252.27021c54.cornelia.huck@de.ibm.com>
On Thu, Nov 27, 2014 at 12:02:52PM +0100, Cornelia Huck wrote:
> On Thu, 27 Nov 2014 12:54:34 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > On Wed, Nov 26, 2014 at 10:09:54AM +0100, Cornelia Huck wrote:
>
> > > The old s390 virtio transport in kvm_virtio.c is not part of virtio 1.0.
> >
> > It might or might not be a good idea to add code in kvm_virtio.c
> > blacklisting VIRTIO_F_VERSION_1, just in case there's a buggy device
> > that sets it.
> > As correct devices won't set it, I don't think we need to
> > worry about it too much. We can make it a patch on top later
> > if we want.
> >
>
> I'd want to blacklist it, just to make sure nothing weird happens. I
> don't want to spend effort on the old transport beyond that :)
I have a better idea. you'll see it in v5.
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: linux-s390@vger.kernel.org, lguest@lists.ozlabs.org,
Pawel Moll <pawel.moll@arm.com>,
rusty@au1.ibm.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-kernel@vger.kernel.org, Sudeep Dutt <sudeep.dutt@intel.com>,
Ashutosh Dixit <ashutosh.dixit@intel.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Siva Yerramreddy <yshivakrishna@gmail.com>,
linux390@de.ibm.com, Martin Schwidefsky <schwidefsky@de.ibm.com>,
pbonzini@redhat.com, virtualization@lists.linux-foundation.org,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH v4 04/42] virtio: disable virtio 1.0 in transports
Date: Thu, 27 Nov 2014 13:06:01 +0200 [thread overview]
Message-ID: <20141127110601.GB8961@redhat.com> (raw)
In-Reply-To: <20141127120252.27021c54.cornelia.huck@de.ibm.com>
On Thu, Nov 27, 2014 at 12:02:52PM +0100, Cornelia Huck wrote:
> On Thu, 27 Nov 2014 12:54:34 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > On Wed, Nov 26, 2014 at 10:09:54AM +0100, Cornelia Huck wrote:
>
> > > The old s390 virtio transport in kvm_virtio.c is not part of virtio 1.0.
> >
> > It might or might not be a good idea to add code in kvm_virtio.c
> > blacklisting VIRTIO_F_VERSION_1, just in case there's a buggy device
> > that sets it.
> > As correct devices won't set it, I don't think we need to
> > worry about it too much. We can make it a patch on top later
> > if we want.
> >
>
> I'd want to blacklist it, just to make sure nothing weird happens. I
> don't want to spend effort on the old transport beyond that :)
I have a better idea. you'll see it in v5.
next prev parent reply other threads:[~2014-11-27 11:06 UTC|newest]
Thread overview: 162+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 16:41 [PATCH v4 00/42] linux: towards virtio-1 guest support Michael S. Tsirkin
2014-11-25 16:41 ` [PATCH v4 01/42] virtio: use u32, not bitmap for struct virtio_device's features Michael S. Tsirkin
2014-11-25 16:41 ` Michael S. Tsirkin
2014-11-25 16:41 ` [PATCH v4 02/42] virtio: add support for 64 bit features Michael S. Tsirkin
2014-11-25 16:41 ` Michael S. Tsirkin
2014-11-26 16:48 ` Greg Kurz
2014-11-26 16:48 ` Greg Kurz
2014-11-26 16:56 ` Michael S. Tsirkin
2014-11-26 16:56 ` Michael S. Tsirkin
2014-11-25 16:41 ` [PATCH v4 03/42] virtio: add virtio 1.0 feature bit Michael S. Tsirkin
2014-11-25 16:41 ` Michael S. Tsirkin
2014-11-25 16:41 ` [PATCH v4 04/42] virtio: disable virtio 1.0 in transports Michael S. Tsirkin
2014-11-25 16:41 ` Michael S. Tsirkin
2014-11-25 17:29 ` Cornelia Huck
2014-11-25 17:29 ` Cornelia Huck
2014-11-25 21:20 ` Michael S. Tsirkin
2014-11-25 21:20 ` Michael S. Tsirkin
2014-11-26 9:09 ` Cornelia Huck
2014-11-26 9:09 ` Cornelia Huck
2014-11-27 10:54 ` Michael S. Tsirkin
2014-11-27 10:54 ` Michael S. Tsirkin
2014-11-27 11:02 ` Cornelia Huck
2014-11-27 11:02 ` Cornelia Huck
2014-11-27 11:06 ` Michael S. Tsirkin [this message]
2014-11-27 11:06 ` Michael S. Tsirkin
2014-11-25 16:41 ` [PATCH v4 05/42] virtio: memory access APIs Michael S. Tsirkin
2014-11-25 16:41 ` Michael S. Tsirkin
2014-11-25 17:42 ` Cornelia Huck
2014-11-25 17:42 ` Cornelia Huck
2014-11-25 16:41 ` [PATCH v4 06/42] virtio_ring: switch to new " Michael S. Tsirkin
2014-11-25 16:41 ` Michael S. Tsirkin
2014-11-25 16:41 ` [PATCH v4 07/42] virtio_config: endian conversion for v1.0 Michael S. Tsirkin
2014-11-25 16:41 ` Michael S. Tsirkin
2014-11-25 17:45 ` Cornelia Huck
2014-11-25 17:45 ` Cornelia Huck
2014-11-25 21:36 ` Michael S. Tsirkin
2014-11-25 21:36 ` Michael S. Tsirkin
2014-11-26 9:13 ` Cornelia Huck
2014-11-26 9:13 ` Cornelia Huck
2014-11-25 16:41 ` [PATCH v4 08/42] virtio: allow transports to get avail/used addresses Michael S. Tsirkin
2014-11-25 16:41 ` Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 09/42] virtio: set FEATURES_OK Michael S. Tsirkin
2014-11-25 16:42 ` Michael S. Tsirkin
2014-11-25 17:48 ` Cornelia Huck
2014-11-25 17:48 ` Cornelia Huck
2014-11-25 21:38 ` Michael S. Tsirkin
2014-11-25 21:38 ` Michael S. Tsirkin
2014-11-26 9:18 ` Cornelia Huck
2014-11-26 9:18 ` Cornelia Huck
2014-11-25 16:42 ` [PATCH v4 10/42] virtio: simplify feature bit handling Michael S. Tsirkin
2014-11-25 16:42 ` Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 11/42] virtio: add legacy feature table support Michael S. Tsirkin
2014-11-25 16:42 ` Michael S. Tsirkin
2014-11-25 17:53 ` Cornelia Huck
2014-11-25 17:53 ` Cornelia Huck
2014-11-25 21:39 ` Michael S. Tsirkin
2014-11-25 21:39 ` Michael S. Tsirkin
2014-11-26 9:19 ` Cornelia Huck
2014-11-26 9:19 ` Cornelia Huck
2014-11-25 16:42 ` [PATCH v4 12/42] virtio_net: v1.0 endianness Michael S. Tsirkin
2014-11-25 16:42 ` Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 13/42] virtio_blk: v1.0 support Michael S. Tsirkin
2014-11-25 16:42 ` Michael S. Tsirkin
2014-11-25 17:55 ` Cornelia Huck
[not found] ` <1416933600-21398-14-git-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-11-25 17:55 ` Cornelia Huck
2014-11-25 17:55 ` Cornelia Huck
2014-11-25 21:43 ` Michael S. Tsirkin
2014-11-25 21:43 ` Michael S. Tsirkin
2014-11-26 15:40 ` David Hildenbrand
2014-11-26 15:40 ` David Hildenbrand
2014-11-26 15:48 ` Michael S. Tsirkin
2014-11-26 15:48 ` Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 14/42] KVM: s390: Set virtio-ccw transport revision Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 15/42] KVM: s390: virtio-ccw revision 1 SET_VQ Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 16/42] KVM: s390 allow virtio_ccw status writes to fail Michael S. Tsirkin
2014-11-25 17:57 ` Cornelia Huck
2014-11-25 16:42 ` [PATCH v4 17/42] KVM: s390: enable virtio-ccw revision 1 Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 18/42] virtio_blk: make serial attribute static Michael S. Tsirkin
2014-11-25 16:42 ` Michael S. Tsirkin
2014-11-26 8:48 ` Gerd Hoffmann
2014-11-26 8:48 ` Gerd Hoffmann
2014-11-26 9:50 ` Cornelia Huck
2014-11-26 9:50 ` Cornelia Huck
2014-11-25 16:42 ` [PATCH v4 19/42] virtio_blk: fix race at module removal Michael S. Tsirkin
2014-11-25 16:42 ` Michael S. Tsirkin
2014-11-26 9:53 ` Cornelia Huck
2014-11-26 9:53 ` Cornelia Huck
2014-11-25 16:42 ` [PATCH v4 20/42] virtio_net: pass vi around Michael S. Tsirkin
2014-11-25 16:42 ` Michael S. Tsirkin
2014-11-26 12:35 ` Cornelia Huck
2014-11-26 12:35 ` Cornelia Huck
2014-11-25 16:42 ` [PATCH v4 21/42] virtio_net: get rid of virtio_net_hdr/skb_vnet_hdr Michael S. Tsirkin
2014-11-25 16:42 ` Michael S. Tsirkin
2014-11-26 12:50 ` Cornelia Huck
2014-11-26 12:50 ` Cornelia Huck
2014-11-26 13:11 ` Michael S. Tsirkin
2014-11-26 13:11 ` Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 22/42] virtio_net: stricter short buffer length checks Michael S. Tsirkin
2014-11-25 16:42 ` Michael S. Tsirkin
2014-11-26 13:00 ` Cornelia Huck
2014-11-26 13:00 ` Cornelia Huck
2014-11-25 16:43 ` [PATCH v4 23/42] virtio_net: bigger header when VERSION_1 is set Michael S. Tsirkin
2014-11-25 16:43 ` Michael S. Tsirkin
2014-11-26 13:04 ` Cornelia Huck
2014-11-26 13:04 ` Cornelia Huck
2014-11-25 16:43 ` [PATCH v4 24/42] virtio_net: enable v1.0 support Michael S. Tsirkin
2014-11-25 16:43 ` Michael S. Tsirkin
2014-11-26 13:08 ` Cornelia Huck
2014-11-26 13:08 ` Cornelia Huck
2014-11-26 13:28 ` Michael S. Tsirkin
2014-11-26 13:28 ` Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 25/42] vhost: add memory access wrappers Michael S. Tsirkin
2014-11-25 16:43 ` Michael S. Tsirkin
2014-11-26 13:54 ` Cornelia Huck
2014-11-26 13:54 ` Cornelia Huck
2014-11-26 14:05 ` Michael S. Tsirkin
2014-11-26 14:05 ` Michael S. Tsirkin
2014-11-26 14:17 ` Cornelia Huck
2014-11-26 14:17 ` Cornelia Huck
2014-11-26 14:24 ` Michael S. Tsirkin
2014-11-26 14:24 ` Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 26/42] vhost/net: force len for TX to host endian Michael S. Tsirkin
2014-11-25 16:43 ` Michael S. Tsirkin
2014-11-26 14:31 ` Cornelia Huck
2014-11-26 14:31 ` Cornelia Huck
2014-11-26 14:44 ` Michael S. Tsirkin
2014-11-26 14:44 ` Michael S. Tsirkin
2014-11-26 14:54 ` Cornelia Huck
2014-11-26 14:54 ` Cornelia Huck
2014-11-26 15:01 ` Michael S. Tsirkin
2014-11-26 15:01 ` Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 27/42] vhost: virtio 1.0 endian-ness support Michael S. Tsirkin
2014-11-25 16:43 ` Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 28/42] vhost: make features 64 bit Michael S. Tsirkin
2014-11-25 16:43 ` Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 29/42] vhost/net: virtio 1.0 byte swap Michael S. Tsirkin
2014-11-25 16:43 ` Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 30/42] vhost/net: larger header for virtio 1.0 Michael S. Tsirkin
2014-11-25 16:43 ` Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 31/42] vhost/net: enable " Michael S. Tsirkin
2014-11-25 16:43 ` Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 32/42] vhost/net: suppress compiler warning Michael S. Tsirkin
2014-11-25 16:43 ` Michael S. Tsirkin
[not found] ` <1416933600-21398-1-git-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-11-25 16:43 ` [PATCH v4 33/42] tun: move internal flag defines out of uapi Michael S. Tsirkin
2014-11-25 16:43 ` Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 35/42] tun: add VNET_LE flag Michael S. Tsirkin
2014-11-25 16:43 ` Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 34/42] tun: drop most type defines Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 36/42] tun: TUN_VNET_LE support, fix sparse warnings for virtio headers Michael S. Tsirkin
2014-11-25 16:44 ` [PATCH v4 37/42] macvtap: TUN_VNET_HDR support Michael S. Tsirkin
2014-11-25 16:44 ` [PATCH v4 38/42] virtio_scsi: v1.0 support Michael S. Tsirkin
2014-11-25 16:44 ` Michael S. Tsirkin
2014-11-26 14:51 ` Cornelia Huck
2014-11-26 14:51 ` Cornelia Huck
2014-11-26 14:56 ` Michael S. Tsirkin
2014-11-26 14:56 ` Michael S. Tsirkin
2014-11-25 16:44 ` [PATCH v4 39/42] virtio_scsi: move to uapi Michael S. Tsirkin
2014-11-25 16:44 ` [PATCH v4 40/42] virtio_scsi: export to userspace Michael S. Tsirkin
2014-11-25 16:44 ` Michael S. Tsirkin
2014-11-25 16:44 ` [PATCH v4 41/42] vhost/scsi: partial virtio 1.0 support Michael S. Tsirkin
2014-11-25 16:44 ` Michael S. Tsirkin
2014-11-25 16:44 ` [PATCH v4 42/42] af_packet: virtio 1.0 stubs Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141127110601.GB8961@redhat.com \
--to=mst@redhat.com \
--cc=ashutosh.dixit@intel.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=lguest@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=nab@linux-iscsi.org \
--cc=nikhil.rao@intel.com \
--cc=ohad@wizery.com \
--cc=pawel.moll@arm.com \
--cc=pbonzini@redhat.com \
--cc=rusty@au1.ibm.com \
--cc=rusty@rustcorp.com.au \
--cc=schwidefsky@de.ibm.com \
--cc=sudeep.dutt@intel.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=yshivakrishna@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.