From: Dan Carpenter <dan.carpenter@oracle.com>
To: 敬锐 <micky_ching@realsil.com.cn>
Cc: "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"chris@printf.net" <chris@printf.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
王炜 <wei_wang@realsil.com.cn>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"rogerable@realtek.com" <rogerable@realtek.com>,
"lee.jones@linaro.org" <lee.jones@linaro.org>
Subject: Re: [PATCH 1/2] mfd: rtsx: add func to split u32 into register
Date: Fri, 28 Nov 2014 11:54:37 +0300 [thread overview]
Message-ID: <20141128085436.GF4911@mwanda> (raw)
In-Reply-To: <5477D99C.3050903@realsil.com.cn>
On Fri, Nov 28, 2014 at 02:10:36AM +0000, 敬锐 wrote:
> eg, in sd_ops.c the cmd.arg is constructed bit by bit, we can put the right
> byte to the right register by shift, so the endian check is not need.
I looked at drivers/mmc/core/sd_ops.c and cmd.arg seems to be cpu
endian.
The new function assumes that the cpu is little endian and manually
converts it to little endian. This is an endian bug. I think my fix is
correct or something similar.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: 敬锐 <micky_ching@realsil.com.cn>
Cc: "sameo@linux.intel.com" <sameo@linux.intel.com>,
"lee.jones@linaro.org" <lee.jones@linaro.org>,
"chris@printf.net" <chris@printf.net>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
王炜 <wei_wang@realsil.com.cn>,
"rogerable@realtek.com" <rogerable@realtek.com>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>
Subject: Re: [PATCH 1/2] mfd: rtsx: add func to split u32 into register
Date: Fri, 28 Nov 2014 11:54:37 +0300 [thread overview]
Message-ID: <20141128085436.GF4911@mwanda> (raw)
In-Reply-To: <5477D99C.3050903@realsil.com.cn>
On Fri, Nov 28, 2014 at 02:10:36AM +0000, 敬锐 wrote:
> eg, in sd_ops.c the cmd.arg is constructed bit by bit, we can put the right
> byte to the right register by shift, so the endian check is not need.
I looked at drivers/mmc/core/sd_ops.c and cmd.arg seems to be cpu
endian.
The new function assumes that the cpu is little endian and manually
converts it to little endian. This is an endian bug. I think my fix is
correct or something similar.
regards,
dan carpenter
next prev parent reply other threads:[~2014-11-28 8:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 2:53 [PATCH 0/2] mmc: rtsx: add support for sdio card micky_ching
2014-11-27 2:53 ` micky_ching
2014-11-27 2:53 ` [PATCH 1/2] mfd: rtsx: add func to split u32 into register micky_ching
2014-11-27 2:53 ` micky_ching
2014-11-27 15:23 ` Dan Carpenter
2014-11-27 15:23 ` Dan Carpenter
2014-11-28 2:10 ` 敬锐
2014-11-28 2:10 ` 敬锐
2014-11-28 8:54 ` Dan Carpenter [this message]
2014-11-28 8:54 ` Dan Carpenter
2014-11-28 9:54 ` 敬锐
2014-11-28 9:54 ` 敬锐
2014-11-28 14:57 ` Dan Carpenter
2014-11-28 14:57 ` Dan Carpenter
2014-12-01 12:16 ` Lee Jones
2014-11-27 2:53 ` [PATCH 2/2] mmc: rtsx: add support for sdio card micky_ching
2014-11-27 2:53 ` micky_ching
2014-11-27 15:43 ` Dan Carpenter
2014-11-27 15:43 ` Dan Carpenter
2014-11-28 1:57 ` 敬锐
2014-11-28 1:57 ` 敬锐
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141128085436.GF4911@mwanda \
--to=dan.carpenter@oracle.com \
--cc=chris@printf.net \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=micky_ching@realsil.com.cn \
--cc=rogerable@realtek.com \
--cc=sameo@linux.intel.com \
--cc=ulf.hansson@linaro.org \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.