All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Tony Lindgren <tony@atomide.com>
Cc: arm@kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Roger Quadros <rogerq@ti.com>
Subject: Re: [GIT PULL] move omap gpmc to drivers finally
Date: Fri, 28 Nov 2014 12:28:52 +0100	[thread overview]
Message-ID: <201411281228.52786.arnd@arndb.de> (raw)
In-Reply-To: <20141126194330.GN2817@atomide.com>

On Wednesday 26 November 2014, Tony Lindgren wrote:
> The following changes since commit 6f8782a7a1c826e1c013d6b7d5504af6bcc079e6:
> 
>   ARM: OMAP2+: Remove unnecesary include in GPMC driver (2014-11-06 10:51:06 -0800)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap tags/omap-for-v3.19/gpmc-move
> 
> for you to fetch changes up to d2c70f553d7203b9bb37730e577be29794ae3169:
> 
>   memory: gpmc: Move omap gpmc code to live under drivers (2014-11-26 11:11:19 -0800)
> 
> ----------------------------------------------------------------
> We can finally move the GPMC code to live in drivers/memory
> for further clean up work. This series does the move with
> minimal changes to the code.

I just looked at this branch. It's definitely nice to move the code
to drivers/memory, but I don't like the idea of having lots of function
declarations and internal data structures in a linux/platform_data/*.h
file. We can still merge this for 3.19, but I want to make sure you have
a plan for getting rid of this (and put that into the tag description).

Does this header file get removed once all non-DT board files are gone?

How about moving the declarations into include/linux/omap-gpmc.h instead?

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] move omap gpmc to drivers finally
Date: Fri, 28 Nov 2014 12:28:52 +0100	[thread overview]
Message-ID: <201411281228.52786.arnd@arndb.de> (raw)
In-Reply-To: <20141126194330.GN2817@atomide.com>

On Wednesday 26 November 2014, Tony Lindgren wrote:
> The following changes since commit 6f8782a7a1c826e1c013d6b7d5504af6bcc079e6:
> 
>   ARM: OMAP2+: Remove unnecesary include in GPMC driver (2014-11-06 10:51:06 -0800)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap tags/omap-for-v3.19/gpmc-move
> 
> for you to fetch changes up to d2c70f553d7203b9bb37730e577be29794ae3169:
> 
>   memory: gpmc: Move omap gpmc code to live under drivers (2014-11-26 11:11:19 -0800)
> 
> ----------------------------------------------------------------
> We can finally move the GPMC code to live in drivers/memory
> for further clean up work. This series does the move with
> minimal changes to the code.

I just looked at this branch. It's definitely nice to move the code
to drivers/memory, but I don't like the idea of having lots of function
declarations and internal data structures in a linux/platform_data/*.h
file. We can still merge this for 3.19, but I want to make sure you have
a plan for getting rid of this (and put that into the tag description).

Does this header file get removed once all non-DT board files are gone?

How about moving the declarations into include/linux/omap-gpmc.h instead?

	Arnd

  reply	other threads:[~2014-11-28 11:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-26 19:43 [GIT PULL] move omap gpmc to drivers finally Tony Lindgren
2014-11-26 19:43 ` Tony Lindgren
2014-11-28 11:28 ` Arnd Bergmann [this message]
2014-11-28 11:28   ` Arnd Bergmann
2014-11-28 21:39   ` Tony Lindgren
2014-11-28 21:39     ` Tony Lindgren
2014-11-28 22:41     ` Arnd Bergmann
2014-11-28 22:41       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201411281228.52786.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=arm@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=rogerq@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.