From: Dan Carpenter <dan.carpenter@oracle.com>
To: Patrick Farrell <paf@cray.com>
Cc: "Loïc Pefferkorn" <loic@loicp.eu>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"Greg KH" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"gdonald@gmail.com" <gdonald@gmail.com>,
"HPDD-discuss@ml01.01.org" <HPDD-discuss@ml01.01.org>
Subject: Re: [HPDD-discuss] [PATCH] staging: lustre: fix sparse warnings related to lock context imbalance
Date: Fri, 28 Nov 2014 19:28:50 +0300 [thread overview]
Message-ID: <20141128162850.GJ4911@mwanda> (raw)
In-Reply-To: <DB0C8A206669AC40B1C4E52A8584A6F61496CCB5@CFWEX01.americas.cray.com>
On Fri, Nov 28, 2014 at 03:45:24PM +0000, Patrick Farrell wrote:
> Dan,
>
> I disagree about the change suggested here. In this particular code,
> 'object_attr' is distinct from 'attr', as in a 'setattr' call on an
> inode. 'cl_object' is a distinct thing from an inode/file on disk,
> and specifying it is the objects attr is helpful in understanding
> there is not a direct relationship to 'attr' in the general filesystem
> sense. (cl_object attrs are used in determining actual on disk
> attributes, but there is not a one-to-one correspondence.)
>
> I am willing to be corrected, but that is my first feeling here.
I haven't looked at it deeply. Loïc was suggesting that we need new
locking functions to deal with lustre's unwieldy naming schemes and I
think we should just fix the names...
We already have a cl_attr struct. Is that different from what
we're locking here? I don't think anyone will think this takes an inode
argument.
regards,
dan carpenter
next prev parent reply other threads:[~2014-11-28 16:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 16:15 [PATCH] staging: lustre: fix sparse warnings related to lock context imbalance Loic Pefferkorn
2014-11-26 20:54 ` Greg KH
2014-11-27 5:30 ` Loïc Pefferkorn
2014-11-27 18:34 ` Loïc Pefferkorn
2014-11-28 10:00 ` Dan Carpenter
2014-11-28 15:45 ` [HPDD-discuss] " Patrick Farrell
2014-11-28 16:28 ` Dan Carpenter [this message]
2014-11-28 22:22 ` Greg KH
2014-11-30 19:54 ` Loïc Pefferkorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141128162850.GJ4911@mwanda \
--to=dan.carpenter@oracle.com \
--cc=HPDD-discuss@ml01.01.org \
--cc=devel@driverdev.osuosl.org \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic@loicp.eu \
--cc=paf@cray.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.