All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Loïc Pefferkorn" <loic@loicp.eu>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: oleg.drokin@intel.com, andreas.dilger@intel.com,
	gdonald@gmail.com, keith.mannthey@intel.com,
	john.hammond@intel.com, devel@driverdev.osuosl.org,
	HPDD-discuss@ml01.01.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: lustre: fix sparse warnings related to lock context imbalance
Date: Sun, 30 Nov 2014 20:54:40 +0100	[thread overview]
Message-ID: <20141130195439.GA12032@iron> (raw)
In-Reply-To: <20141128222207.GC27558@kroah.com>

On Fri, Nov 28, 2014 at 02:22:07PM -0800, Greg KH wrote:
> 
> That's even worse than I imagined.  Putting sparse markings on these
> function calls is just papering over nonsense.  Please work on unwinding
> the mess so that you don't need callbacks for locks, that is an
> abstraction that isn't needed.
> 
> Same here, ick ick ick.
> 
> 
> Don't hide "implementation of locks" in functions like this, it only
> causes problems.  This code has layers of layers of layers of
> abstractions due to it wanting to be originally ported to other
> operating systems and lots of different kernel versions of Linux itself.
> Unwinding and removing those layers is a good thing to do, don't paper
> over the nonsense by putting sparse markings on pointless functions.
> 
> thanks,

Hi guys,

Thanks for your reply. I'm going to write a v2.

-- 
Cheers,
Loïc

      reply	other threads:[~2014-11-30 19:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-26 16:15 [PATCH] staging: lustre: fix sparse warnings related to lock context imbalance Loic Pefferkorn
2014-11-26 20:54 ` Greg KH
2014-11-27  5:30   ` Loïc Pefferkorn
2014-11-27 18:34   ` Loïc Pefferkorn
2014-11-28 10:00     ` Dan Carpenter
2014-11-28 15:45       ` [HPDD-discuss] " Patrick Farrell
2014-11-28 16:28         ` Dan Carpenter
2014-11-28 22:22     ` Greg KH
2014-11-30 19:54       ` Loïc Pefferkorn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141130195439.GA12032@iron \
    --to=loic@loicp.eu \
    --cc=HPDD-discuss@ml01.01.org \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gdonald@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=john.hammond@intel.com \
    --cc=keith.mannthey@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.