From: Han Pingtian <hanpt@linux.vnet.ibm.com>
To: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH v2] fix some syscall tests for 16-bit compat testing
Date: Sat, 29 Nov 2014 21:29:40 +0800 [thread overview]
Message-ID: <20141129132940.GA2715@localhost.localdomain> (raw)
In-Reply-To: <5478972F.5030503@oracle.com>
On Fri, Nov 28, 2014 at 06:39:27PM +0300, Stanislav Kholmanskikh wrote:
>
>
> On 11/28/2014 11:33 AM, Han Pingtian wrote:
> > On Mon, Nov 24, 2014 at 05:53:32PM +0300, Stanislav Kholmanskikh wrote:
> >> Hi.
> >>
> >> In general, it looks good.
> >>
> >> I have only one comment, that it's possible that the uid/gid values we pass
> >> to the syscall may not fit into UID_T/GID_T. For example, when we get uid of
> >> nobody user in runtime and pass it to chown() or etc.
> >>
> >> Yes, it's more like an artificial case, but it's.
> >>
> >> We have UID16_CHECK and GID16_CHECK macros to check if the uid/gid fits the
> >> compat mode.
> >>
> >> What do you think about using it in test cases chown01, chown03, chown04,
> >> fchown01, fchown03, fchown04, setresgid*, setresuid* ?
> >>
> >> Thank you.
> >
> > Please review new patch which included UID16_CHECK and GID16_CHECK.
> >
> > Thanks.
>
> Hi!
>
> I pushed your patch with TCID_DEFINE added (overlooked it at that time),
> and also pushed a follow-up patch which:
> * fixes setresuid02_16, setresuid03_16, setresuid04_16 - they do
> testing inside their children.
> * explicitly declares setresuid(), setresgid() in compat_16.h. This is
> to manage compilation warnings.
>
> Tested in OL6 with 2.6.39-400.215.11.el6uek.x86_64 and
> 2.6.39-400.214.5.el6uek.i686 kernels.
>
> Thank you.
>
Thanks!
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2014-12-05 1:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 13:39 [LTP] chown and 16 bit syscall testing Han Pingtian
2014-11-10 9:07 ` Stanislav Kholmanskikh
2014-11-13 7:57 ` Han Pingtian
2014-11-19 8:15 ` Stanislav Kholmanskikh
2014-11-21 7:59 ` [LTP] [PATCH] fix some syscall tests for 16-bit compat testing Han Pingtian
2014-11-24 14:53 ` Stanislav Kholmanskikh
2014-11-28 8:33 ` [LTP] [PATCH v2] " Han Pingtian
2014-11-28 15:39 ` Stanislav Kholmanskikh
2014-11-29 13:29 ` Han Pingtian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141129132940.GA2715@localhost.localdomain \
--to=hanpt@linux.vnet.ibm.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.