From: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
To: ltp-list@lists.sourceforge.net, hanpt@linux.vnet.ibm.com
Subject: Re: [LTP] chown and 16 bit syscall testing
Date: Mon, 10 Nov 2014 12:07:20 +0300 [thread overview]
Message-ID: <54608048.4000201@oracle.com> (raw)
In-Reply-To: <20141031133917.GA3195@localhost.localdomain>
Hi!
On 10/31/2014 04:39 PM, Han Pingtian wrote:
> Hey there,
>
> I found that looks like all chown test cases will be compiled to 16 bit
> compat test case, but they just call chown() something like
>
> TEST(chown(fname, uid, gid));
>
> which won't test if there is a 16 bit chown() syscall. I think maybe we
> should change it to something like below:
>
> TEST(CHOWN(fname, uid, guid));
>
> then define CHOWN like this
>
> UID_T CHOWN(void (cleanup)(void))
> {
> LTP_CREATE_SYSCALL(chown, cleanup);
> }
>
> ?
I think, this is a good idea.
And there are more such test cases, which are not fixed for the 16-bit
compat case. For example, setresuid.
So if it's possible, fixing them will be good as well;)
>
> Thanks in advance!
>
>
> ------------------------------------------------------------------------------
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2014-11-10 9:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 13:39 [LTP] chown and 16 bit syscall testing Han Pingtian
2014-11-10 9:07 ` Stanislav Kholmanskikh [this message]
2014-11-13 7:57 ` Han Pingtian
2014-11-19 8:15 ` Stanislav Kholmanskikh
2014-11-21 7:59 ` [LTP] [PATCH] fix some syscall tests for 16-bit compat testing Han Pingtian
2014-11-24 14:53 ` Stanislav Kholmanskikh
2014-11-28 8:33 ` [LTP] [PATCH v2] " Han Pingtian
2014-11-28 15:39 ` Stanislav Kholmanskikh
2014-11-29 13:29 ` Han Pingtian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54608048.4000201@oracle.com \
--to=stanislav.kholmanskikh@oracle.com \
--cc=hanpt@linux.vnet.ibm.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.