All of lore.kernel.org
 help / color / mirror / Atom feed
From: Minchan Kim <minchan@kernel.org>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Valentin Rothberg <valentinrothberg@gmail.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH next-20141127] mm: Fix comment typo "CONFIG_TRANSPARNTE_HUGE"
Date: Mon, 1 Dec 2014 09:31:56 +0900	[thread overview]
Message-ID: <20141201003156.GD11340@bbox> (raw)
In-Reply-To: <1417093031.29407.102.camel@x220>

Hello,

On Thu, Nov 27, 2014 at 01:57:11PM +0100, Paul Bolle wrote:
> The commit "mm: don't split THP page when syscall is called" added a
> reference to CONFIG_TRANSPARNTE_HUGE in a comment. Use
> CONFIG_TRANSPARENT_HUGEPAGE instead, as was probably intended.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Acked-by: Minchan Kim <minchan@kernel.org>

Thanks!

> ---
> Compile tested.
> 
> If commit "mm: don't split THP page when syscall is called" is not yet
> set in stone, I would prefer if this trivial fix would be squashed into
> that commit.

Hope so. :)

> 
>  mm/rmap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/rmap.c b/mm/rmap.c
> index d2a6e136b08d..95d394bbb6ab 100644
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -708,7 +708,7 @@ static int page_referenced_one(struct page *page, struct vm_area_struct *vma,
>  		/*
>  		 * Use pmd_freeable instead of raw pmd_dirty because in some
>  		 * of architecture, pmd_dirty is not defined unless
> -		 * CONFIG_TRANSPARNTE_HUGE is enabled
> +		 * CONFIG_TRANSPARENT_HUGEPAGE is enabled
>  		 */
>  		if (!pmd_freeable(*pmd))
>  			dirty++;
> -- 
> 1.9.3
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

-- 
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Valentin Rothberg <valentinrothberg@gmail.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH next-20141127] mm: Fix comment typo "CONFIG_TRANSPARNTE_HUGE"
Date: Mon, 1 Dec 2014 09:31:56 +0900	[thread overview]
Message-ID: <20141201003156.GD11340@bbox> (raw)
In-Reply-To: <1417093031.29407.102.camel@x220>

Hello,

On Thu, Nov 27, 2014 at 01:57:11PM +0100, Paul Bolle wrote:
> The commit "mm: don't split THP page when syscall is called" added a
> reference to CONFIG_TRANSPARNTE_HUGE in a comment. Use
> CONFIG_TRANSPARENT_HUGEPAGE instead, as was probably intended.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Acked-by: Minchan Kim <minchan@kernel.org>

Thanks!

> ---
> Compile tested.
> 
> If commit "mm: don't split THP page when syscall is called" is not yet
> set in stone, I would prefer if this trivial fix would be squashed into
> that commit.

Hope so. :)

> 
>  mm/rmap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/rmap.c b/mm/rmap.c
> index d2a6e136b08d..95d394bbb6ab 100644
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -708,7 +708,7 @@ static int page_referenced_one(struct page *page, struct vm_area_struct *vma,
>  		/*
>  		 * Use pmd_freeable instead of raw pmd_dirty because in some
>  		 * of architecture, pmd_dirty is not defined unless
> -		 * CONFIG_TRANSPARNTE_HUGE is enabled
> +		 * CONFIG_TRANSPARENT_HUGEPAGE is enabled
>  		 */
>  		if (!pmd_freeable(*pmd))
>  			dirty++;
> -- 
> 1.9.3
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

-- 
Kind regards,
Minchan Kim

  reply	other threads:[~2014-12-01  0:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-27 12:57 [PATCH next-20141127] mm: Fix comment typo "CONFIG_TRANSPARNTE_HUGE" Paul Bolle
2014-11-27 12:57 ` Paul Bolle
2014-12-01  0:31 ` Minchan Kim [this message]
2014-12-01  0:31   ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141201003156.GD11340@bbox \
    --to=minchan@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=pebolle@tiscali.nl \
    --cc=valentinrothberg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.